From: Logan Perkins <logan@lp-programming.com>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: 39687@debbugs.gnu.org
Subject: bug#39687: 26.3; Add customize-variable option for not locking keyboards
Date: Wed, 21 Jul 2021 10:52:34 -0700 [thread overview]
Message-ID: <87eebr3671.wl-logan@lp-programming.com> (raw)
In-Reply-To: <87bl6vpslj.fsf@gnus.org>
On Wed, 21 Jul 2021 08:57:44 -0700,
Lars Ingebrigtsen wrote:
>
> Logan Perkins <logan@lp-programming.com> writes:
>
> > I *think* I have a patch that still fixes the current behavior, and
> > does not reintroduce those two bugs, I've included it below.
> > Basically, the fix for Bug#5095 should only be applied if we are in
> > the right context. If we're not, the if block above puts a
> > Qswitch_frame at the head of the side queue and triggers
> > replay_entire_sequence, so we just skip the second check. It'll get
> > run again and catch the interruption on the next pass, but in the
> > right context.
>
> I tried the various test cases, and the behaviour with your patch
> clearly seems better to me, so I've applied it to Emacs 28.
I assume you only applied the patch I supplied, which improves the fix
for Bug#5095, but does not address Bug#39687. Hopefully, with that
sorted, we can discuss the issues around `temporarily_switch_to_single_kboard`.
>
> But as Eli says, this is a ticklish area, so if this (re-)introduces
> other bugs, we'll have to revert.
Fair enough. I am fairly confident that patch won't cause problems
(but it might allow latent problems to surface). This is, indeed, a
tricky area: it took the better part of 2 hours last year to "wrap my
head around" the issue well enough to write the patch. If any other
issues arise, I'm happy to address those.
>
> This change was small enough to apply without assigning copyright to the
> FSF, but for future patches you want to submit, it might make sense to
> get the paperwork started now, so that subsequent patches can be applied
> speedily. Would you be willing to sign such paperwork?
I submitted my assignment paperwork 18 May 2020, signed via GPG.
Mr. Topham responded (on 4 Jun 2020) that he was having difficulty
verifying the signature (possibly due to it being an EDDSA key?), and
that he would try again. I have heard nothing since, but did not
follow up as this thread was stalled, and last summer was a
bit... intense. I still have the assignment document and can submit
it again if that would help.
Regards,
Logan
next prev parent reply other threads:[~2021-07-21 17:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-20 5:01 bug#39687: 26.3; Add customize-variable option for not locking keyboards Logan Perkins
2020-02-21 8:23 ` Eli Zaretskii
[not found] ` <32ea14fb-1ab8-186e-2534-4d3d2a56d6d8@lp-programming.com>
2020-02-22 9:27 ` Eli Zaretskii
2020-02-22 18:00 ` Logan Perkins
2020-05-19 1:15 ` Logan Perkins
2020-10-01 18:44 ` Lars Ingebrigtsen
2020-10-01 19:23 ` Eli Zaretskii
2021-07-21 15:57 ` Lars Ingebrigtsen
2021-07-21 17:52 ` Logan Perkins [this message]
2021-07-21 19:52 ` Eli Zaretskii
2021-07-21 22:08 ` Lars Ingebrigtsen
2021-07-21 22:44 ` Logan Perkins
2021-07-22 12:05 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87eebr3671.wl-logan@lp-programming.com \
--to=logan@lp-programming.com \
--cc=39687@debbugs.gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).