From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Heerdegen Newsgroups: gmane.emacs.bugs Subject: bug#50136: 28.0.50; A problem with rx-let expansion Date: Mon, 23 Aug 2021 18:59:11 +0200 Message-ID: <87eeak85cw.fsf@web.de> References: <878s0wcj3j.fsf@web.de> <87y28whw1b.fsf@web.de> <878s0vc97a.fsf@web.de> <3541B092-BD63-4610-BDA8-A43ABD4FAF6D@acm.org> <87a6l84ey2.fsf@web.de> <9CAC5CC8-CFC7-4B9A-952D-6E5BD43D0D80@acm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4722"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 50136@debbugs.gnu.org, monnier@iro.umontreal.ca To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Aug 23 19:00:42 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mIDJR-0000yG-D0 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 23 Aug 2021 19:00:41 +0200 Original-Received: from localhost ([::1]:49464 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mIDJQ-0001cY-7t for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 23 Aug 2021 13:00:40 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52668) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mIDIo-0001Zm-P3 for bug-gnu-emacs@gnu.org; Mon, 23 Aug 2021 13:00:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59234) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mIDIo-0001Y7-FA for bug-gnu-emacs@gnu.org; Mon, 23 Aug 2021 13:00:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mIDIo-0003SM-5Y for bug-gnu-emacs@gnu.org; Mon, 23 Aug 2021 13:00:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Heerdegen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 23 Aug 2021 17:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50136 X-GNU-PR-Package: emacs X-Debbugs-Original-Cc: bug-gnu-emacs@gnu.org, Stefan Monnier Original-Received: via spool by submit@debbugs.gnu.org id=B.162973797613231 (code B ref -1); Mon, 23 Aug 2021 17:00:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 23 Aug 2021 16:59:36 +0000 Original-Received: from localhost ([127.0.0.1]:42547 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mIDIO-0003RK-4p for submit@debbugs.gnu.org; Mon, 23 Aug 2021 12:59:36 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:51696) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mIDIL-0003RB-A6 for submit@debbugs.gnu.org; Mon, 23 Aug 2021 12:59:34 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52596) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mIDIJ-0000o6-CS for bug-gnu-emacs@gnu.org; Mon, 23 Aug 2021 12:59:33 -0400 Original-Received: from mout.web.de ([212.227.17.11]:41999) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mIDIF-00019Z-F3 for bug-gnu-emacs@gnu.org; Mon, 23 Aug 2021 12:59:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1629737953; bh=UA1ZeNNdSmIRuOIAvq9tBVKOJfUXKIKh1U1FntkJBrY=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=Er4xsn/+cAEE6/PZYSedXJFWUG9x1yHLltp2H/pl2sJG6Gx19XQiQxL55ReY5zLnW 6jKP87AOLOXniK+R+Trd5aqDd8BcuOpDL9yEptsqCLHk4JRnoxmydtyet/lZdpZYpk EbsqcpwZi3XTLjxzwkO9fUP5HK8KUUzE52NV6WYA= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Original-Received: from drachen.dragon ([88.66.201.45]) by smtp.web.de (mrweb103 [213.165.67.124]) with ESMTPSA (Nemesis) id 0LnS8Q-1myPs63c0U-00hgWx; Mon, 23 Aug 2021 18:59:12 +0200 In-Reply-To: <9CAC5CC8-CFC7-4B9A-952D-6E5BD43D0D80@acm.org> ("Mattias =?UTF-8?Q?Engdeg=C3=A5rd?="'s message of "Mon, 23 Aug 2021 17:20:42 +0200") X-Provags-ID: V03:K1:SCu0ZujnN8B3PX6OkHnIswmiGzEQR7PjR00jq6v5cUS2r+a56eG eIvonTXJO3fu39MteX7wEl7wABd2+biu2/UMnYWCoXiqsJCuWHKiRVtb9QrWFhh0aDFfdJB 6oPHHtAX0Ukc9YNqQ1oZ4jVppLfhtCTO/vGZzrOKCahyDrhOiuhLL54ev2AO/agHcs6SBMJ tyYjpluPgwv0xXBvEfohg== X-UI-Out-Filterresults: notjunk:1;V03:K0:n9Drpd9gcgI=:TeS5Pvu2a+axHnzrNtnAVt hJPo4TN7QmpDjmlY7mNMQCT6A0tpkziwgdiov3uHE2wTjLCZTatR2Xxl2d4HH3QisHFVxStIu autIcdQzgxiVzgDBsgqVNdXekD2HRDH+LyypvkG5hwb8tTQRs3DNph981oEf7lB14m2TGzK++ irdOPzGTJqZDZ2Om+XhGD3bm6Q/ipc870knBNv0adLIsfKTLWF6du9jSl7zy5Jhjz8oKk2hsI bbunwymlwmbfdTjMZOtt7x+KeLL8Y8vZD/ZqltGuJeYBiuRZBSb8/eoFFRkzzGF5QVN4VFfem Firfyw/uXnqhGclKFNAmj2a4Y1nRjSWhSoaPptN/WPFms9FAZ1YIIH/CTG2I/ZokWiAhKHPHi Ys7I6QpuO/tren3N482dafTTtc3vDbKegIbmjlcFZuwso7+rAH/suCWqNjKOaX7AbbruG3OkA 3jzI/kxbarc2wizExbGwfhCwTp1APfPTwd98uyH6d6k6eyVG40eHy92epvP2kQh9k62604QD7 OGEBz/L/JYn0CpFh7gB2+VNcFmLhsADJZ5enRI6KZugMyR9CH1EsicMzN1PTSGX4+YYjbs9ya ALIM0ctSOj2VuWDvu0AstVqzygsK/9x72GQmDefVmZS44IBXj2WYP1ijsHqsCMSfc0cGo4GF0 oY7SX9b78hy68jmZgxeFyoI1yk8de9N5n1vEb7o6ONSKOW5Q36UPKC+PXd+OgpHPotnO7KKL8 JnjrueAgPLxuaOm27WOFt0LnPoxEW8el7LnmA4SbKwDxvGbxaoSC21MMg1xPMmxhoRCB67r1 Received-SPF: pass client-ip=212.227.17.11; envelope-from=michael_heerdegen@web.de; helo=mout.web.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:212507 Archived-At: Mattias Engdeg=C3=A5rd writes: > Here is my proposed change to the manual. I didn't change the doc > strings since they already refer to that Info node. Maybe at least one sentence about that this mechanism just performs trivial substitution? > +User-defined forms themselves only perform simple template > +substitution. I find the term "user-defined" distracting, because anybody (including library and package developers) is "affected". Apart from that, ok for me. > For arbitrary computations, use them together with with > +the @code{rx} forms @code{eval}, @code{regexp} or @code{literal}. > +Example: > + > +@example > +@group > +(defun n-tuple-rx (n element) > + `(seq "<" > + (group-n 1 ,element) > + ,@@(mapcar (lambda (i) `(seq ?, (group-n ,i ,element))) > + (number-sequence 2 n)) > + ">")) > +(rx-define n-tuple (n element) (eval (n-tuple-rx n 'element))) > +(rx (n-tuple 3 (+ (in "0-9")))) > + @result{} "<\\(?1:[0-9]+\\),\\(?2:[0-9]+\\),\\(?3:[0-9]+\\)>" > +@end group > +@end example > @end defmac Didn't try the example, but it looks good. I have one more thing, however, once we are here: In the docstring of `rx', near the end: | (eval EXPR) Match the rx sexp from evaluating EXPR at compile time. can we say "expansion time" instead of "compile time"? Regards, Michael.