From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#50798: 28.0.50; Tab line close button is off-center until it is highlighted with the mouse Date: Sat, 02 Oct 2021 22:36:15 +0300 Organization: LINKOV.NET Message-ID: <87ee93fbw8.fsf@mail.linkov.net> References: <8735ptxhzs.fsf.ref@yahoo.com> <8735ptxhzs.fsf@yahoo.com> <87wnn5m8eo.fsf@gnus.org> <83wnn5qe48.fsf@gnu.org> <87k0j5m5ik.fsf@gnus.org> <83tui9qd2j.fsf@gnu.org> <87fsttm512.fsf@gnus.org> <87y27kbi6y.fsf@mail.linkov.net> <83a6k0phik.fsf@gnu.org> <878rzi11xq.fsf@mail.linkov.net> <83lf3hlv5o.fsf@gnu.org> <87czoso8cz.fsf@mail.linkov.net> <834k9zd9i3.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28411"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) Cc: luangruo@yahoo.com, larsi@gnus.org, 50798@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Oct 02 21:48:09 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mWkzR-0007EO-Js for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 02 Oct 2021 21:48:09 +0200 Original-Received: from localhost ([::1]:36558 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mWkzQ-0008Ts-4Q for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 02 Oct 2021 15:48:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58330) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mWkzK-0008Tk-Si for bug-gnu-emacs@gnu.org; Sat, 02 Oct 2021 15:48:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:49074) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mWkzK-0004Qm-L6 for bug-gnu-emacs@gnu.org; Sat, 02 Oct 2021 15:48:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mWkzK-0000nz-Fn for bug-gnu-emacs@gnu.org; Sat, 02 Oct 2021 15:48:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 02 Oct 2021 19:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 50798 X-GNU-PR-Package: emacs Original-Received: via spool by 50798-submit@debbugs.gnu.org id=B50798.16332040733080 (code B ref 50798); Sat, 02 Oct 2021 19:48:02 +0000 Original-Received: (at 50798) by debbugs.gnu.org; 2 Oct 2021 19:47:53 +0000 Original-Received: from localhost ([127.0.0.1]:60620 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mWkzA-0000nc-L2 for submit@debbugs.gnu.org; Sat, 02 Oct 2021 15:47:52 -0400 Original-Received: from relay4-d.mail.gandi.net ([217.70.183.196]:55639) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mWkz9-0000nO-9L for 50798@debbugs.gnu.org; Sat, 02 Oct 2021 15:47:51 -0400 Original-Received: (Authenticated sender: juri@linkov.net) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 5A910E0004; Sat, 2 Oct 2021 19:47:42 +0000 (UTC) In-Reply-To: <834k9zd9i3.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 02 Oct 2021 13:08:36 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:216200 Archived-At: > Please tell more about what you saw there. Which X coordinates are > miscalculated? > > And I don't think I understand the arrangement with faces for the > close button. tab-line.el says: > > (defvar tab-line-close-button > (propertize " x" > 'display '(image :type xpm > :file "tabs/close.xpm" > :margin (2 . 0) > :ascent center) > 'keymap tab-line-tab-close-map > 'mouse-face 'tab-line-close-highlight > 'help-echo "Click to close tab") > "Button for closing the clicked tab.") > > which seems to mean we should use 'tab-line-close-highlight' as the > mouse-face for this button. But if I invoke (tab-line-format), which > seems to be what calculates the tab-line-format, I see this: > > (#(" xdisp.c x" > 1 8 > (tab # > face tab-line-tab-inactive > mouse-face tab-line-highlight > follow-link ignore) > 8 10 > (tab # > face tab-line-tab-inactive > display (image :type xpm :file "tabs/close.xpm" :margin (2 . 0) :ascent center) > mouse-face tab-line-highlight ... > > which seems to say we actually use the 'tab-line-highlight' face > instead for the close button? > > Could you please describe how mouse-highlight faces are supposed to > work with tab-line close buttons, and preferably walk me through the > relevant code? 'tab-line-close-highlight' was supposed to be applied to the close button to emulate how the close button behaves on the tab bar where hovering mouse over the button displays it with the face style 'released-button'. But mouse-face of the face 'tab-line-highlight' overrides the mouse-face 'tab-line-close-highlight' in 'tab-line-tab-name-format-default' that applies 'propertize' with 'mouse-face tab-line-highlight'. And I can't find a way how to keep the existing 'mouse-face' property on the close button while applying 'mouse-face tab-line-highlight' to the rest of the tab.