From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#51674: 29.0.50; [PATCH] Fix hang when displaying xwidget script dialog Date: Mon, 08 Nov 2021 14:56:43 +0800 Message-ID: <87ee7rp238.fsf@yahoo.com> References: <87fss7s8gr.fsf.ref@yahoo.com> <87fss7s8gr.fsf@yahoo.com> <87a6ifb4o6.fsf@gnus.org> <87mtmfqk9e.fsf@yahoo.com> <87mtmf9pcy.fsf@gnus.org> <87a6ifqjz3.fsf@yahoo.com> <87ilx39na0.fsf@gnus.org> <87r1brp3c0.fsf@yahoo.com> <87y25z87jl.fsf@gnus.org> Reply-To: Po Lu Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26917"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: 51674@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Nov 08 07:57:31 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mjyaw-0006om-NB for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 08 Nov 2021 07:57:30 +0100 Original-Received: from localhost ([::1]:47726 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mjyav-0002ke-K3 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 08 Nov 2021 01:57:29 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:51046) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mjyaU-0002k8-7J for bug-gnu-emacs@gnu.org; Mon, 08 Nov 2021 01:57:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:44315) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mjyaT-0005Ii-Uy for bug-gnu-emacs@gnu.org; Mon, 08 Nov 2021 01:57:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mjyaT-0000G9-TC for bug-gnu-emacs@gnu.org; Mon, 08 Nov 2021 01:57:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Po Lu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 08 Nov 2021 06:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51674 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 51674-submit@debbugs.gnu.org id=B51674.1636354620990 (code B ref 51674); Mon, 08 Nov 2021 06:57:01 +0000 Original-Received: (at 51674) by debbugs.gnu.org; 8 Nov 2021 06:57:00 +0000 Original-Received: from localhost ([127.0.0.1]:55861 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mjyaS-0000Fu-JK for submit@debbugs.gnu.org; Mon, 08 Nov 2021 01:57:00 -0500 Original-Received: from sonic309-22.consmr.mail.ne1.yahoo.com ([66.163.184.148]:40937) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mjyaQ-0000Ff-1U for 51674@debbugs.gnu.org; Mon, 08 Nov 2021 01:56:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1636354611; bh=pkdN6Il2+CK5e5OMch+M5Qt5rZ+uqFu4danZMUlBBu0=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=BELkDW8oXtI/GMNCzCJEQnP8QwnrrglMIkQjVkx7Frm7ok8GtYMLc9TSoCFqw0lFMfgVYHjeAdwQJrUw3AlkcynxTxxNaCrJuW8RUTDy3h3vxEiQ8iTjY6rayAIwLfCSWSdzkDnBJDf+WVGBzg87qUuDeP40d0Do7az6FlbQuu9En3Wfzb02Mmmzg10oYDyFIKZxFN6o/4RADLo8aMl4YtHNdPU6cjIVE8KcUxQ+KJBfIFQSAvPjEydKpkzgKnpohZclJ8jlNFoKCyxZPhzFDTkS4GlNnAL7+F3DP4qqwCUqFtzMLW7yQGfke1eQ5pDeUv0iQWIvAeBEWudwDoAL/A== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1636354611; bh=yAC9ttqB6B7gyQBBBHAg8PIp3Gv6339BEw6t+nTR6wB=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=CP73mMg+FWG+WSsmWT1676vi7pV4fZ8p99ESwtoO5Y+jVwQ0s++5E9OIltvfC+uWSJUrmKnWV7VcLuEh1kcSHMJDbFUblmB+X7/FEfYZMLDr+++Ry6QrzBefUqhNZZ5m2s0GqdqXDEIGBGmYlOb0GjsdiscecwCOe4tntYQLsZmE80BFxS8clh3CIxQmYZNbw2aGQQxNPAlJZhLhIHbZ45oepnZi3VbM8l8lj7cDXJRHS9LaqdAlEbHuOgkfr4uraSIwdDaT/lY89ebdwQKE8Q62vIomzCQXt8PI61qonwb60h1uxdJXGXrzaXs+P2YjPQihUYQaB1LvzIGDSRTeyw== X-YMail-OSG: 0PMmwtYVM1nHnLRdq9ROR2zjGmFQL4l5kbrSFG3zxQ0glg6Bu8halykbzH58ddk IYvuR0G5tE9LJixaOMoDzBGb77agZ74CBQrqV3Phyi9iJYXUTNWldIBNmjCdeVXAqyb6vr1bDo_x INzlDny1PFAUNdBFlvfcNRBkh2XixOZSm9R93.dUYMvy.m0JmZ21I7QdRWqwyMxz6rWI0eFJJwwT yepyjtHQzM6U.9Zby2PloMyoGwo9l6p8He0bLEopfkUC01YD6MxjQnLDMnyUsr7uIUBcqTdXGMws ilRFmJ7Ek7h3igiraan9h860yyu43LaKjpB1uevjYQn70Oaft1ud44ZppOh3AAu8ebSUrKdW6otO iD_yDV82EmWkNnGk_BkQBb6YwLxl3EsW.sNt_A5YfMqILFLiIO8vvs4rsWAf7nx6jniXJd0d1_W. cq.msVli37Suaq_Tb26K.OnXiU6fbTJSljHCt8uUc8g5FGxMzUC8DawaMt97t4zcoLSbaKrfHlP0 JAUObNev642DoRHjmcpaI8yF70L1pO_ETsub5owxfrbsrsyBhn2lRyTFV3MSxcQUJ4NhLj2EwHn4 CjfHuAoZvCVaD9_FKiSC4C6__41xoczV4k8vsXMZ.pDgI45fgW1Q3.Uu3vaZpC4wGqjtP8MMblal w7nHcOTvjuViJ6O29im4Y3wN2d8e4j7pEASLeKuuHS.YuDW8bI1Z8MirSxYiePIO7iHKzyBEHfW2 qTrDJfrc5sSpA2TMajhSSyLq2gqGHOYHueU.GgK2F5JgyHEi54UKVz_p.F1UNa.JFnuUzElGkppa nvj3vwSvLim6UxJjf0f2pYKsjNufdtyEBeb1TB38c9 X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic309.consmr.mail.ne1.yahoo.com with HTTP; Mon, 8 Nov 2021 06:56:51 +0000 Original-Received: by kubenode504.mail-prod1.omega.sg3.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 4bf2c47b5edd11676e72db8be5933d24; Mon, 08 Nov 2021 06:56:46 +0000 (UTC) In-Reply-To: <87y25z87jl.fsf@gnus.org> (Lars Ingebrigtsen's message of "Mon, 08 Nov 2021 07:50:54 +0100") X-Mailer: WebService/1.1.19266 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:219333 Archived-At: Lars Ingebrigtsen writes: >> That's weird, because video works here. Does it work in another >> WebKitGTK based browser, like Epiphany, on your Debian system? Thanks. > I tried Epiphany now, and it works there. That is, it plays the mp4 > very slowly, but it does play it. In the xwidget, it just puts up the > controls, and then nothing happens. (This happens with `M-x > xwidget-webkit-browse-url', too, so it's not just this way of creating > the xwidgets that's stopping the mp4s from working.) Can you test the xwidget support using self-built WebKitGTK with `-DENABLE_GL=NO' added to your cmake options? You can follow the instructions here: https://trac.webkit.org/wiki/BuildingGtk. Afterwards, you can add the path to the library into your LD_LIBRARY_PATH, and start Emacs that way. Thanks a lot! > I'm not that familiar with the xwidget.c code... but that's just always > maximalising the widget to be as big as the Emacs window? That can't be > correct, surely. Should I just remove it? It doesn't seem to lead to > any regressions in xwidget-webkit-browse-url, either. Yes, you should remove it. I suspect that code was originally added to work around the resizing bug I fixed in bug#51679. Thanks.