From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#52523: 29.0.50; defcustom :type 'key-sequence not following key-valid-p format Date: Mon, 27 Dec 2021 13:05:11 +0100 Message-ID: <87ee5ycky0.fsf@gnus.org> References: <865yroa7l7.fsf@mail.linkov.net> <87fsqou6xl.fsf@gnus.org> <86a6gwk6t2.fsf@mail.linkov.net> <86tuf3ptcr.fsf@mail.linkov.net> <87fsqno9km.fsf@gnus.org> <86ilvi9c8b.fsf@mail.linkov.net> <87pmpoerrm.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35657"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 52523@debbugs.gnu.org, Juri Linkov To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Dec 27 13:06:12 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n1olX-00090z-VN for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 27 Dec 2021 13:06:11 +0100 Original-Received: from localhost ([::1]:48502 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n1olW-0004Ou-4e for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 27 Dec 2021 07:06:10 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:34096) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n1olO-0004LF-6v for bug-gnu-emacs@gnu.org; Mon, 27 Dec 2021 07:06:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58983) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n1olN-0007js-OX for bug-gnu-emacs@gnu.org; Mon, 27 Dec 2021 07:06:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n1olN-00020K-KU for bug-gnu-emacs@gnu.org; Mon, 27 Dec 2021 07:06:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 27 Dec 2021 12:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52523 X-GNU-PR-Package: emacs Original-Received: via spool by 52523-submit@debbugs.gnu.org id=B52523.16406067257650 (code B ref 52523); Mon, 27 Dec 2021 12:06:01 +0000 Original-Received: (at 52523) by debbugs.gnu.org; 27 Dec 2021 12:05:25 +0000 Original-Received: from localhost ([127.0.0.1]:42296 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n1okn-0001zK-2L for submit@debbugs.gnu.org; Mon, 27 Dec 2021 07:05:25 -0500 Original-Received: from quimby.gnus.org ([95.216.78.240]:41012) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n1okj-0001z1-6S for 52523@debbugs.gnu.org; Mon, 27 Dec 2021 07:05:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=llQAptRWfNmOwvmUHKmWwUEUyKRE8ebGv4n3ieDY6oI=; b=ob4fUNiqk5yC0WFY+IdcLBd8Vm ExeWd2tSDfX+VxCGVpoybbyYQXBSSv9qILOe8LA3MZBvHzZA5oP7zcx5CWIPvyJhgFGfmEjR1uquZ M8fZoM6f4eVxyoWWmqovDKG4k/PcYXIplT6haIgOMIqf/LdO/l1cWham3cZIsXFoin6o=; Original-Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n1oka-0005Ia-Eu; Mon, 27 Dec 2021 13:05:15 +0100 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAD1BMVEWWa1iulI2jbF2W WTz///9An9F3AAAAAWJLR0QEj2jZUQAAAAd0SU1FB+UMGws3CrQyu8UAAAG2SURBVDjLZZQBssIw CESrJzD0ArJcwIb73+3vQlrr/I7TVp5hF0LcHmOMyKkbL2CM11bXGM4YvOL5wHAD3ngTDMuJUXGu NFcEEEB6RZ+ZH4UZabDnzvAnD6YrYHgWiAmG+Ngv8O5UNitBgukatPiIo8CeQZFHgUFglg1s+ToB BdqLaqRxXq8Cp5cG1u/2A6BMq5IGY4FYarwIMuaZqbp5B2rq2I+I1l5AX1mJJVNd8bbL9fBdXn+A hZro9h8gTQD6/IARfHFWZt8FAsOjavXq0R1wjVaAavNKtq2nWjpxk29g3CrD2Vy/gaAlDxYISuEG kGADxGOZXsBDAgIanTswdpa3qTmscpYrmMaUGzX22UtOoI9pO4Bf4D0ldD3LWbdEw9qzgAJKcNqV pM6HxG8ArKML54P9WsDMq0uhmxopydIwGcpKVb61BRtLda+RqsnVOmjHBKJsxQ3wx5vqGb0ZleoC 7c8qMuWqBpZnkEDnhl3PBY4vmDVcWbMaJ0BPokQisIA14DkvEUlT4tj1tsmChp8xKcCOOr/YTCLp F+jzK4Cqmo2rfunU1QRsNYBVmrA2mH8ROeMPKf2ChUdv/oIAAAAldEVYdGRhdGU6Y3JlYXRlADIw MjEtMTItMjdUMTE6NTU6MTArMDA6MDA47whcAAAAJXRFWHRkYXRlOm1vZGlmeQAyMDIxLTEyLTI3 VDExOjU1OjEwKzAwOjAwSbKw4AAAAABJRU5ErkJggg== X-Now-Playing: Jane Siberry's _Love Is Everything (2)_: "Are You Burning, Little Candle?" In-Reply-To: (Stefan Kangas's message of "Sun, 26 Dec 2021 08:39:54 -0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:223185 Archived-At: Stefan Kangas writes: > I started looking into this but noticed that the docstring for > `key-valid-p' says: > > Say whether KEYS is a valid =E2=80=98kbd=E2=80=99 sequence. > A =E2=80=98kbd=E2=80=99 sequence is a string consisting of one and mo= re key > strokes. The key strokes are separated by a space character. > > I guess that docstring should be updated if we don't want to settle for > the terminology "`kbd' sequence". Yes, I forgot to update the doc string when I redid this. > However, if we do that the problem is that we then risk having two > definitions of "key sequence": both the old and the new style. > > See also (info "(elisp) Key Sequences"), that uses the old style. Yes, that's confusing. I meant to have the `key-valid-p' say what it accepts as a valid key binding, and then the other functions refer to it. > Relatedly, the `define-keymap' docstring currently says: > > Create a new keymap and define KEY/DEFINITION pairs as key sequences. > > Should that say "key bindings" instead of "key sequences"? Otherwise, > it doesn't seem clear what it does. Yes, it should. > `keymap-set' says: > > Set key sequence KEY to DEFINITION in KEYMAP. > > So here is again the "new" style used as the definition of a key > sequence, which seems to contradict the Elisp manual. Yes. Please go ahead and fix up the doc strings. =F0=9F=98=80 --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no