bug#52951: Including Swedish calendar localization (sv-kalender.el) in Emacs

bug#52951: Including Swedish calendar localization (sv-kalender.el) in Emacs

[Stefan Kangas]

Severity: wishlist

We have talked about adding the library sv-kalender.el to Emacs itself:

    https://lists.gnu.org/archive/html/emacs-devel/2021-07/msg00030.html

I am opening this bug to track this work.  The main question that
remains is whether or not we have the necessary copyright assignments.

Daniel, if I understand correctly, you have already assigned copyright
to the FSF for Emacs contributions.  Are you okay with including
sv-kalender.el in Emacs itself?  Could you please also confirm that you
have written that file yourself?

The current plan would be to include sv-kalender.el as a "core" package
in the main Emacs repository.  This means that it will be maintained in
emacs.git, but we will have the option to release new versions of the
package on GNU ELPA.

Thanks in advance.

[Please use "Reply to all" to make sure any followups land in the bug
 tracker.]

bug#52951: Including Swedish calendar localization (sv-kalender.el) in Emacs

[Daniel Jensen]

On 2022-01-02 at 09:41, Stefan Kangas wrote:

> Severity: wishlist
>
> We have talked about adding the library sv-kalender.el to Emacs itself:
>
>     https://lists.gnu.org/archive/html/emacs-devel/2021-07/msg00030.html
>
> I am opening this bug to track this work.  The main question that
> remains is whether or not we have the necessary copyright assignments.
>
> Daniel, if I understand correctly, you have already assigned copyright
> to the FSF for Emacs contributions.  Are you okay with including
> sv-kalender.el in Emacs itself?  Could you please also confirm that you
> have written that file yourself?

I have assigned copyright to the FSF, yes. I wrote sv-kalender.el. Some
of it was adapted from holiday code in Emacs at the time, but it was a
long time ago and I don't recall any specifics -- it is not a copyright
problem anyway. I don't mind at all having it included in Emacs.

> The current plan would be to include sv-kalender.el as a "core" package
> in the main Emacs repository.  This means that it will be maintained in
> emacs.git, but we will have the option to release new versions of the
> package on GNU ELPA.

I'm glad you want to include it in Emacs. I'm sure some improvement is
needed to have it match Emacs standards. Unfortunately I don't have the
time to work on this project right now, but I wish you luck. Thank you!

bug#52951: Including Swedish calendar localization (sv-kalender.el) in Emacs

[Stefan Kangas]

Daniel Jensen <daniel@bigwalter.net> writes:

> I have assigned copyright to the FSF, yes. I wrote sv-kalender.el. Some
> of it was adapted from holiday code in Emacs at the time, but it was a
> long time ago and I don't recall any specifics -- it is not a copyright
> problem anyway. I don't mind at all having it included in Emacs.

Thanks for confirming this.  I have used this library for a very long
time, so I'm happy to see it getting mainlined.

> I'm glad you want to include it in Emacs. I'm sure some improvement is
> needed to have it match Emacs standards. Unfortunately I don't have the
> time to work on this project right now, but I wish you luck. Thank you!

I will mark myself as the maintainer if no one else is interested.  The
documentation will need to be translated to English (to the extent
possible), but maybe there are other things to clean up as well.

I will base this on the latest version at this URL:

    http://bigwalter.net/daniel/elisp/sv-kalender.el

It seems to incorporate some fixes from Arthur Miller.

bug#52951: Including Swedish calendar localization (sv-kalender.el) in Emacs

[Mattias Engdegård]

> http://bigwalter.net/daniel/elisp/sv-kalender.el

Thank you!

> (setq calendar-time-display-form
>       '(24-hours ":" minutes))

Standard Swedish style uses a dot as separator; the colon appears to have crept in as a fairly recent Anglicism (and I think it looks a bit tacky).

The file should also use lexical-binding: t.

> (eval-after-load "solar"

We should probably use `with-eval-after-load`.

>            (eval calendar-location-name)

Would `symbol-value` do instead of `eval` here?

>         '((if (fboundp 'atan)

I think we can assume the presence of `atan`.

>               (funcall 'holiday-sexp calendar-daylight-savings-starts

>           (funcall 'holiday-sexp calendar-daylight-savings-ends

Why the explicit `funcall`s? Is this a holiday code subtlety?

By the way, is there a way to do without the defadvice? They tend to be brittle.

bug#52951: Including Swedish calendar localization (sv-kalender.el) in Emacs

[Stefan Kangas]

Mattias Engdegård <mattiase@acm.org> writes:

>> (setq calendar-time-display-form
>>       '(24-hours ":" minutes))
>
> Standard Swedish style uses a dot as separator; the colon appears to
> have crept in as a fairly recent Anglicism (and I think it looks a bit
> tacky).

According to the authoritative Swedish writing guide Svenska
skrivregler:

    "11.6.3 Klockslag och tidsrymder

    Klockslag och tidsrymder som uttrycks i siffror skrivs enligt
    24-timmarsklockan. Som skiljetecken mellan timsiffror, minutsiffror
    och sekundsiffror kan punkt eller kolon användas. Punkt är den
    traditionella svenska konventionen, medan kolon är internationell
    standard."

    Svenska skrivregler, Språkrådet, Liber 2008, s. 162.

So using either is accepted, and it is only a matter of preference if
you use the traditional or the international style.

IMHO, at least for our purposes in Emacs, it is better to use the
international standard in this case.