From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Thierry Volpiatto Newsgroups: gmane.emacs.bugs Subject: bug#53229: 29.0.50; Image-dired is not reusing thumbnails created in emacs-27 Date: Thu, 13 Jan 2022 19:53:23 +0000 Message-ID: <87ee5bjth5.fsf@posteo.net> References: <87zgnzsqc2.fsf@posteo.net> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33363"; mail-complaints-to="usenet@ciao.gmane.io" To: 53229@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jan 13 21:19:45 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n86ZV-0008WO-Gb for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 13 Jan 2022 21:19:45 +0100 Original-Received: from localhost ([::1]:60694 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n86ZU-0002Z9-6N for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 13 Jan 2022 15:19:44 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:41632) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n86IN-0004zt-5n for bug-gnu-emacs@gnu.org; Thu, 13 Jan 2022 15:02:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:41761) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n86IM-0001Ie-I6 for bug-gnu-emacs@gnu.org; Thu, 13 Jan 2022 15:02:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n86IM-00077x-Dz for bug-gnu-emacs@gnu.org; Thu, 13 Jan 2022 15:02:02 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: <87zgnzsqc2.fsf@posteo.net> Resent-From: Thierry Volpiatto Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 13 Jan 2022 20:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 53229 X-GNU-PR-Package: emacs Original-Received: via spool by 53229-submit@debbugs.gnu.org id=B53229.164210409027346 (code B ref 53229); Thu, 13 Jan 2022 20:02:02 +0000 Original-Received: (at 53229) by debbugs.gnu.org; 13 Jan 2022 20:01:30 +0000 Original-Received: from localhost ([127.0.0.1]:34664 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n86Hm-00076x-Mq for submit@debbugs.gnu.org; Thu, 13 Jan 2022 15:01:30 -0500 Original-Received: from mout01.posteo.de ([185.67.36.65]:52779) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n86Hh-00076c-LW for 53229@debbugs.gnu.org; Thu, 13 Jan 2022 15:01:25 -0500 Original-Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id 3BEEF240028 for <53229@debbugs.gnu.org>; Thu, 13 Jan 2022 21:01:14 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1642104075; bh=xjGlXHP5XggZympLUfHg02Ocyua/DJbvhWULsjxVgMc=; h=From:To:Subject:Date:Autocrypt:From; b=ODGgGIVPkYU7oARQA0OuT1U1Pl2hceRYLWrb4a5pIHdTOz5UdNOn7kHO5dc2ntCEw cRhWu0DYBtXFyBJ3EXeAFgA6cRuDHJ8k2is0oyaYos2aiBZW4m98jqjReEzbhwfZpb dTuWjH6f7B6huRUT4K1RaYjXHAIfX4K5o2Oawt5yCYU9wxAyqPcdzkksO7L8CIwzPg h5I37k+Uir6c8z30UgtuzJy01qCHrIl1angbMoFAm4uXPI65byPc3tEFck82BbBoHG +mbKn7y1ZwrbZRdlclogBFUAobmsRCHc986EsUd3F6vdDqCrSi8PYBI7KILb3mCj5y /Gb4zsXwJLQkw== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4JZb0T5PCxz6tmf for <53229@debbugs.gnu.org>; Thu, 13 Jan 2022 21:01:13 +0100 (CET) Autocrypt: addr=thievol@posteo.net; prefer-encrypt=mutual; keydata= mQGNBF8ylcIBDADG+hy+zR6L4/vbdDDZuSaMmSrU3A5QZJpeBCvxTr7MpzzruZbhLPW1K3R6N2MA edi8Y+C8o27FVRIjpdbaKMGu9je7JV/TbUQYo3SOwCK1vM4LUn4V6ZLzSYkuiEt4eyMoiDdyvN0p kcK6P9x9DCetcEVszXzQg+yzCVrQ2hXWDXWT4M18EC3wtO7RHPouMqGiwBFhBAYErCqFWFxQHkfb tG/4yGyJ58rglb65O3qijjMWvYwcWZun9/7qm8Z4/4mHopmo2zgU+OrptnLSZfkZGz3Y7Uf452xQ GVq0Fv75NPvQru7y+DYVhuVXXyAmGxt+vf4rIiixMBbhKEPjcxEPAa2LTzex2IsTZR+QVG9uDnqC WcgaOEQ58fzXNvNhtwwF/Rgio2XWAJVdmFWS59/k9W58CIUSNKBMZh2XeGdEmtHvDtCxW3z6FJha 36RzOM3fMNNiAGdFZJA84gcdloJR+sHCDTTPT3784fjr+V8An7sI581NGFzkRQqPvEQCZbUAEQEA AbQSdGhpZXZvbEBwb3N0ZW8ubmV0iQHUBBMBCgA+FiEEI9twfRN7r3nig/xwDsVtFB0W75MFAl8y lcICGwMFCQPCZwAFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQDsVtFB0W75MB3QwAlTsVzFmr +S/tMKwwwOibjhNPi/OZiUC2AYfaqfVAiIHDT3RbzDe03sAJoomJkJnYVjGzQZwibCMO2+ITkMPV 2wvrd4CbgS1KCVbrltwcuK/nxPCBaHytOCZUIInnhJo5PE/h03K X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:224132 Archived-At: --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable After further searching, I discover image-dired is using sha1 to build thumbnail filenames whereas in emacs-27 it uses md5, so the names are differents and a new file is created. I must use a different function to avoid duplicating all thumbnails, using something like this: (cl-letf (((symbol-function 'sha1) #'md5)) (image-dired-thumb-name file)) And while I was at it I used a cache to avoid calling md5 each time I toggle or revisit an image directory with thumbnails, probably dired should do the same as well, but it is a different issue. =2D-=20 Thierry --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQHHBAEBCgAxFiEEI9twfRN7r3nig/xwDsVtFB0W75MFAmHghQYTHHRoaWV2b2xA cG9zdGVvLm5ldAAKCRAOxW0UHRbvkwRaC/9xtcwLvvSR9izm34hFLAGmZkfcji7j sSld/Y9FGRkYNh4UAl4qJ78/kLBUznSf02lTbWqiIm8pxInfUueQ8CgcxXlCGJzR 9yzGVzSSV7t+iOn9UHN8Lvi6lpYVfyewzcFylA/8wVq5DNo4QXjcuy6+oFXS3MZe +1c2wSNpKmwNRzXV5TOfnJzmvheO63z9r4msRT9bX9NokxypSbVDjdeIZEDiQ0Nl 3JHgBizbVL2BBMWKhhaumpbCKrtT07OBMWUO1yADeaijklWZ9K08JzW822ve8Yx5 WrPhSw6D0xQG+Ao3JypQzPZugr8M7Dk2eceDUKPWVccnfAIpbRN0ecfDQH5oBbbd WmLtOeE9jWfA5kCsUTE66/IRGZHiYkD7WrTvus/Qkf61dSk6PUHJ90hTO3yIulSK LKvTTtDnRrH8fXogBN7a9z5sxOPAxtPkNYAYBd9vlLpWx7oci9xRiebgCI/X9dSL Z+9JbZzve5lg8gXBGCKYFBlf8Opj6kk034s= =VTae -----END PGP SIGNATURE----- --=-=-=--