From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Matthias Meulien Newsgroups: gmane.emacs.bugs Subject: bug#54034: 29.0.50; Diff prettify broken for empty files Date: Tue, 22 Feb 2022 07:58:29 +0100 Message-ID: <87ee3v9ylm.fsf@gmail.com> References: <87iltex7bo.fsf@gmail.com> <87v8xakm0i.fsf@gmail.com> <87bkz1jxd9.fsf@gmail.com> <87sfsbakqo.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26440"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 54034@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Feb 22 07:59:11 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nMP8h-0006ij-5Q for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 22 Feb 2022 07:59:11 +0100 Original-Received: from localhost ([::1]:49938 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nMP8g-0001kb-1q for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 22 Feb 2022 01:59:10 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:45016) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nMP8Y-0001kK-Ox for bug-gnu-emacs@gnu.org; Tue, 22 Feb 2022 01:59:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:45963) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nMP8Y-0007ev-Fm for bug-gnu-emacs@gnu.org; Tue, 22 Feb 2022 01:59:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nMP8Y-0007Co-AQ for bug-gnu-emacs@gnu.org; Tue, 22 Feb 2022 01:59:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Matthias Meulien Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 22 Feb 2022 06:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54034 X-GNU-PR-Package: emacs Original-Received: via spool by 54034-submit@debbugs.gnu.org id=B54034.164551311927666 (code B ref 54034); Tue, 22 Feb 2022 06:59:02 +0000 Original-Received: (at 54034) by debbugs.gnu.org; 22 Feb 2022 06:58:39 +0000 Original-Received: from localhost ([127.0.0.1]:39860 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nMP8A-0007C9-P2 for submit@debbugs.gnu.org; Tue, 22 Feb 2022 01:58:38 -0500 Original-Received: from mail-wm1-f47.google.com ([209.85.128.47]:54053) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nMP89-0007By-F6 for 54034@debbugs.gnu.org; Tue, 22 Feb 2022 01:58:37 -0500 Original-Received: by mail-wm1-f47.google.com with SMTP id i20so455435wmc.3 for <54034@debbugs.gnu.org>; Mon, 21 Feb 2022 22:58:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=GgznpkLerZSUuGoGdkRgykd0M0sC1fXgdVGjo4Vm2P8=; b=q6nsTmZgcpn3s5yp2QgnUEba931er61V6spbEgNmGe5z7AveCWCPcmZZD1O/KtX4IL AdPz0omROSSX7jZyfUwi+pTepXXtAERLVHGWsKNMzlbAFhKXlBFoEktfFbGL9SxCvbWd caNEtF5IOH3x7xlq1nLBxcm3a4hRpkSx1snAIgaBhPUcwSrJJiDsp07yYtPTWsVHVrSD kG/+d4H7Wu7rHEH+HNmeNEh5hujQq7NyYy9Lc436Pj472ve5y25/vmnbUnncDB0tmjP2 oTABEzVHYgrLaUNH+/zqJOJxlhtpmjzN2CS1e4HCf+Bq+M/ioQmU1/Pre+hk06kpelFr W9Zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=GgznpkLerZSUuGoGdkRgykd0M0sC1fXgdVGjo4Vm2P8=; b=XCtmDWOW46WCdr7eDSOh3zEaZDL2hx0xCaEYZlLV8QIxkOUHFYeWYypQx704lYNDur O9oX3Lbtf698uBi4fym6u3iKbC763l6TROcIQDNJ4Jr/j4WSvHNTLsQ5O/j6E4SWSsyY tqYSbfpANGk6aSk++sBStB0PCx0JZS78a6seJulBu2lMlEsMbFrmS2B61zhXajMebiMV 4Ez7hF9ix8cqPmlzSf773WBgz+4uNbNOnri2cz16vY2o0NGkhr0OjGepCKRsNftMHSq5 2UQeO2hmXm+Pe9c17qVT3VKOOURPwdWWBqPvdByhvBmF1zf1XqWK8TPLdNdlUXmdqgiF HZ0w== X-Gm-Message-State: AOAM53306l01vE2VhxOxnTlTrl8oV/iRCX4ld+KpgvYbI9uwKbVh+7e2 C3SjTilHQffDBimfZuvJw61wI8PX4cU= X-Google-Smtp-Source: ABdhPJwybySjgDuclefIjQUOBEWg2y+vycGLhUVt/0Z3LoltRdX8jrcAusPtQQvA4+V4WS0Ok2hokw== X-Received: by 2002:a05:600c:3588:b0:37c:306a:9eb7 with SMTP id p8-20020a05600c358800b0037c306a9eb7mr1943782wmq.107.1645513111376; Mon, 21 Feb 2022 22:58:31 -0800 (PST) Original-Received: from carbon.localdomain ([2a01:e0a:245:c850:98f5:429a:aa8e:95bb]) by smtp.gmail.com with ESMTPSA id j6sm40284331wrt.70.2022.02.21.22.58.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Feb 2022 22:58:30 -0800 (PST) In-Reply-To: (Stefan Monnier's message of "Mon, 21 Feb 2022 18:55:05 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:227410 Archived-At: Stefan Monnier writes: > I just pushed a change for that as well. Thank you! > Of course, there's always the problem that this prettification > hides info, so there's a tension here. You're right. Would changing the string "Modified file " to "Modified file and file mode " be better when both the file and the file mode are changed? We also could handle "mode changes" only hunks with the string "Modified file mode ". Does this proposal looks good to you? I can try to implement it. Unfortunately for the last case we'll have to modify the regex to match the file name from the "diff --git" line... To improve the situation on hidden info, would it make sense to provide a `diff-toggle-display-properties-at-point`? Or/and provide the original text as tooltip? Just thinking. -- Matthias