From: Stephen Eglen <sje30@cam.ac.uk>
To: Po Lu <luangruo@yahoo.com>
Cc: 54333@debbugs.gnu.org, Stephen Eglen <sje30@cam.ac.uk>
Subject: bug#54333: 29.0.50; browse-url-chrome in Wayland/pgtk
Date: Fri, 11 Mar 2022 08:30:48 +0000 [thread overview]
Message-ID: <87ee3899h2.fsf@cam.ac.uk> (raw)
In-Reply-To: <87fsnpz2al.fsf@yahoo.com>
yes, thanks. It does fix my bug report.
Stephen
On Fri, Mar 11 2022, Po Lu wrote:
> Po Lu <luangruo@yahoo.com> writes:
>
>> Indeed. I'll look into that, thanks.
>
> Does this patch solve the problem?
>
> diff --git a/lisp/net/browse-url.el b/lisp/net/browse-url.el
> index 6d28e318ff..776f774172 100644
> --- a/lisp/net/browse-url.el
> +++ b/lisp/net/browse-url.el
> @@ -970,7 +970,13 @@ browse-url-process-environment
> environment, otherwise just use the current environment."
> (let ((display (or browse-url-browser-display (browse-url-emacs-display))))
> (if display
> - (cons (concat "DISPLAY=" display) process-environment)
> + (cons (concat (if (and (eq window-system 'pgtk)
> + (equal (pgtk-backend-display-class)
> + "GdkWaylandDisplay"))
> + "WAYLAND_DISPLAY="
> + "DISPLAY=")
> + display)
> + process-environment)
> process-environment)))
>
> (defun browse-url-emacs-display ()
>
next prev parent reply other threads:[~2022-03-11 8:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-10 23:12 bug#54333: 29.0.50; browse-url-chrome in Wayland/pgtk Stephen Eglen
2022-03-11 0:47 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-03-11 1:49 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-03-11 8:30 ` Stephen Eglen [this message]
2022-03-11 8:37 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ee3899h2.fsf@cam.ac.uk \
--to=sje30@cam.ac.uk \
--cc=54333@debbugs.gnu.org \
--cc=luangruo@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).