From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrew Cohen Newsgroups: gmane.emacs.bugs Subject: bug#54158: 28.0.91; duplicate mail downloads in Gnus (IMAP) Date: Sat, 19 Mar 2022 12:53:52 +0800 Message-ID: <87ee2ya6fz.fsf@ust.hk> References: <87tucmc2y4.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32622"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) To: 54158@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Mar 19 05:55:15 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nVR7R-0008Gf-75 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 19 Mar 2022 05:55:14 +0100 Original-Received: from localhost ([::1]:33954 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nVR7P-0001F1-GC for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 19 Mar 2022 00:55:11 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:60748) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nVR7H-0001Ei-8D for bug-gnu-emacs@gnu.org; Sat, 19 Mar 2022 00:55:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36728) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nVR7G-0001uw-Vy for bug-gnu-emacs@gnu.org; Sat, 19 Mar 2022 00:55:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nVR7G-0002Fc-SH for bug-gnu-emacs@gnu.org; Sat, 19 Mar 2022 00:55:02 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: <87tucmc2y4.fsf@gnu.org> Resent-From: Andrew Cohen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 19 Mar 2022 04:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54158 X-GNU-PR-Package: emacs Original-Received: via spool by 54158-submit@debbugs.gnu.org id=B54158.16476656458548 (code B ref 54158); Sat, 19 Mar 2022 04:55:02 +0000 Original-Received: (at 54158) by debbugs.gnu.org; 19 Mar 2022 04:54:05 +0000 Original-Received: from localhost ([127.0.0.1]:58855 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nVR6L-0002Dn-4t for submit@debbugs.gnu.org; Sat, 19 Mar 2022 00:54:05 -0400 Original-Received: from mail-os0jpn01on2113.outbound.protection.outlook.com ([40.107.113.113]:25343 helo=JPN01-OS0-obe.outbound.protection.outlook.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nVR6I-0002DD-VI for 54158@debbugs.gnu.org; Sat, 19 Mar 2022 00:54:03 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BBFvn03o6ahXQoxfdTmVi9WL6PD96JBdmRRhr+n9RDX92+6qXoVThg9QRlcpOpAz7LvIotLMIe4/QlOnMa6IOFBato6uXlPhl7TlfW73ZFAvR6+M+8IIlWPP6nux9gdEi4OgiGA93JiCU5YcTxqS69F5figMLcgISeP+m3T7eFVknTA3R5nI0bdEzYZF3UoV5x50y/VNYUoOaG3G/j8WUm4XR1HR0guGxPHVuRR77RNjKNT8cObLWNb9ZNlTs0+1T7oZpvdK7jYZwCk1tJ2PCDqb4hHv70SwMrLHFmlNJB/fsk+Efb9LeahxJAxn2EJqaOa8Py9ptBU9TEKszqw3dQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oFn3vCP7AE5Ig32RX+TS6E3CICOAc3HJcQnwD0BzLms=; b=Qp8XcUcC/jAsTjSACnWpdOq4BKZ5NXjVw7mTE1C8fAq9Tyg+QpvssrDRuRCShbtQCGLPDcFTSDaZqBBroqEtVH/wkZHxlvlL2gzV0h7xOo7gRTTd8KzSzXOYGEz9sZ77ct8zCdtq2wPgevggaRw2hA3XglhzlrXTnyzc/fU1DgAFYkAGIPLurzz+0CGRLm3gIcDaqpi31JaxiC0+S05FWmlg12akA5UjRIYbZqLf7MmMIelOLXu09IfP9+uGR4cD4saULMEFdp8sgUbQ6qfhgBf3mm8juJTtZ4CnhVu/rjjtzXfeBNgO0guGhfXnUylp+VxXnnoINyDNbA21aGWi+g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=ust.hk; dmarc=pass action=none header.from=ust.hk; dkim=pass header.d=ust.hk; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ust.hk; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oFn3vCP7AE5Ig32RX+TS6E3CICOAc3HJcQnwD0BzLms=; b=flhQRnGUKleJGRei9IffE9zhVwJVJGv0rXUKNggZfa/K5DyvlPBShuxga6vBe8jnf8njacgU2G+vIIn9ZBN0rK92eJnjGblFWODZtv5qbcJ8FXtNM4Hs1mL3LaESJ+Qc98Yw/TENVXQBGlVvCbEvPSQQ4nI2yQyEwR7iL3fZBAMlp6bYTpc0pmqXJU99e9q1FNiv4LWRJZz3q4Sh9h7Qwuz8X3kOsOfyW/ysyMLnQv39VCJvTlrux/a+WhMpFqhs/zYhAjNINOC6r+ASeVXazTrIRluIQOOR7GM/YjQkn2giLaWa0VBoTe7YGP7JM9H/ebBzOBHeMKVbN0JsYT8akA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=ust.hk; Original-Received: from OS3P286MB1877.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:1bf::11) by TYCP286MB0911.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:ad::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5081.14; Sat, 19 Mar 2022 04:53:55 +0000 Original-Received: from OS3P286MB1877.JPNP286.PROD.OUTLOOK.COM ([fe80::255f:b27f:3eaf:717]) by OS3P286MB1877.JPNP286.PROD.OUTLOOK.COM ([fe80::255f:b27f:3eaf:717%4]) with mapi id 15.20.5081.019; Sat, 19 Mar 2022 04:53:54 +0000 X-ClientProxiedBy: HK2PR02CA0181.apcprd02.prod.outlook.com (2603:1096:201:21::17) To OS3P286MB1877.JPNP286.PROD.OUTLOOK.COM (2603:1096:604:1bf::11) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c2590aa0-8423-447a-33ea-08da09647812 X-MS-TrafficTypeDiagnostic: TYCP286MB0911:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: kkS0e9PRnYnz8J25eh1T2Ga1XGuIfeik6pNTNfAnkTe9ss8Ogls2PQMf/oNboBPwX2SSk03FJO/H3xn55rmxcwSM7+MLR5G9lpupAH0jvv8v8ITNNKbBAquDHv/LpJtfmgLajy0fuoHBG9RnaGUm4TcrFtloHzPkzR4/xFe5UsHwZKF4or29Qu9S8ewGXr1p/UKDQF0unVvGUZ1wZwvVMAi71sWxr34QXf6OEybu46xo2cqHEabwqIxHfVrSsLOSTENlHV5Enru6nSACJDqenVSHZbggB9CX7TcNCggY66rR8pJu92ys0HmRq4kDMUdpr7w8cE8NhV5BeqbQOdUJZMKGmvSMgp8SjMgOQCzUFGiAQsOZChuebNyRPFlI4y40hZBub772cGAv3dbzrsyoiBVHIW8hb7DrgKb9ULucAvvJ1wRX0ggVRcKTAkQxk/epmzY5UbPYvcLrYX8J+SvGlIsL1cLD8aCov7Zg3DflDtSJrA3kM49XXBPyqzxgXg4k1orILOfDpsnCFL1a99wU0SLJ+LVwiZosVCDkHuVrBLc6JJelD4HAJCzRYKfYSZq8NB2A0UL7KcPwYc5UYv2bh9PW0VBQCo05+0W024RkgMlFeG6FZgYi40lCFJHROxPPeps1HWqG8pgcKre+9Rxbqw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:OS3P286MB1877.JPNP286.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(6506007)(36756003)(508600001)(2616005)(26005)(6486002)(6512007)(86362001)(186003)(786003)(316002)(8936002)(2906002)(5660300002)(6916009)(66476007)(66556008)(8676002)(66946007)(38100700002)(83380400001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: XmTjc7JPpQcTNbf/D/JqqaO8Aq6MnGrm5iPnXHykthFRLz6t4GlL1LRTvHgh9jNLAqtVnieiyVUZnASjl/ZCh6pWM5h/Ph+WGUYBy/DuBC/i9Hg6uL6NEswheodoEw2LL3vUceepssu15YUBMmnTs0IbQvk4a1mRz1Nw6vh8j+Nu9FQKdTG1WgFfFBmRwfxy4uIIA5gCdHd8x4YRFII2JbgQr65vjW4eQhjRZSl/hMwnQMXp7QQS9bU/TV0a+9ij5c/RHYpzRi01YCvflx6pgPQVrqAzowrMsCjafAJmV1jbCtMZWc72n1A3QxS+HB4GMQVC8WteRCkpuwrHdYNTFVeT27CBkgo3sLYqgeLBhH/g0dbbzmk0yCSJtBVtRX1SXqET7tGvKgV4o5veG/rXXZsiEmQQc19oMwdRtiLMIqY203tEgJEXWy5kPlQN5GO2xXx3bTTdnzOi8btOZHmPXlFRGmAlsdavO2ikSz1nD2OGvLUeWoq1FA0H7dojU+SMLBIXBWGTz9kmiD85Qqm1lPkFluhhQZ165zSMuf5PvPPUqfi3H4krGtWE0IDXuWRQT4t5glJ30KcTRq0iiRFuwuEQ+nllpvo+V7HHwsPXZ7/aqatdBDEwDFHGg/EhykmOkeD+5wdXcWc58RFQrmSfQG7j60bWyu7d0Sca8HDBXLrcb+DApn01XKZoV5vam9cBuU+AUf4ZxM5Etem5PWKIZ+vXqvd52f2nESSKKn0g9Z9sgZAEDBvf3FoTcP h75Heo+/RkkGEf052PUOW6vyC5FQkSf3d7vW8JXsyPyMJp4oRbp1AYXS6nFkkLnsPlUGgQUt5ftbC7gm+LonQrXK/c9Fq7L7cz X-OriginatorOrg: ust.hk X-MS-Exchange-CrossTenant-Network-Message-Id: c2590aa0-8423-447a-33ea-08da09647812 X-MS-Exchange-CrossTenant-AuthSource: OS3P286MB1877.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Mar 2022 04:53:54.8902 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: c917f3e2-9322-4926-9bb3-daca730413ca X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mYSNxc20kYFezBBrbwIggZaUWM50awDsjSdJR/a7gWljLll8GQZSW2NnJBoxVc7X X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYCP286MB0911 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:228578 Archived-At: (I sent this to Roland directly since I'm a bit shy about communicating on public lists, but here goes anyway) I think the problem is that the code in mail-source-fetch-imap doesn't handle a list of mailboxes properly (I don't know why it would have worked in emacs-27 though). Adam added a loop over a list of mailboxes way back in 2015, but it seems to me that some of the variables bound outside the loop should be bound inside (imap usually works on a per mailbox basis) So I think this might fix it (although I don't have a setup available to test it). Of course I might be totally off-base. If so, sorry in advance. diff --git a/lisp/gnus/mail-source.el b/lisp/gnus/mail-source.el index 5d0c0e2654..01cca831f2 100644 --- a/lisp/gnus/mail-source.el +++ b/lisp/gnus/mail-source.el @@ -1066,9 +1066,7 @@ mail-source-fetch-imap (let ((from (format "%s:%s:%s" server user port)) (found 0) (buf (generate-new-buffer " *imap source*")) - (mail-source-string (format "imap:%s:%s" server mailbox)) - (imap-shell-program (or (list program) imap-shell-program)) - remove) + (imap-shell-program (or (list program) imap-shell-program))) (if (and (imap-open server port stream authentication buf) (imap-authenticate user (or (cdr (assoc from mail-source-password-cache)) @@ -1078,7 +1076,8 @@ mail-source-fetch-imap (dolist (mailbox mailbox-list) (when (imap-mailbox-select mailbox nil buf) (let ((coding-system-for-write mail-source-imap-file-coding-system) - str) + (mail-source-string (format "imap:%s:%s" server mailbox)) + str remove) (message "Fetching from %s..." mailbox) (with-temp-file mail-source-crash-box ;; Avoid converting 8-bit chars from inserted strings to -- Andrew Cohen