From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#54346: persist-save doesn't persist variables when the value is set to the default Date: Mon, 11 Apr 2022 12:18:01 +0200 Message-ID: <87ee23diue.fsf@gnus.org> References: <87r177ysjh.fsf@gnus.org> <87pmlpqgix.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8437"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Phillip Lord , 54346@debbugs.gnu.org To: Gulshan Singh Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Apr 11 12:19:34 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ndr8v-0001yp-SO for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 11 Apr 2022 12:19:33 +0200 Original-Received: from localhost ([::1]:60120 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ndr8v-0002Mm-1C for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 11 Apr 2022 06:19:33 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55170) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ndr8Q-0001oL-9D for bug-gnu-emacs@gnu.org; Mon, 11 Apr 2022 06:19:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:48684) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ndr8P-0005lF-UC for bug-gnu-emacs@gnu.org; Mon, 11 Apr 2022 06:19:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ndr8P-00011P-Ph for bug-gnu-emacs@gnu.org; Mon, 11 Apr 2022 06:19:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 11 Apr 2022 10:19:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 54346 X-GNU-PR-Package: emacs Original-Received: via spool by 54346-submit@debbugs.gnu.org id=B54346.16496722993860 (code B ref 54346); Mon, 11 Apr 2022 10:19:01 +0000 Original-Received: (at 54346) by debbugs.gnu.org; 11 Apr 2022 10:18:19 +0000 Original-Received: from localhost ([127.0.0.1]:42578 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ndr7j-00010C-H8 for submit@debbugs.gnu.org; Mon, 11 Apr 2022 06:18:19 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:34374) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ndr7i-0000zz-35 for 54346@debbugs.gnu.org; Mon, 11 Apr 2022 06:18:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=KKUn26uZWrJChpePlZN5Thyi6xhVCJOyhAsP4pGgRxw=; b=EZ8yGV6tNIaehc366F/N9pBieU nmP7L7m17Q5BkgesdjgC9KSw9yH3JJ/whlBiG3Wrpi/LSdsDm4emtdcTaNuLTWzZAGz5iJPJJI02n 0ht669t9dTlaBcwQpj/AK1GOghgq8AEDMaJKre04c2za3aUmrM+qlUkKhNNEwQM6y5rg=; Original-Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ndr7Y-0001fH-9c; Mon, 11 Apr 2022 12:18:10 +0200 In-Reply-To: (Gulshan Singh's message of "Sun, 10 Apr 2022 12:36:54 -0700") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:229702 Archived-At: Gulshan Singh writes: > I cloned the upstream project [1] and created a merge request [2] > there. The fix deletes the persist file when it gets set back to the > default value, and it modifies a test to verify this behavior. I've > attached the same patch here (created with `git format-patch HEAD^`, I > haven't submitted a patch here before so let me know if this is the > correct way to do this). Yup; looks good. > I'm a little confused though, I see that on the externals/persist > branch [3] there is a commit that does not exist on the upstream > GitLab project. Why is this the case? Should I actually be making a > patch off of the externals/persist branch? That's my error -- I didn't check whether it persist was maintained externally before making that change. So it should be merged upstream. Phillip? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no