unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: Gulshan Singh <gsingh2011@gmail.com>
Cc: Phillip Lord <phillip.lord@russet.org.uk>, 54346@debbugs.gnu.org
Subject: bug#54346: persist-save doesn't persist variables when the value is set to the default
Date: Mon, 11 Apr 2022 12:18:01 +0200	[thread overview]
Message-ID: <87ee23diue.fsf@gnus.org> (raw)
In-Reply-To: <CANEZYre0CoF2qs-UsJ3FN08F_4FYTGWmTTBP4L_KHqzhrumdgw@mail.gmail.com> (Gulshan Singh's message of "Sun, 10 Apr 2022 12:36:54 -0700")

Gulshan Singh <gsingh2011@gmail.com> writes:

> I cloned the upstream project [1] and created a merge request [2]
> there. The fix deletes the persist file when it gets set back to the
> default value, and it modifies a test to verify this behavior. I've
> attached the same patch here (created with `git format-patch HEAD^`, I
> haven't submitted a patch here before so let me know if this is the
> correct way to do this).

Yup; looks good.

> I'm a little confused though, I see that on the externals/persist
> branch [3] there is a commit that does not exist on the upstream
> GitLab project. Why is this the case? Should I actually be making a
> patch off of the externals/persist branch?

That's my error -- I didn't check whether it persist was maintained
externally before making that change.  So it should be merged upstream.

Phillip?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no





  reply	other threads:[~2022-04-11 10:18 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-12  1:15 bug#54346: persist-save doesn't persist variables when the value is set to the default Gulshan Singh
2022-03-12 17:44 ` Lars Ingebrigtsen
2022-04-09 21:45   ` Gulshan Singh
2022-04-10 12:17     ` Lars Ingebrigtsen
2022-04-10 19:36       ` Gulshan Singh
2022-04-11 10:18         ` Lars Ingebrigtsen [this message]
2022-06-21  2:14           ` Gulshan Singh
2022-06-21 10:49             ` Lars Ingebrigtsen
2022-06-22  0:55               ` Gulshan Singh
2022-06-22  4:21                 ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ee23diue.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=54346@debbugs.gnu.org \
    --cc=gsingh2011@gmail.com \
    --cc=phillip.lord@russet.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).