From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Heerdegen Newsgroups: gmane.emacs.bugs Subject: bug#56423: 29.0.50; Hi-lock in dired broken by toggling wdired-mode Date: Thu, 07 Jul 2022 12:26:03 +0200 Message-ID: <87edyxz0as.fsf@web.de> References: <874jzui52r.fsf@web.de> <87iloa2hlm.fsf@web.de> <87mtdmyrp4.fsf@web.de> <83o7y15vtz.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22978"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 56423@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jul 07 12:27:18 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o9Oj8-0005pV-0H for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 07 Jul 2022 12:27:18 +0200 Original-Received: from localhost ([::1]:46696 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o9Oj6-0000AD-Eb for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 07 Jul 2022 06:27:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33234) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o9Oit-00009y-9w for bug-gnu-emacs@gnu.org; Thu, 07 Jul 2022 06:27:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33720) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o9Ois-0002uf-5C for bug-gnu-emacs@gnu.org; Thu, 07 Jul 2022 06:27:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o9Ois-0002Rl-1C for bug-gnu-emacs@gnu.org; Thu, 07 Jul 2022 06:27:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Heerdegen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 07 Jul 2022 10:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56423 X-GNU-PR-Package: emacs Original-Received: via spool by 56423-submit@debbugs.gnu.org id=B56423.16571895749348 (code B ref 56423); Thu, 07 Jul 2022 10:27:01 +0000 Original-Received: (at 56423) by debbugs.gnu.org; 7 Jul 2022 10:26:14 +0000 Original-Received: from localhost ([127.0.0.1]:55850 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o9Oi6-0002Qi-1H for submit@debbugs.gnu.org; Thu, 07 Jul 2022 06:26:14 -0400 Original-Received: from mout.web.de ([212.227.17.12]:51931) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o9Oi3-0002QV-K2 for 56423@debbugs.gnu.org; Thu, 07 Jul 2022 06:26:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1657189564; bh=1IzjmB9gJNglowXZ2Eem5Z/mk3Ahrd/GCuRDERVjGio=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=cXuKGIoxuBOSQL9XN6vDbvaybIIy37SxDbyup+hIUetxhC6IPVDDzPIklIJ+WanLj yfIK2U0l99Z+rFA4xujAui6SwbMu96aTFHVPcOO6opJX1zL+8He5XXoVCvREl12rDK uBRDM/QJ29OqeX5ycfWt19NrP6GGxNZjAyZyMCLo= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Original-Received: from drachen.dragon ([84.59.210.236]) by smtp.web.de (mrweb105 [213.165.67.124]) with ESMTPSA (Nemesis) id 1MrwwJ-1nmNgH1QcX-00ngRF; Thu, 07 Jul 2022 12:26:04 +0200 In-Reply-To: <83o7y15vtz.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 07 Jul 2022 08:35:20 +0300") X-Provags-ID: V03:K1:p1OHaRwWod4URqf3sEoZG+LnzOlhasQCIErUZ0wO+ZoEOhnCOMc BTQPAedA0fkRPvG7s4fUMQDkD0JeZfhm6hQdDzoemfOKlLDE4oWjx4aHcYFOBvSH5fevJ9u LPeTSKne2PK8nNc3E+1P6iimmha7hudUpG1+UPOgjdNZKdabDfYkAQTbE/AVVlZd8EH7j4o GG0VM7AOZHvsbWfTIH9fQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:XaCjNEpWg+E=:KUgiwykW2GA60BWaazQUDV pZ8Yjh/a7sdvMBXUvM4Fz8J4BZ/bgVYpjmxtlEkmAppyajmuiPVDEu5Iyd/zb3X9KihY8R467 EuPXC7EZNRHltTUSeZpzDLC5lOOo9T+SYYQ1NXPWkb4uwwopofpe7s0RcAoB/UN34cdXPgBpe +zPeSMW8OCBiBmQckjYlFsSi0xKcOBnewMajkhwa48V39LushnupYftgDpw/LIvGISUluSwRj 4cgycWMkoqir/MAsXsqqGjrKfRaKLiVnuraJp0Njulv1+YmGjbAlXwS7k7QhYsEuXkCZ0XCsC LNa7Rs6QLrG0Qqqv+TlQ766kl8nLVVk2IXT+Puu+RTTpLiRN3LHjRAInsGOUe+r8Uq/MMWUE3 tIl9duB6z0U/91AOlO3BC1S3cJaAUybPrQURMUauyQSfeTGY2WUIvcCioWNoLMRP3AH5u3z8H NEF/JcdjRwwgnoTH63PQ9Lje9uLFAnEcRn8b2lwPlrDskV1o3WYmwlK81s/jYTLRGEZU8pbx7 GXFvQUNF0JxDZJCBgDGUQlYgtU20B9Or59n/Bc7lvcMdGvW6uf5c3dj5ydlt8W3eUvD4xCNnd cDBSALmhAWGpE54g0ZENjVGQAfnM1wzdFzew0Ym7FZfU4lmMFE1IoP7+UfU0IR+5Rj0+GBem+ uYCMuN4hYaxE9WQeqqFZxNNeooxauyVmInOLEz1PN1KyQk/+bHE2tfv1iDmSCstEPZ6UZyQZk JT36TWic6heKP1rti838sFV3mkCX7kzLw9zeu9Yh62ixSlX3zy7Hs0BfLDLlrhakGcJOJtsM X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:236350 Archived-At: Eli Zaretskii writes: > > diff --git a/lisp/wdired.el b/lisp/wdired.el > > index a5858ed190..7c8969431f 100644 > > --- a/lisp/wdired.el > > +++ b/lisp/wdired.el > > @@ -261,6 +261,7 @@ wdired-change-to-wdired-mode > > (add-hook 'before-change-functions #'wdired--before-change-fn nil t) > > (add-hook 'after-change-functions #'wdired--restore-properties nil t) > > (setq major-mode 'wdired-mode) > > + (setq font-lock-major-mode 'wdired-mode) > > (setq mode-name "Editable Dired") > > (add-function :override (local 'revert-buffer-function) > > #'wdired-revert) > > (set-buffer-modified-p nil) > > @@ -457,6 +458,7 @@ wdired-change-to-dired-mode > > (force-mode-line-update) > > (setq buffer-read-only t) > > (setq major-mode 'dired-mode) > > + (setq font-lock-major-mode 'dired-mode) > > (setq mode-name "Dired") > > (dired-advertise) > > (remove-hook 'kill-buffer-hook #'wdired-check-kill-buffer t) > Don't we need to make sure font-lock-major-mode is restored no matter > how wdired is exited, whether normally or abnormally? There are two official ways to return - `wdired-abort-changes' and `wdired-finish-edit' - both call `wdired-change-to-dired-mode' (which I modified). If a way of exiting doesn't call `wdired-change-to-dired-mode' your dired buffer would be broken afterwards AFAIU - you must call it to get rid of the modifications made by wdired. Michael.