From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#57376: 28.1; rcirc-fill-flag ignored after 27->28 upgrade Date: Sat, 27 Aug 2022 13:37:01 +0000 Message-ID: <87edx1dczm.fsf@posteo.net> References: <87y1vekpyl.fsf@gmail.com> <875yihoofa.fsf@gnus.org> <871qt4qquo.fsf@posteo.net> <875yiedrx6.fsf@posteo.net> <87wnat95yb.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29739"; mail-complaints-to="usenet@ciao.gmane.io" Cc: "Trent W. Buck" , 57376@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Aug 27 15:38:12 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oRw0p-0007Ws-ST for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 27 Aug 2022 15:38:11 +0200 Original-Received: from localhost ([::1]:45090 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oRw0o-0003XB-F8 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 27 Aug 2022 09:38:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50930) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oRw0g-0003TN-4l for bug-gnu-emacs@gnu.org; Sat, 27 Aug 2022 09:38:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37506) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oRw0f-0004iw-S8 for bug-gnu-emacs@gnu.org; Sat, 27 Aug 2022 09:38:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oRw0f-0007yy-Ny for bug-gnu-emacs@gnu.org; Sat, 27 Aug 2022 09:38:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 27 Aug 2022 13:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57376 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 57376-submit@debbugs.gnu.org id=B57376.166160744030637 (code B ref 57376); Sat, 27 Aug 2022 13:38:01 +0000 Original-Received: (at 57376) by debbugs.gnu.org; 27 Aug 2022 13:37:20 +0000 Original-Received: from localhost ([127.0.0.1]:55488 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oRw00-0007y5-CN for submit@debbugs.gnu.org; Sat, 27 Aug 2022 09:37:20 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]:42841) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oRvzx-0007xp-QX for 57376@debbugs.gnu.org; Sat, 27 Aug 2022 09:37:19 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id DBC46240026 for <57376@debbugs.gnu.org>; Sat, 27 Aug 2022 15:37:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1661607431; bh=46l+fsxClauAjqkNArYK1gwuk/HdKb4emO2Du9UPy/Y=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=XflT3StgNrDh9Bww3PGf12COEPvzTRW6mUxJ1HvFLqgUSgPYK761WLgPQI1kXSD0J Amcfh6RKtmgJrsLsDLpPVLIyZ3i5kNA+myYeORvPDiAIGbftH8enBFa2HumrYpNtdm IKD68FLWKbE67BJBqmOH50sId6A9SiIpSjBQdPbpTwxDZeyE3ioDXE4LolPkbbZJci sxOCL234eW4j/xlaIPENaZ247bMeed/ejjPNToC2rZ+12sOYAnw9NR/2elqMhA1B+h +y58SLlPDcVErODM9Hiz+xtXaOUS2DGdNQyBKNDO0Ktot8xSKX/VUAHmhEFdq2dPHW OWT/sLy7/BvUA== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4MFHn05G7jz9rxS; Sat, 27 Aug 2022 15:37:06 +0200 (CEST) In-Reply-To: <87wnat95yb.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sat, 27 Aug 2022 15:22:36 +0200") Autocrypt: addr=philipk@posteo.net; prefer-encrypt=nopreference; keydata= mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:240918 Archived-At: Lars Ingebrigtsen writes: > > Philip Kaludercic writes: > >> But I am not sure I understand what is going on here, since this "fills >> the region" between the beginning of the prompt and either the end of >> the prompt or the next (nonexistant?) message? So shouldn't this >> have -- prior to my change -- have done nothing, all the time? > > Hm... like I said, I'm not very familiar with this code, but I think > you may be right here. > > So just removing the fill might be the right fix here. At the very least I was wrong about the (fill-region (point-min) (point-max)), so that has to go. But I will modify the code locally to check if squeezing white-space before the prompt is still necessary or not.