From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#58007: 28.1; compilation-error-properties skips non-matching FILE indices Date: Fri, 23 Sep 2022 18:10:14 +0200 Message-ID: <87edw23wd5.fsf@gnus.org> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33763"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 58007@debbugs.gnu.org To: Axel Forsman Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Sep 23 18:11:58 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oblHR-0008ae-J0 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 23 Sep 2022 18:11:57 +0200 Original-Received: from localhost ([::1]:47958 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oblHQ-0002Ml-CO for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 23 Sep 2022 12:11:56 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:35858) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oblGY-0002Gy-G1 for bug-gnu-emacs@gnu.org; Fri, 23 Sep 2022 12:11:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:42436) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oblGY-0003uG-8N for bug-gnu-emacs@gnu.org; Fri, 23 Sep 2022 12:11:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oblGX-0006PD-U7 for bug-gnu-emacs@gnu.org; Fri, 23 Sep 2022 12:11:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 23 Sep 2022 16:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58007 X-GNU-PR-Package: emacs Original-Received: via spool by 58007-submit@debbugs.gnu.org id=B58007.166394942524556 (code B ref 58007); Fri, 23 Sep 2022 16:11:01 +0000 Original-Received: (at 58007) by debbugs.gnu.org; 23 Sep 2022 16:10:25 +0000 Original-Received: from localhost ([127.0.0.1]:41511 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oblFw-0006O0-R9 for submit@debbugs.gnu.org; Fri, 23 Sep 2022 12:10:25 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:38480) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oblFu-0006NZ-NM for 58007@debbugs.gnu.org; Fri, 23 Sep 2022 12:10:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=X5P1JtIXlOnO3y3uzY4F+b1EykWxXaYyiDoNqx+NBUU=; b=hSmpiwQ1Pc7/0G7D+/Pb6NzKh3 uxGfuvALyrq/tKxCQdGYKdxeYq19vWgPGBnC1i96XfxpnjdhpX1k17nQN7xgHwAxlusV7SHZgTQ0n DCwfwdLRdKAGMZY2mYOZWsISLYe8vvPcMesC6fy/dGpePlMlVsgkCQ70HALIQK4GfNlg=; Original-Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oblFm-0003PO-OR; Fri, 23 Sep 2022 18:10:16 +0200 In-Reply-To: (Axel Forsman's message of "Thu, 22 Sep 2022 17:09:55 +0200") X-Now-Playing: Kate Bush's _Never For Ever_: "Delius (Song of Summer)" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:243479 Archived-At: Axel Forsman writes: > which clearly, unambiguously implies that if the FILE index does not match > then the previous file name should be used for the error. > However that is not what the code does currently, > instead it skips such matches. Do you have a test case that demonstrates the problem? > I have attached a patch containing my suggested fix. I think this change might be too large to apply without having an FSF copyright assignment on file -- would you be willing to sign such paperwork?