From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Sean Whitton Newsgroups: gmane.emacs.bugs Subject: bug#58092: 29.0.50; [PATCH] Add log-edit-summary-separator face Date: Tue, 27 Sep 2022 17:49:42 -0700 Message-ID: <87edvwgw61.fsf@melete.silentflame.com> References: <87bkr2mhj1.fsf@protesilaos.com> <87a66mdych.fsf@protesilaos.com> <87czbi9p23.fsf@gmail.com> <87h70szuig.fsf@melete.silentflame.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25692"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Lars Ingebrigtsen , Robert Pluim , Dmitry Gutov , Protesilaos Stavrou , 58092@debbugs.gnu.org To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Sep 28 02:50:18 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1odLHD-0006Oz-To for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 28 Sep 2022 02:50:18 +0200 Original-Received: from localhost ([::1]:46342 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1odLHC-0000Ux-JY for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 27 Sep 2022 20:50:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33418) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1odLH1-0000Un-3h for bug-gnu-emacs@gnu.org; Tue, 27 Sep 2022 20:50:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:57962) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1odLH0-0008FO-8U for bug-gnu-emacs@gnu.org; Tue, 27 Sep 2022 20:50:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1odLH0-0006Lr-1M for bug-gnu-emacs@gnu.org; Tue, 27 Sep 2022 20:50:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Sean Whitton Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 28 Sep 2022 00:50:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58092 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 58092-submit@debbugs.gnu.org id=B58092.166432619224396 (code B ref 58092); Wed, 28 Sep 2022 00:50:01 +0000 Original-Received: (at 58092) by debbugs.gnu.org; 28 Sep 2022 00:49:52 +0000 Original-Received: from localhost ([127.0.0.1]:57040 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1odLGq-0006LP-8e for submit@debbugs.gnu.org; Tue, 27 Sep 2022 20:49:52 -0400 Original-Received: from out4-smtp.messagingengine.com ([66.111.4.28]:47573) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1odLGn-0006LB-MY for 58092@debbugs.gnu.org; Tue, 27 Sep 2022 20:49:51 -0400 Original-Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 9048B5C0077; Tue, 27 Sep 2022 20:49:44 -0400 (EDT) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Tue, 27 Sep 2022 20:49:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:cc:content-transfer-encoding:content-type:date:date:from :from:in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1664326184; x= 1664412584; bh=UWzrHZwa5gQMH31UmipDkRIP9N9iRMjjzPrrPSxx6cg=; b=K MCP1ohdpAwoNWki8uLhwFqJYGQuFs6ECX4Fh+gzdngQKCidjzn3qcO1BBcvdDOjw ScTR1ATWNZWFd4PfvYHJO8MpL/RxtZtLTl5AaSU6DLgKkVRS8RnngoEcRGTa2NzT 1Cq9F99Gz9KPdIyUPN+Jzu7+YNpKDagJqtGzF9M0xvAyWGy44ivfEcjpsEHqsd3y 13DSV5clJART3MNlfhtZO1a2Xs/0oaom9qmo4nMEpboiMPmgQmYuQQDjQDx0rgws C/WL7sJ39UBkx+d5zoG2jelRWwx/wqY3TbtEZynNY7mFsRHEHzX8UoEwsPRMDrHU nlkD+RdDN4WcIiRFKEdBA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1664326184; x= 1664412584; bh=UWzrHZwa5gQMH31UmipDkRIP9N9iRMjjzPrrPSxx6cg=; b=h p0p8ipCHvu2TrJg0E1g7SbV3J8+4ZDL4BkrgjP4hqJ7vfSgqeGpOxsU7OS8JXu3S vcj1KrBNtBvOs1zCEyUcev8ClwLb0s1yaczF9eRtx4oXpAgARRqWGE0oOSPEj1uh 9GLgRNWimqC7jpbtUzUuMq2rkmU+aXXH5D9tmLyZigd+3ZtqgONHgMZ8RoE493mf Mn4VYWeyzILOPLDNDxiSf4MkdgoO9yKBsCzAh8y8SZ+SHErN31GtT5wutd7rOeoz ErcpwcIQ1fXm85S2uQIUOHhzYMI2QfMYtFVl12y313LtIAyje+NCkRlKHSTGwXHE UI39a9W99bm9p5qLRq12Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeegjedgfeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefujghffffkfgggtgfgsehtqhdttddtreejnecuhfhrohhmpefuvggr nhcuhghhihhtthhonhcuoehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvg eqnecuggftrfgrthhtvghrnhepffefhfejudeguddtudekjeekueevvedvieeghfegleet uefhkeegkefhleejvddunecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrg hilhhfrhhomhepshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgv X-ME-Proxy: Feedback-ID: i23c04076:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 27 Sep 2022 20:49:43 -0400 (EDT) Original-Received: by melete.silentflame.com (Postfix, from userid 1000) id 270487E01ED; Tue, 27 Sep 2022 17:49:42 -0700 (MST) In-Reply-To: (Stefan Kangas's message of "Tue, 27 Sep 2022 12:15:29 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:243773 Archived-At: Hello, On Tue 27 Sep 2022 at 12:15PM -04, Stefan Kangas wrote: > Sean Whitton writes: > >>>> amend no. revert yes, but it=CA=BCs overkill for just a commit message= issue. You >>>> can always run 'make change-history' and fix it in the resulting >>>> ChangeLog file (see admin/notes/repo for the details) >>> >>> Please don't do that, it will make merging more tricky later. >> >> Hmm, so it's never okay to do that? Or is it to be saved for the more >> egregrious errors? > > It's easier for me (or whoever is charge of merging and/or releases) if > we don't do that, so I'd prefer it if we could reserve it for > particularly nasty mistakes. > > However, if it has to be done, please do it in two separate commits: one > that generates the ChangeLog and one that fixes the mistake. Thanks. I've updated admin/notes/repo with this information. --=20 Sean Whitton