From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Danny Freeman via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#59149: [SPAM UNSURE] Re: bug#59149: Feature Request: Report progress of long requests in Eglot Date: Fri, 25 Nov 2022 11:44:03 -0500 Message-ID: <87edtrx9ag.fsf@dfreeman.email> References: <87educqkar.fsf@dfreeman.email> <86cz9jmg9r.fsf@stephe-leake.org> <87k03qvmla.fsf@dfreeman.email> <86fseckwvb.fsf@stephe-leake.org> <87tu2pohub.fsf@dfreeman.email> <86ilj5k0sn.fsf@stephe-leake.org> <87wn7l316m.fsf@dfreeman.email> <86edtsk3xi.fsf@stephe-leake.org> <87o7swv3nx.fsf@gmail.com> <8635a8jb8e.fsf@stephe-leake.org> <87r0xrxb0i.fsf@dfreeman.email> <834junuhae.fsf@gnu.org> <87ilj3x9we.fsf@dfreeman.email> Reply-To: Danny Freeman Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15502"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 59149@debbugs.gnu.org, stephen_leake@stephe-leake.org, joaotavora@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Nov 25 17:57:27 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oyc11-0003oN-FJ for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 25 Nov 2022 17:57:27 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oyc0f-0002Bb-QV; Fri, 25 Nov 2022 11:57:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oyc0d-0002BI-1m for bug-gnu-emacs@gnu.org; Fri, 25 Nov 2022 11:57:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oyc0c-0000Tr-Hc for bug-gnu-emacs@gnu.org; Fri, 25 Nov 2022 11:57:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oyc0c-0007PI-7a for bug-gnu-emacs@gnu.org; Fri, 25 Nov 2022 11:57:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Danny Freeman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 25 Nov 2022 16:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59149 X-GNU-PR-Package: emacs Original-Received: via spool by 59149-submit@debbugs.gnu.org id=B59149.166939539128429 (code B ref 59149); Fri, 25 Nov 2022 16:57:02 +0000 Original-Received: (at 59149) by debbugs.gnu.org; 25 Nov 2022 16:56:31 +0000 Original-Received: from localhost ([127.0.0.1]:37050 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oyc07-0007OS-Ew for submit@debbugs.gnu.org; Fri, 25 Nov 2022 11:56:31 -0500 Original-Received: from out-36.mta0.migadu.com ([91.218.175.36]:34405) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oyc04-0007OJ-MX for 59149@debbugs.gnu.org; Fri, 25 Nov 2022 11:56:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dfreeman.email; s=key1; t=1669395387; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dEqS/Iv3uZS09lV5TzydkEkGzgV7Hl8sJ/3EliKZgbQ=; b=WS+xz6mqD4iTK0w7bILvC0UYnpeBOagvB61uh89ae4EBqtUI42sYtBuz4rdLHezKWMpQ7W ZfXzA3Srw9SmCGnnKg0gHfCCbVPGCJre/NTBfF9O4dhJ+MHhy9cYGF8u4tA2IiQl6wxERF 6yY015fHp9BtGNmIq1s5zbt+cXzCkPQ= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. In-reply-to: <87ilj3x9we.fsf@dfreeman.email> X-Migadu-Flow: FLOW_OUT X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:249021 Archived-At: I meant to reply to this and Eli's feedback in one email. > OK. Let's have Danny's opinion on it, especially on the name > 'eglot-report-progress'. In the simplest case, this variable is a > boolean, but I am curious if other types of progress reporting can be > envisioned. If they are, they should be controlled by the least amount > of user variables possible. I think a boolean will be sufficient, but I'm not sure how this will evolve in the future. >From the perspective of the LSP specification, there is only ONE type of progress message defined in the spec, and that is "Work Done Progress", which is what my patch supports. The spec does leave room for other usage of the progress message, including for "streaming of results", which I have never seen used in practice. >From the spec: https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#progress """ The base protocol offers also support to report progress in a generic fashion. This mechanism can be used to report any kind of progress including work done progress (usually used to report progress in the user interface using a progress bar) and partial result progress to support streaming of results. """ What kind of variable might allow Eglot to naturally evolve with this part of the spec? Maybe a list similar to `eglot-stay-out-of`? It may also help to keep in mind that some of these "Work Done Progress" requests can be canceled by the user. Later I think it would be nice to expose a command that would send the server a cancel request while one of these "progress" things is in flight. I'm not sure how that might affect a custom var here, but thought I would mention it. -- Danny Freeman