From: Philip Kaludercic <philipk@posteo.net>
To: Andrii Kolomoiets <andreyk.mad@gmail.com>
Cc: 59684@debbugs.gnu.org
Subject: bug#59684: 29.0.50; [PATCH] package.el: Insert news for installed packages only
Date: Tue, 29 Nov 2022 21:25:32 +0000 [thread overview]
Message-ID: <87edtlbghf.fsf@posteo.net> (raw)
In-Reply-To: <m2wn7dxy0f.fsf@gmail.com> (Andrii Kolomoiets's message of "Tue, 29 Nov 2022 23:16:00 +0200")
Andrii Kolomoiets <andreyk.mad@gmail.com> writes:
> Philip Kaludercic <philipk@posteo.net> writes:
>
>>> + ((file-regular-p file)))
>>
>> Shouldn't we keep `file-readable-p'?
>
> I think we should use `file-regular-p' so even if the pkg-dir will
> contain directory named "news" we will not try to insert it with
> `insert-file-contents'.
I agree that `file-regular-p' is sensible, what I meant was using
`file-readable-p' in addition to that. But I guess that all in all,
this is a rare circumstance...
next prev parent reply other threads:[~2022-11-29 21:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-29 16:54 bug#59684: 29.0.50; [PATCH] package.el: Insert news for installed packages only Andrii Kolomoiets
2022-11-29 21:06 ` Philip Kaludercic
2022-11-29 21:16 ` Andrii Kolomoiets
2022-11-29 21:25 ` Philip Kaludercic [this message]
2022-11-29 21:38 ` Andrii Kolomoiets
2022-11-30 19:53 ` Philip Kaludercic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87edtlbghf.fsf@posteo.net \
--to=philipk@posteo.net \
--cc=59684@debbugs.gnu.org \
--cc=andreyk.mad@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).