From: Augusto Stoffel <arstoffel@gmail.com>
To: "Mattias Engdegård" <mattiase@acm.org>
Cc: 59888@debbugs.gnu.org
Subject: bug#59888: [PATCH] Add 'grep-heading-mode'
Date: Thu, 08 Dec 2022 11:28:55 +0100 [thread overview]
Message-ID: <87edtadw9k.fsf@gmail.com> (raw)
In-Reply-To: <9DED6125-13ED-4BF6-83A1-E1B2C4249F24@acm.org> ("Mattias Engdegård"'s message of "Thu, 8 Dec 2022 10:57:59 +0100")
On Thu, 8 Dec 2022 at 10:57, Mattias Engdegård wrote:
> No argument about the idea (good to me) or implementation but minor points regarding the regexp:
>
>> + (group-n 1 (+? any))
>
> Very much prefer `nonl` or `not-newline` to `any`, which is only there for compatibility (shouldn't have been included in the first place).
Hum, not-newline is too long, so this leaves an option between the
slightly deceiving and the quite obscure.
Okay, now I see `any' is not even documented.
>> + (any "\0-:="))
>
> Is the range (ASCII 00..1A) intended here, or should that be a literal hyphen?
> If the former, it should probably be made more explicit since that
> range includes all sorts of numbers, symbols and control chars and it
> kind of looks like it may be a mistake.
The literal hyphen, which prefixes context lines in `grep -C <n>'.
Thanks for the heads up.
next prev parent reply other threads:[~2022-12-08 10:28 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-07 17:57 bug#59888: [PATCH] Add 'grep-heading-mode' Augusto Stoffel
2022-12-07 18:14 ` Eli Zaretskii
2022-12-08 8:59 ` Augusto Stoffel
2022-12-08 10:57 ` Eli Zaretskii
2022-12-08 0:19 ` Stefan Kangas
2022-12-08 9:06 ` Augusto Stoffel
2022-12-09 7:23 ` Juri Linkov
2022-12-09 11:58 ` Augusto Stoffel
2022-12-09 12:18 ` bug#59888: [PATCH] Add 'grep-use-headings' Augusto Stoffel
2022-12-09 19:36 ` Eli Zaretskii
2022-12-09 20:03 ` Augusto Stoffel
2022-12-09 20:29 ` Eli Zaretskii
2022-12-10 20:08 ` Augusto Stoffel
2022-12-10 20:16 ` Eli Zaretskii
2022-12-11 11:30 ` Augusto Stoffel
2022-12-15 8:05 ` Juri Linkov
2023-02-25 8:34 ` Augusto Stoffel
2023-02-25 18:00 ` Juri Linkov
2023-02-26 13:17 ` Robert Pluim
2023-02-26 15:07 ` Augusto Stoffel
2023-02-27 6:24 ` Robert Pluim
2023-02-27 11:26 ` Augusto Stoffel
2023-02-27 16:51 ` Robert Pluim
2023-02-27 18:53 ` Juri Linkov
2023-02-27 19:06 ` Augusto Stoffel
2023-02-27 19:15 ` Juri Linkov
2023-02-28 17:24 ` Juri Linkov
2023-02-28 18:17 ` Augusto Stoffel
2023-03-01 17:52 ` Juri Linkov
2022-12-09 20:40 ` Gregory Heytings
2022-12-10 17:24 ` Juri Linkov
2022-12-08 9:57 ` bug#59888: [PATCH] Add 'grep-heading-mode' Mattias Engdegård
2022-12-08 10:28 ` Augusto Stoffel [this message]
2022-12-08 10:48 ` Mattias Engdegård
2023-02-27 14:18 ` Mattias Engdegård
2022-12-09 7:28 ` Juri Linkov
2022-12-09 11:58 ` Augusto Stoffel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87edtadw9k.fsf@gmail.com \
--to=arstoffel@gmail.com \
--cc=59888@debbugs.gnu.org \
--cc=mattiase@acm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).