From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Theodor Thornhill via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#60197: 30.0.50; beginning-of-defun broken after new treesit impl Date: Mon, 19 Dec 2022 11:13:15 +0100 Message-ID: <87edsv7lc4.fsf@thornhill.no> Reply-To: Theodor Thornhill Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38569"; mail-complaints-to="usenet@ciao.gmane.io" Cc: casouri@gmail.com To: 60197@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Dec 19 11:14:39 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p7DAL-0009q0-UN for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 19 Dec 2022 11:14:38 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p7D9r-00010b-AL; Mon, 19 Dec 2022 05:14:07 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p7D9m-0000yH-H0 for bug-gnu-emacs@gnu.org; Mon, 19 Dec 2022 05:14:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p7D9m-0005Xu-7e for bug-gnu-emacs@gnu.org; Mon, 19 Dec 2022 05:14:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p7D9l-0003QY-O4; Mon, 19 Dec 2022 05:14:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Theodor Thornhill Original-Sender: "Debbugs-submit" Resent-CC: casouri@gmail.com, bug-gnu-emacs@gnu.org Resent-Date: Mon, 19 Dec 2022 10:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 60197 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org X-Debbugs-Original-Xcc: casouri@gmail.com Original-Received: via spool by submit@debbugs.gnu.org id=B.167144480313118 (code B ref -1); Mon, 19 Dec 2022 10:14:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 19 Dec 2022 10:13:23 +0000 Original-Received: from localhost ([127.0.0.1]:38172 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p7D99-0003PW-IF for submit@debbugs.gnu.org; Mon, 19 Dec 2022 05:13:23 -0500 Original-Received: from lists.gnu.org ([209.51.188.17]:38754) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p7D98-0003PQ-BA for submit@debbugs.gnu.org; Mon, 19 Dec 2022 05:13:22 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p7D97-0000AP-Ma for bug-gnu-emacs@gnu.org; Mon, 19 Dec 2022 05:13:22 -0500 Original-Received: from out-253.mta0.migadu.com ([91.218.175.253]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p7D95-0005Ue-PW for bug-gnu-emacs@gnu.org; Mon, 19 Dec 2022 05:13:21 -0500 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=key1; t=1671444797; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=CV1iXiFEVJFF/hfQ4IsYO9Ie4BDbwJ8l86kzcGboyJ8=; b=NGRV3msSlK5Syvj/W2LNKv6zZXmJC6MNa8jfPA47i0R/Hod70iwSNX1is54SsADz/MsKyH /FnK4m4sOJUvt2e/BXWnHaTUEigWSjBqONihNBh3Ois+NmJ0um6VT9V64iztPPfBA+9I3J nsb4PBYcyCHsK4sLmk86QnZPZPs2PjcuIohefdXbmDcT2rYcs0FgpraNkmPx3qZCq0KNeO iExM+ZLBhna/3DlHQMuT+BeI9axrl3z4Bl6pWkGeyd+CDkJw2Co1QhWAuxLQkC4rLpOohJ 2HgrNVOKooJOFl+bv6r8fw05Ulzi2JdvY58p8VWmObWJHEgqMxwtbgPFtyXr9g== X-Migadu-Flow: FLOW_OUT Received-SPF: pass client-ip=91.218.175.253; envelope-from=theo@thornhill.no; helo=out-253.mta0.migadu.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:251409 Archived-At: Hi, Yuan! It seems 'prog-fill-reindent-defun' is broken after the latest changes to treesit-beginning-of-defun. The culprit is that we now use remap instead of setting the beginning-of-defun-function. What is the reasoning behind that change? Can't we just rely on the variable beginning-of-defun-function? I see you mentioned it is inteded to be used as a command, but surely both should be possible? Theo