From: Robert Pluim <rpluim@gmail.com>
To: Sebastian Tennant <sdt@sebyte.me>
Cc: 61552@debbugs.gnu.org
Subject: bug#61552: Feature request: Add variable Man-prefer-synchronous-call
Date: Tue, 21 Feb 2023 11:44:14 +0100 [thread overview]
Message-ID: <87edqjmh6p.fsf@gmail.com> (raw)
In-Reply-To: <87edqkcim2.fsf@sebyte.me> (Sebastian Tennant's message of "Mon, 20 Feb 2023 18:11:17 +0000")
>>>>> On Mon, 20 Feb 2023 18:11:17 +0000, Sebastian Tennant <sdt@sebyte.me> said:
Sebastian> Quoth Basil Contovounesios <contovob@tcd.ie>
Sebastian> on Thu, 16 Feb 2023 17:09:27 +0000:
>> […]
>> Please attach the patches here so that they can be tracked in this
>> bugtracker.
>>
>> Thanks,
Sebastian> No problem Basil. Here's a patch against master:
Sebastian> From 179af66f885630a7bdf3d3f3146aceb8ad205ce6 Mon Sep 17 00:00:00 2001
Sebastian> From: Sebastian Tennant <sdt@sebyte.me>
Sebastian> Date: Thu, 10 Mar 2022 08:36:04 +0000
Sebastian> Subject: [PATCH] Add user-customizable variable Man-prefer-synchronous-call
Sebastian> * lisp/man.el (Man-getpage-in-background): Only call #'start-process
Sebastian> when 'make-process satisfies #'fboundp AND Man-prefer-synchronous-call
Sebastian> is bound to nil.
Your commit message should indicate that youʼve added a new defcustom,
and you should announce it in etc/NEWS (and add a description to the
manual, if that makes sense)
Sebastian> ---
Sebastian> lisp/man.el | 9 ++++++++-
Sebastian> 1 file changed, 8 insertions(+), 1 deletion(-)
Sebastian> diff --git a/lisp/man.el b/lisp/man.el
Sebastian> index 286edf9314e..fb4f8f02db7 100644
Sebastian> --- a/lisp/man.el
Sebastian> +++ b/lisp/man.el
Sebastian> @@ -97,6 +97,12 @@ man
Sebastian> :group 'external
Sebastian> :group 'help)
Sebastian> +(defcustom Man-prefer-synchronous-call nil
Sebastian> + "Non-nil means always call the Un*x man command synchronously,
Sebastian> +rather than asynchronously, which is the default
Sebastian> behaviour."
The first line should be a complete sentence. Something like
"Whether to call the Un*x 'manʼ command synchronously."
Sebastian> + :type 'boolean
Sebastian> + :group 'man)
This needs a :version tag
Sebastian> +
Sebastian> (defcustom Man-filter-list nil
Sebastian> "Manpage cleaning filter command phrases.
Sebastian> This variable contains a list of the following form:
Sebastian> @@ -1118,7 +1124,8 @@ Man-getpage-in-background
Sebastian> "[cleaning...]")
Sebastian> 'face 'mode-line-emphasis)))
Sebastian> (Man-start-calling
Sebastian> - (if (fboundp 'make-process)
Sebastian> + (if (and (fboundp 'make-process)
Sebastian> + (not Man-prefer-synchronous-call))
Sebastian> (let ((proc (start-process
Sebastian> manual-program buffer
Sebastian> (if (memq system-type '(cygwin windows-nt))
Sebastian> --
Sebastian> 2.30.2
Robert
--
next prev parent reply other threads:[~2023-02-21 10:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-16 16:12 bug#61552: Feature request: Add variable Man-prefer-synchronous-call Sebastian Tennant
2023-02-16 17:09 ` Basil Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-02-20 18:11 ` Sebastian Tennant
2023-02-21 10:44 ` Robert Pluim [this message]
2023-02-21 14:08 ` Sebastian Tennant
2023-02-21 14:47 ` Robert Pluim
2023-02-22 17:16 ` Sebastian Tennant
2023-03-02 11:30 ` Eli Zaretskii
2023-03-03 8:51 ` Sebastian Tennant
2023-03-03 11:23 ` Eli Zaretskii
2023-02-21 9:53 ` Stefan Kangas
2023-02-21 12:16 ` Sebastian Tennant
2023-02-21 12:28 ` Sebastian Tennant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87edqjmh6p.fsf@gmail.com \
--to=rpluim@gmail.com \
--cc=61552@debbugs.gnu.org \
--cc=sdt@sebyte.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).