From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Augusto Stoffel Newsgroups: gmane.emacs.bugs Subject: bug#61785: [PATCH] Add option to keep some columns in dired-hide-details-mode Date: Sat, 04 Mar 2023 12:26:36 +0100 Message-ID: <87edq4pxjn.fsf@gmail.com> References: <87sfeu3ruh.fsf@gmail.com> <83bklbe4wa.fsf@gnu.org> <871qm5t5h5.fsf@gmail.com> <838rgdar53.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9704"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 61785-done@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Mar 04 12:27:17 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pYQ2m-0002Mz-HB for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 04 Mar 2023 12:27:16 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pYQ2e-0003Vh-4c; Sat, 04 Mar 2023 06:27:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pYQ2Z-0003V1-2A for bug-gnu-emacs@gnu.org; Sat, 04 Mar 2023 06:27:05 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pYQ2Y-0004Jt-KO for bug-gnu-emacs@gnu.org; Sat, 04 Mar 2023 06:27:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pYQ2Y-0000OA-Fv for bug-gnu-emacs@gnu.org; Sat, 04 Mar 2023 06:27:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Augusto Stoffel Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 04 Mar 2023 11:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61785 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 61785-done@debbugs.gnu.org id=D61785.16779292071470 (code D ref 61785); Sat, 04 Mar 2023 11:27:02 +0000 Original-Received: (at 61785-done) by debbugs.gnu.org; 4 Mar 2023 11:26:47 +0000 Original-Received: from localhost ([127.0.0.1]:35306 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pYQ2J-0000Ne-5W for submit@debbugs.gnu.org; Sat, 04 Mar 2023 06:26:47 -0500 Original-Received: from mail-ed1-f47.google.com ([209.85.208.47]:47040) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pYQ2H-0000NN-4A for 61785-done@debbugs.gnu.org; Sat, 04 Mar 2023 06:26:45 -0500 Original-Received: by mail-ed1-f47.google.com with SMTP id o15so19955659edr.13 for <61785-done@debbugs.gnu.org>; Sat, 04 Mar 2023 03:26:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1677929198; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=ZgNEojp8Hl5XyYQrGeAsZUE8d6bDw2fjL6h984B70iU=; b=BdVr39GPM8jWMc/4z7tjZGSFu9bhNSWzqrpm07AqbW0jIzOYhQEUjDNpL32RLK1xvy SZuwE9sStBdywCItneGW6BmTeigmdfEEM7VZw9vt1o8y2KytwKQXI3f5LD7w5gCAipDi B9E+1NPLYfeoEU+a7xyiYyz9OLAz4WMCq2i9UZOPGocaNR5u1hUe0oG6u0HUKi4+x/C0 cLrrknnxVmx0T+e3SKqiT6/aZ2l2TDe7e0s0G8oImkWWc3Oc8YGrbvtW6eJSrHZU/XC5 jl2ytwvhEffym5OaqkofWay1+ch9U+6tirQpZ7bx8TS/EU9stn7ztcEweC7quvey27Om ebZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1677929198; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ZgNEojp8Hl5XyYQrGeAsZUE8d6bDw2fjL6h984B70iU=; b=T772cLTGm6OhyBo+y1h1hDm0ADWQqnLaVeRR0JYIcaDELlwrvzDMxI0zOaEk5m5enF gZDpxY4yUixr3tPSD+PDc1kkISDd8DhIAyC2IUPLFvv6VlS3lDuAZnbv431zCEbkCNfk 1PCtsSCY3mhT2Fmf3JH0UH7l9mT8cGnCOGa3JoylVOuF6EXVmU7DM0Xq8FxcD07j+4oJ N6zAUthzTagdFarsX8fsHFZbrpooDzde/A5gtMBPQgGXeCsH6H/GF8yiyv7m+TziUHMa bdjC9bf44zKyuVYhY9QuwxKajwKy0PfhDrl3sFlku4eHrI/TsuPc1CT3d/uzyrAZ83fv 2/1w== X-Gm-Message-State: AO0yUKXEExQ1DfcCJ6pl9SQ1qNhfSJgzDCeWtA+6SVpgkT/zvcr8V1Mw Q/gOJ0kxfH+hTGWm3l3RbODc19+yZ+o= X-Google-Smtp-Source: AK7set/DHP5CQqm5Q0ZlijV4mK+cTBTqYS+g/8kCSLwnTVh5qzl98OpfPbjzt3NCRCrQBu0+CgfBiQ== X-Received: by 2002:a17:906:af18:b0:8aa:c155:9233 with SMTP id lx24-20020a170906af1800b008aac1559233mr4893168ejb.26.1677929198465; Sat, 04 Mar 2023 03:26:38 -0800 (PST) Original-Received: from ars3 ([2a02:8109:8ac0:56d0::8b3a]) by smtp.gmail.com with ESMTPSA id gq11-20020a170906e24b00b008dd2db45c0bsm1973390ejb.105.2023.03.04.03.26.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 04 Mar 2023 03:26:37 -0800 (PST) In-Reply-To: <838rgdar53.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 04 Mar 2023 09:54:00 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:257268 Archived-At: On Sat, 4 Mar 2023 at 09:54, Eli Zaretskii wrote: >> From: Augusto Stoffel >> Cc: 61785-done@debbugs.gnu.org >> Date: Sat, 04 Mar 2023 07:07:02 +0100 >> >> I think I would rather revert the commit until someone comes up with a >> better idea, if you don't mind. > > I'm not sure I see a problem with counting columns. > > What is the harm of keeping the commit on master? If we get > complaints about it, we have ample time to remove the feature when and > if we get those complaints. The problem is that the code asssumes the columns are right-aligned, which is not true for user and group. So for instance this listing: drwx------. 43 augusto augusto 69632 Mar 4 12:21 . drwxr-xr-x. 4 root root 4096 Aug 9 2022 .. drwx------. 171 augusto augusto 12288 Feb 27 11:52 .cache will get abridged like this: 69632 Mar 4 12:21 . 4096 Aug 9 2022 .. 12288 Feb 27 11:52 .cache But if you don't mind that, we can keep the code and see if someone finds a nice way to deal with it.