unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Ihor Radchenko <yantar92@posteo.net>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 62780@debbugs.gnu.org
Subject: bug#62780: 30.0.50; Redisplay gets slow when using Org tables + show-trailing-whitespace
Date: Wed, 12 Apr 2023 07:39:37 +0000	[thread overview]
Message-ID: <87edop8s7a.fsf@localhost> (raw)
In-Reply-To: <83bkjt8t4l.fsf@gnu.org>

Eli Zaretskii <eliz@gnu.org> writes:

>> Maybe there is a better way?
>
> Maybe.  Can you point me to the discussion which caused you to use
> these display properties there?  I think this was done in two steps:
> first you added the same display property as pre and post, then made
> them subtly different; I need to re-read the discussions that led to
> both of these.

The first step was in
https://lists.gnu.org/archive/html/emacs-orgmode/2017-12/msg00526.html

Then, we had an issue with empty cells |<spc><spc>| with Emacs joining
two spaces with eq text properties.
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=45915

>> No, I do not mean a regression. But the slowdown appears to be
>> unreasonable for such a small test case. What is the point having
>> `show-trailing-whitespace' if it is this much inefficient? Maybe a
>> simple font-lock rule can be better?
>
> See above: show-trailing-whitespace is not the main culprit here;
> these particular display properties are.  If you could produce a perf
> profile with this recipe, it might give ideas for speeding up the C
> code without any changes on the Lisp level.

Ok. I will look into it. If we can speed this up, it will hopefully
benefit more than just this particular scenario.

> Btw, these properties were introduced into org-table.el some time ago,
> so how come this issue comes up only now?  Aren't Org tables used
> quite a lot?

I guess things are not that much obvious without show-trailing-whitespace.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>





  reply	other threads:[~2023-04-12  7:39 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-11 18:52 bug#62780: 30.0.50; Redisplay gets slow when using Org tables + show-trailing-whitespace Ihor Radchenko
2023-04-11 19:25 ` Eli Zaretskii
2023-04-11 19:41   ` Ihor Radchenko
2023-04-12  7:19     ` Eli Zaretskii
2023-04-12  7:39       ` Ihor Radchenko [this message]
2023-04-12  7:58         ` Eli Zaretskii
2023-04-13  9:46       ` Ihor Radchenko
2023-04-13 10:45         ` Eli Zaretskii
2023-04-13 11:15           ` Ihor Radchenko
2023-04-13 14:33             ` Eli Zaretskii
2023-04-14  9:20               ` Ihor Radchenko
2023-04-14 10:37                 ` Eli Zaretskii
2023-04-14 11:36                   ` Ihor Radchenko
2023-04-14 12:06                     ` Eli Zaretskii
2023-04-14 12:23                       ` Eli Zaretskii
2023-04-14 12:52                         ` Ihor Radchenko
2023-04-14 13:51                           ` Eli Zaretskii
2023-04-14 13:56                             ` Ihor Radchenko
2023-04-14 14:47                               ` Eli Zaretskii
2023-04-14 14:56                                 ` Ihor Radchenko
2023-04-14 15:06                                   ` Eli Zaretskii
2023-04-14 15:23                                     ` Ihor Radchenko
2023-04-14 12:28                       ` Ihor Radchenko
2023-04-29  8:57                         ` Eli Zaretskii
2023-04-29 18:03                           ` Ihor Radchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87edop8s7a.fsf@localhost \
    --to=yantar92@posteo.net \
    --cc=62780@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).