From: Joseph Turner via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: 63671@debbugs.gnu.org
Subject: bug#63671: Add function to test equality of hash tables
Date: Tue, 23 May 2023 12:32:08 -0700 [thread overview]
Message-ID: <87edn6bzvz.fsf@breatheoutbreathe.in> (raw)
Hello!
Would y'all be open to adding something like this?
(defun hash-equal (hash1 hash2)
"Return non-nil when the contents of HASH1 and HASH2 are equal.
Table values are compared using `equal' unless they are both hash
tables themselves, in which case `hash-equal' is used.
Does not compare equality predicates."
(and (= (hash-table-count hash1)
(hash-table-count hash2))
(catch 'flag (maphash (lambda (key hash1-value)
(let ((hash2-value (gethash key hash2)))
(or (if (and (hash-table-p hash1-value)
(hash-table-p hash2-value))
(hash-equal hash1-value hash2-value)
(equal hash1-value hash2-value))
(throw 'flag nil))))
hash1)
t)))
Rudimentary test:
(let ((hash1 (make-hash-table))
(hash2 (make-hash-table))
(hash3 (make-hash-table))
(hash4 (make-hash-table)))
(puthash 'foo "foo" hash1)
(puthash 'foo "foo" hash2)
(puthash 'bar "foo" hash3)
(puthash 'bar "foo" hash4)
(puthash 'baz hash3 hash1)
(puthash 'baz hash4 hash2)
(hash-equal hash1 hash2))
We could use hash-table-test to compare predicates, perhaps
dependent on the presence of a 'compare-tests flag?
Best,
Joseph
next reply other threads:[~2023-05-23 19:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-23 19:32 Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2023-05-24 9:27 ` bug#63671: Add function to test equality of hash tables Mattias Engdegård
2023-05-24 17:27 ` Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-05-24 20:01 ` Ihor Radchenko
2023-05-24 20:34 ` Mattias Engdegård
2023-05-25 2:44 ` Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-05-25 6:31 ` Ihor Radchenko
2023-05-25 7:22 ` Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-05-25 7:22 ` Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-05-25 8:18 ` Mattias Engdegård
2023-09-11 18:39 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87edn6bzvz.fsf@breatheoutbreathe.in \
--to=bug-gnu-emacs@gnu.org \
--cc=63671@debbugs.gnu.org \
--cc=joseph@breatheoutbreathe.in \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).