* bug#66405: 30.0.50; Should comint-mode call hack-dir-local-variables-non-file-buffer?
@ 2023-10-08 10:16 Augusto Stoffel
2023-10-08 10:27 ` Eli Zaretskii
0 siblings, 1 reply; 4+ messages in thread
From: Augusto Stoffel @ 2023-10-08 10:16 UTC (permalink / raw)
To: 66405
It currently doesn't but I think it should, since a comint is
conceptually tied to the current directory.
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#66405: 30.0.50; Should comint-mode call hack-dir-local-variables-non-file-buffer?
2023-10-08 10:16 bug#66405: 30.0.50; Should comint-mode call hack-dir-local-variables-non-file-buffer? Augusto Stoffel
@ 2023-10-08 10:27 ` Eli Zaretskii
2023-10-08 11:03 ` Augusto Stoffel
0 siblings, 1 reply; 4+ messages in thread
From: Eli Zaretskii @ 2023-10-08 10:27 UTC (permalink / raw)
To: Augusto Stoffel; +Cc: 66405
> From: Augusto Stoffel <arstoffel@gmail.com>
> Date: Sun, 08 Oct 2023 12:16:07 +0200
>
> It currently doesn't but I think it should, since a comint is
> conceptually tied to the current directory.
Is there a compelling reason why it should (as opposed to a "why not"
kind of reason)? Comint exists for many years, so any change in
behavior there should have a very good reason.
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#66405: 30.0.50; Should comint-mode call hack-dir-local-variables-non-file-buffer?
2023-10-08 10:27 ` Eli Zaretskii
@ 2023-10-08 11:03 ` Augusto Stoffel
2023-10-08 11:42 ` Eli Zaretskii
0 siblings, 1 reply; 4+ messages in thread
From: Augusto Stoffel @ 2023-10-08 11:03 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: 66405
On Sun, 8 Oct 2023 at 13:27, Eli Zaretskii wrote:
>> From: Augusto Stoffel <arstoffel@gmail.com>
>> Date: Sun, 08 Oct 2023 12:16:07 +0200
>>
>> It currently doesn't but I think it should, since a comint is
>> conceptually tied to the current directory.
>
> Is there a compelling reason why it should (as opposed to a "why not"
> kind of reason)? Comint exists for many years, so any change in
> behavior there should have a very good reason.
Yes. We've been improving the editing experience in Comint with input
fontification and what not, so I think it should also have the right
project settings. Indentation settings would be one example. Also,
documentation lookup settings often go in the .dir-locals.el and are
relevant in a comint as well.
For me personally, it would also make
https://elpa.gnu.org/packages/buffer-env.html work more smoothly.
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#66405: 30.0.50; Should comint-mode call hack-dir-local-variables-non-file-buffer?
2023-10-08 11:03 ` Augusto Stoffel
@ 2023-10-08 11:42 ` Eli Zaretskii
0 siblings, 0 replies; 4+ messages in thread
From: Eli Zaretskii @ 2023-10-08 11:42 UTC (permalink / raw)
To: Augusto Stoffel; +Cc: 66405
> From: Augusto Stoffel <arstoffel@gmail.com>
> Cc: 66405@debbugs.gnu.org
> Date: Sun, 08 Oct 2023 13:03:31 +0200
>
> On Sun, 8 Oct 2023 at 13:27, Eli Zaretskii wrote:
>
> >> From: Augusto Stoffel <arstoffel@gmail.com>
> >> Date: Sun, 08 Oct 2023 12:16:07 +0200
> >>
> >> It currently doesn't but I think it should, since a comint is
> >> conceptually tied to the current directory.
> >
> > Is there a compelling reason why it should (as opposed to a "why not"
> > kind of reason)? Comint exists for many years, so any change in
> > behavior there should have a very good reason.
>
> Yes. We've been improving the editing experience in Comint with input
> fontification and what not, so I think it should also have the right
> project settings. Indentation settings would be one example. Also,
> documentation lookup settings often go in the .dir-locals.el and are
> relevant in a comint as well.
>
> For me personally, it would also make
> https://elpa.gnu.org/packages/buffer-env.html work more smoothly.
So what's our plan for when this happens to break something?
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-10-08 11:42 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-08 10:16 bug#66405: 30.0.50; Should comint-mode call hack-dir-local-variables-non-file-buffer? Augusto Stoffel
2023-10-08 10:27 ` Eli Zaretskii
2023-10-08 11:03 ` Augusto Stoffel
2023-10-08 11:42 ` Eli Zaretskii
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).