From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Manuel Giraud via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#66697: 30.0.50; [PATCH] desktop-save-mode with expiring remote buffers Date: Mon, 23 Oct 2023 16:55:58 +0200 Message-ID: <87edhls801.fsf@ledu-giraud.fr> References: <875y2xelsk.fsf@ledu-giraud.fr> <83o7gpo9bm.fsf@gnu.org> <87pm15h605.fsf@ledu-giraud.fr> <83jzrdo68n.fsf@gnu.org> <87lebth4zi.fsf@ledu-giraud.fr> <83a5s9o1wa.fsf@gnu.org> Reply-To: Manuel Giraud Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2098"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 66697@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Oct 23 16:56:52 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1quwMN-0000Hu-S0 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 23 Oct 2023 16:56:51 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1quwMC-0006mg-AV; Mon, 23 Oct 2023 10:56:40 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1quwM9-0006mH-Kz for bug-gnu-emacs@gnu.org; Mon, 23 Oct 2023 10:56:37 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1quwM6-0003dp-4j for bug-gnu-emacs@gnu.org; Mon, 23 Oct 2023 10:56:34 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1quwMY-0006Gv-FE for bug-gnu-emacs@gnu.org; Mon, 23 Oct 2023 10:57:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Manuel Giraud Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 23 Oct 2023 14:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66697 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 66697-submit@debbugs.gnu.org id=B66697.169807299324069 (code B ref 66697); Mon, 23 Oct 2023 14:57:02 +0000 Original-Received: (at 66697) by debbugs.gnu.org; 23 Oct 2023 14:56:33 +0000 Original-Received: from localhost ([127.0.0.1]:51324 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1quwM5-0006G8-3L for submit@debbugs.gnu.org; Mon, 23 Oct 2023 10:56:33 -0400 Original-Received: from ledu-giraud.fr ([51.159.28.247]:36473) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1quwM2-0006Fz-03 for 66697@debbugs.gnu.org; Mon, 23 Oct 2023 10:56:31 -0400 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=+28ZQfON j0uRMwJJBmvXtzRK3QUaQaQfgw0QKJ2ogoc=; h=date:references:in-reply-to: subject:cc:to:from; d=ledu-giraud.fr; b=vllCuvBdd4B8fLt29wYzHIaEtU9mlf dxgwi+Hal80143l901GS80yUOZSc05n//R9yV7orgqWlb6LQKNqkLuDg== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=+28ZQfONj0uRMwJJ BmvXtzRK3QUaQaQfgw0QKJ2ogoc=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=wj8Vko/5fQGLyZPxHloSdnmtmt4Oha3F6hR/go Ii30VScFbz/MLPbzg+LyVvw37EKQLLBYU6dEHQGlb6I5nE7utVli5SVZjVBSHdeBUjWhYx pOB/bq7TWlphUsZwG7x77/9SBGFIvF5jWEwSqBXf1AjDEWG0VTk5lAlIHWpa/WcB6l0n8J wNB41/fiE1LnTTJsGhHYsojdHOnPdZXNJIP/7QJ7Knbjzz+uk5Cg7UPNs+fX4fY7j8aHf7 LlFsNmDX0HgdT/zXhn2x2x9eKIk+4Eketo/saRQOXdHrYVfTqAXC59DtQxI04zsBdwMFn8 zbiRQhSa8mgaunnkdpeq3pwA== Original-Received: from computer ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id 66665fc6 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Mon, 23 Oct 2023 16:55:59 +0200 (CEST) In-Reply-To: <83a5s9o1wa.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 23 Oct 2023 17:21:25 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:273024 Archived-At: Eli Zaretskii writes: [...] > Doesn't this tell that the problem is in dired.el, not in desktop.el? > The problematic call comes from dired-desktop-buffer-misc-data, not > from desktop.el. So it's dired-desktop-buffer-misc-data that needs to > be fixed. Ok, I'll investigate here then. > Alternatively, we could refrain calling desktop-buffer-info on buffers > for which desktop-save-buffer-p returns nil. That was kind of what my patch does=E2=80=A6 but it creates new issues beca= use 'desktop-save-buffer-p' handles many test cases against file-name, buffer-name and mode. And file-name, buffer-name and mode are all retrieved into 'desktop-buffer-info'. --=20 Manuel Giraud