From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ihor Radchenko Newsgroups: gmane.emacs.bugs Subject: bug#66117: 30.0.50; `find-buffer-visiting' is slow when opening large number of buffers Date: Tue, 19 Dec 2023 13:24:12 +0000 Message-ID: <87edfipbpf.fsf@localhost> References: <878r919qfh.fsf@localhost> <87o7esq319.fsf@localhost> <83bkasrb3f.fsf@gnu.org> <83wmtgpuyf.fsf@gnu.org> <871qboprh3.fsf@localhost> <87y1dwobey.fsf@localhost> <878r5v20gu.fsf@localhost> <83bkapl5zh.fsf@gnu.org> <83zfy9jkoh.fsf@gnu.org> <878r5tglwp.fsf@localhost> <83ttohjet0.fsf@gnu.org> <83sf41jed7.fsf@gnu.org> <87y1dtyu4y.fsf@localhost> <83plz5jdgj.fsf@gnu.org> <87v88xyt2a.fsf@localhost> <83o7epjaon.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29521"; mail-complaints-to="usenet@ciao.gmane.io" Cc: dmitry@gutov.dev, 66117@debbugs.gnu.org, mattias.engdegard@gmail.com, monnier@iro.umontreal.ca To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Dec 19 14:22:13 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rFa32-0007Y5-RH for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 19 Dec 2023 14:22:12 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rFa2q-00008F-Ld; Tue, 19 Dec 2023 08:22:00 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rFa2p-00007q-EO for bug-gnu-emacs@gnu.org; Tue, 19 Dec 2023 08:21:59 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rFa2p-0004A5-5W for bug-gnu-emacs@gnu.org; Tue, 19 Dec 2023 08:21:59 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rFa2r-0003OK-MI for bug-gnu-emacs@gnu.org; Tue, 19 Dec 2023 08:22:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Ihor Radchenko Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 19 Dec 2023 13:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66117 X-GNU-PR-Package: emacs Original-Received: via spool by 66117-submit@debbugs.gnu.org id=B66117.170299207612977 (code B ref 66117); Tue, 19 Dec 2023 13:22:01 +0000 Original-Received: (at 66117) by debbugs.gnu.org; 19 Dec 2023 13:21:16 +0000 Original-Received: from localhost ([127.0.0.1]:34613 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rFa28-0003ND-2x for submit@debbugs.gnu.org; Tue, 19 Dec 2023 08:21:16 -0500 Original-Received: from mout01.posteo.de ([185.67.36.65]:44567) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rFa25-0003My-AE for 66117@debbugs.gnu.org; Tue, 19 Dec 2023 08:21:14 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 97995240029 for <66117@debbugs.gnu.org>; Tue, 19 Dec 2023 14:21:04 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1702992064; bh=nWW2i0ldyeh9RmJZlsu/3ylKZi/OwlN8g+QDzdBK9LU=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:From; b=E/VGl8MWvwxxu+ysIzd/Wh1nBLjhL13ME+PuhsP3u9NFO7Vr9t0QjolMmtCA2rvd2 mOhO9DDuFtJJqBvQNlBtWPuaUIqLyYOkufOWpCKXSMxY2csME4w1MsSCnamaupN6Lh iPullP3l4EXFmAXVOmesFlZGub4OZamPcjAYsgWh0IZf4ZfjjBw9p7IoGF6qPme+LD VB8YtKKg6lx++KHUQZ6JiljqyMwDvFsujnXqxjEiY9syFsJXLOaiX+ifgH2yBvzQxC FNP//1t84Zzc64Fj+eZ+ILQzW1RVHPUAtNLzQjOZwwJlSnQQS5QFR3OruLumJ+TZxb 8d8Ups9ILBYyA== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4SvclM0DSWz6tyj; Tue, 19 Dec 2023 14:21:02 +0100 (CET) In-Reply-To: <83o7epjaon.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:276514 Archived-At: Eli Zaretskii writes: >> > I'm talking specifically about any changes from previous behavior >> > visible from Lisp. I think we should test all of the following: >> > >> > default-value >> > default-boundp >> > setq-default >> > default-toplevel-value >> > set-default-toplevel-value >> > >> > and make sure they all behave exactly the same, both in and out of a >> > let-binding. >> >> The patch did not introduce test failures for make check on my side. Are >> there existing tests for buffer-locals? Or do we need to add them? > > I don't see any such tests. So yes, it would be good to add them. > But at the very least we should consider all of the above > theoretically and see if any of them are expected/supposed to change > as result of this. Do you still think that we need to discuss special cases further, after Stefan's reply? If yes, I will need help with various edge cases, because I am not really sure about them. For example, I have no clue if below is expected (defvar test/foo 'value) (default-boundp 'test/foo) (default-value 'test/foo) ;; -> value (let ((test/foo t)) (default-value 'test/foo)) ;; -> t ??? (defvar-local test/foo2 'value) (default-boundp 'test/foo2) ;; -> t (default-value 'test/foo2) ;; -> value (let ((test/foo2 t)) (default-value 'test/foo2)) ;; -> t ??? (setq-default test/foo2 'value2) (default-boundp 'test/foo2) ;; -> t (default-value 'test/foo2) ;; -> value2 (let ((test/foo2 t)) (default-value 'test/foo2)) ;; -> t ??? -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at