bug#67683: 30.0.50; [PATCH] Fix 'M-.' on Emacs C sources

bug#67683: 30.0.50; [PATCH] Fix 'M-.' on Emacs C sources

[Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors]

[-- Attachment #1: Type: text/plain, Size: 237 bytes --]


Hi,

I don't know how but for some times now 'M-.' is broken for me on C
sources.  The attach patch seems reasonable and fixes this issue.  I
guess that the title of this patch should be reworked but I don't really
know how to put it.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Fix-M-.-on-Emacs-C-sources.patch --]
[-- Type: text/x-patch, Size: 1110 bytes --]

From 1059d89317364943b85e6cc043b0e5285734e000 Mon Sep 17 00:00:00 2001
From: Manuel Giraud <manuel@ledu-giraud.fr>
Date: Thu, 7 Dec 2023 10:44:39 +0100
Subject: [PATCH] Fix 'M-.' on Emacs C sources

* lisp/progmodes/etags.el (tags-included-tables): Ensure that
'tags-included-tables-function' is a function.
---
 lisp/progmodes/etags.el | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lisp/progmodes/etags.el b/lisp/progmodes/etags.el
index d48dcc6659d..c2fcbaee91f 100644
--- a/lisp/progmodes/etags.el
+++ b/lisp/progmodes/etags.el
@@ -773,7 +773,8 @@ tags-included-tables
   "Return a list of tags tables included by the current table.
 Assumes the tags table is the current buffer."
   (or tags-included-tables
-      (setq tags-included-tables (funcall tags-included-tables-function))))
+      (setq tags-included-tables (and (functionp tags-included-tables-function)
+                                      (funcall tags-included-tables-function)))))
 \f
 (defun tags-completion-table (&optional buf)
   "Build `tags-completion-table' on demand for a buffer's tags tables.
-- 
2.43.0


[-- Attachment #3: Type: text/plain, Size: 7861 bytes --]



In GNU Emacs 30.0.50 (build 1, x86_64-unknown-openbsd7.4) of 2023-12-06
 built on computer
Repository revision: d8a00879309a3bf62f6ffcae103aa3bdba776ee9
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12101009
System Description: OpenBSD computer 7.4 GENERIC.MP#1471 amd64

Configured using:
 'configure CPPFLAGS=-I/usr/local/include LDFLAGS=-L/usr/local/lib
 MAKEINFO=gmakeinfo --prefix=/home/manuel/emacs
 --bindir=/home/manuel/bin --with-x-toolkit=no --without-cairo
 --without-dbus --without-gconf --without-gsettings --without-sound
 --without-compress-install'

Configured features:
FREETYPE GIF GLIB GMP GNUTLS HARFBUZZ JPEG JSON LCMS2 LIBOTF LIBXML2
MODULES NOTIFY KQUEUE OLDXMENU PDUMPER PNG RSVG SQLITE3 THREADS TIFF
TREE_SITTER WEBP X11 XDBE XFT XIM XINPUT2 XPM ZLIB

Important settings:
  value of $LC_CTYPE: en_US.UTF-8
  locale-coding-system: utf-8-unix

Major mode: VC dir

Minor modes in effect:
  gdb-many-windows: t
  vc-dir-git-mode: t
  display-time-mode: t
  display-battery-mode: t
  desktop-save-mode: t
  server-mode: t
  override-global-mode: t
  repeat-mode: t
  global-eldoc-mode: t
  show-paren-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  minibuffer-regexp-mode: t
  buffer-read-only: t
  line-number-mode: t
  indent-tabs-mode: t
  transient-mark-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t

Load-path shadows:
/home/manuel/.emacs.d/elpa/ef-themes-1.4.0/theme-loaddefs hides /home/manuel/emacs/share/emacs/30.0.50/lisp/theme-loaddefs

Features:
(shadow emacsbug pcmpl-git log-edit gnus-search mouse-copy mouse-drag
emacs-news-mode ibuf-ext ibuffer ibuffer-loaddefs tramp-cmds tramp-cache
time-stamp tramp-sh pcmpl-linux flow-fill mailalias smtpmail sort
gnus-cite shr-color mail-extr textsec uni-scripts idna-mapping
ucs-normalize uni-confusable textsec-check gnus-async gnus-bcklg gnus-ml
gnus-topic mm-archive url-cache qp utf-7 imap rfc2104 nndoc nndraft nnmh
network-stream nnfolder nnml gnus-agent gnus-srvr gnus-score score-mode
nnvirtual nntp gnus-cache nnrss vc-bzr vc-src vc-sccs vc-svn shortdoc
comp-common pcmpl-unix cal-china lunar solar cal-dst cal-bahai cal-islam
cal-hebrew holidays holiday-loaddefs cal-iso face-remap magit-utils
dabbrev display-line-numbers smerge-mode diff whitespace add-log
vc-annotate gdb-mi bindat gud find-dired ffap tabify man cl-print dash
help-fns radix-tree pulse misearch multi-isearch org-duration org-agenda
make-mode css-mode imenu view vc-cvs vc-rcs log-view pcvs-util texinfo
texinfo-loaddefs conf-mode rng-xsd xsd-regexp rng-cmpct rng-nxml
rng-valid rng-loc rng-uri rng-parse nxml-parse rng-match rng-dt rng-util
rng-pttrn nxml-ns nxml-mode nxml-outln nxml-rap sgml-mode facemenu
nxml-util nxml-enc xmltok pascal vc-hg vc-dir ewoc sh-script smie
treesit executable mule-util on-screen paredit gnus-dired autorevert
vc-git diff-mode vc vc-dispatcher bug-reference org-indent oc-basic
org-element org-persist org-id avl-tree ol-eww eww url-queue mm-url
ol-rmail ol-mhe ol-irc ol-info ol-gnus nnselect ol-docview doc-view
filenotify jka-compr image-mode exif ol-bibtex bibtex ol-bbdb ol-w3m
ol-doi org-link-doi gnus-icalendar org-capture org-refile org ob
ob-tangle ob-ref ob-lob ob-table ob-exp org-macro org-src ob-comint
org-pcomplete org-list org-footnote org-faces org-entities ob-emacs-lisp
ob-core ob-eval org-cycle org-table ol org-fold org-fold-core org-keys
oc org-loaddefs org-version org-compat org-macs time battery cus-load
desktop frameset exwm-randr xcb-randr exwm-config ido exwm exwm-input
xcb-keysyms xcb-xkb exwm-manage exwm-floating xcb-cursor xcb-render
exwm-layout exwm-workspace exwm-core xcb-ewmh xcb-icccm xcb xcb-xproto
xcb-types xcb-debug server modus-operandi-theme modus-themes zone
speed-type url-http url-auth url-gw nsm compat ytdious mingus libmpdee
reporter edebug debug backtrace transmission color calc-bin calc-ext
calc calc-loaddefs rect calc-macs supercite regi ebdb-message ebdb-gnus
gnus-msg gnus-art mm-uu mml2015 mm-view mml-smime smime gnutls dig
gnus-sum shr pixel-fill kinsoku url-file svg dom gnus-group gnus-undo
gnus-start gnus-dbus gnus-cloud nnimap nnmail mail-source utf7 nnoo
gnus-spec gnus-int gnus-range message sendmail yank-media puny rfc822
mml mml-sec epa epg rfc6068 epg-config mm-decode mm-bodies mm-encode
mail-parse rfc2231 rfc2047 rfc2045 ietf-drums gmm-utils mailheader
gnus-win ebdb-mua ebdb-com crm ebdb-format ebdb mailabbrev eieio-opt
speedbar ezimage dframe find-func eieio-base timezone icalendar gnus
nnheader gnus-util mail-utils range mm-util mail-prsvr wid-edit web-mode
derived disp-table erlang-start skeleton cc-mode cc-fonts cc-guess
cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs slime-asdf
grep slime-tramp tramp rx trampver tramp-integration files-x
tramp-message tramp-compat xdg shell pcomplete parse-time iso8601
time-date format-spec tramp-loaddefs slime-fancy slime-indentation
slime-cl-indent cl-indent slime-trace-dialog slime-fontifying-fu
slime-package-fu slime-references slime-compiler-notes-tree advice
slime-scratch slime-presentations bridge slime-macrostep macrostep
slime-mdot-fu slime-enclosing-context slime-fuzzy slime-fancy-trace
slime-fancy-inspector slime-c-p-c slime-editing-commands slime-autodoc
slime-repl slime-parse slime apropos compile text-property-search etags
fileloop generator xref project arc-mode archive-mode noutline outline
icons pp comint ansi-osc ansi-color ring hyperspec thingatpt
slime-autoloads edmacro kmacro use-package-bind-key bind-key appt
diary-lib diary-loaddefs cal-menu calendar cal-loaddefs pcase dired-x
dired-aux dired dired-loaddefs notifications dbus xml cl-extra help-mode
use-package-core repeat easy-mmode debbugs-autoloads ebdb-autoloads
ef-themes-autoloads exwm-autoloads hyperbole-autoloads magit-autoloads
git-commit-autoloads magit-section-autoloads dash-autoloads
on-screen-autoloads osm-autoloads paredit-autoloads rust-mode-autoloads
speed-type-autoloads transmission-autoloads with-editor-autoloads info
compat-autoloads ytdious-autoloads package browse-url url url-proxy
url-privacy url-expand url-methods url-history url-cookie
generate-lisp-file url-domsuf url-util mailcap url-handlers url-parse
auth-source cl-seq eieio eieio-core cl-macs password-cache json subr-x
map byte-opt gv bytecomp byte-compile url-vars cl-loaddefs cl-lib rmc
iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook
vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win
term/common-win x-dnd touch-screen tool-bar dnd fontset image regexp-opt
fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode
register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select
scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors
frame minibuffer nadvice seq simple cl-generic indonesian philippine
cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao
korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech
european ethiopic indian cyrillic chinese composite emoji-zwj charscript
charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure
cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp
files window text-properties overlay sha1 md5 base64 format env
code-pages mule custom widget keymap hashtable-print-readable backquote
threads kqueue lcms2 dynamic-setting font-render-setting xinput2 x
multi-tty move-toolbar make-network-process emacs)

Memory information:
((conses 16 1554291 684022) (symbols 48 62309 31)
 (strings 32 315492 39210) (string-bytes 1 10401166)
 (vectors 16 192434) (vector-slots 8 3310178 229525)
 (floats 8 1296 8793) (intervals 56 133979 10171) (buffers 992 180))

-- 
Manuel Giraud

bug#67683: 30.0.50; [PATCH] Fix 'M-.' on Emacs C sources

[Eli Zaretskii]

> Date: Thu, 07 Dec 2023 10:54:12 +0100
> From:  Manuel Giraud via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
> 
> I don't know how but for some times now 'M-.' is broken for me on C
> sources.  The attach patch seems reasonable and fixes this issue.  I
> guess that the title of this patch should be reworked but I don't really
> know how to put it.

Any chance of a reproduction recipe starting from "emacs -Q"?  I just
tried M-. with an arbitrary symbol in the Emacs C sources, and it
worked.  I also don't remember it ever failing for me.  So I'm unsure
why it fails for you and under which circumstances.  So something is
at work here that I don't see, and a recipe might help.

Thanks.

bug#67683: 30.0.50; [PATCH] Fix 'M-.' on Emacs C sources

[Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Eli Zaretskii <eliz@gnu.org> writes:

>> Date: Thu, 07 Dec 2023 10:54:12 +0100
>> From:  Manuel Giraud via "Bug reports for GNU Emacs,
>>  the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
>> 
>> I don't know how but for some times now 'M-.' is broken for me on C
>> sources.  The attach patch seems reasonable and fixes this issue.  I
>> guess that the title of this patch should be reworked but I don't really
>> know how to put it.
>
> Any chance of a reproduction recipe starting from "emacs -Q"?  I just
> tried M-. with an arbitrary symbol in the Emacs C sources, and it
> worked.  I also don't remember it ever failing for me.  So I'm unsure
> why it fails for you and under which circumstances.  So something is
> at work here that I don't see, and a recipe might help.

Yes, sorry it also works for me with "emacs -Q" (it even asks if I want
to visit the current directory tags table).  I'll try to investigate it.
-- 
Manuel Giraud

bug#67683: 30.0.50; [PATCH] Fix 'M-.' on Emacs C sources

[Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors]

So, I'm closing it because I'm not able to reproduce.  Maybe it
appeared after some time in a long running session.  Sorry for the
noise.
-- 
Manuel Giraud

bug#67683: 30.0.50; [PATCH] Fix 'M-.' on Emacs C sources

[Eli Zaretskii]

> From: Manuel Giraud <manuel@ledu-giraud.fr>
> Cc: 67683@debbugs.gnu.org
> Date: Thu, 07 Dec 2023 16:27:05 +0100
> 
> So, I'm closing it because I'm not able to reproduce.  Maybe it
> appeared after some time in a long running session.  Sorry for the
> noise.

No need to apologize, and thanks for looking into this.

bug#67683: 30.0.50; [PATCH] Fix 'M-.' on Emacs C sources

[Eli Zaretskii]

> From: Manuel Giraud <manuel@ledu-giraud.fr>
> Cc: 67683@debbugs.gnu.org
> Date: Thu, 18 Jan 2024 17:19:33 +0100
> 
> I'm reopening it because I'm currently experiencing it.  I'm still not
> able to reproduce it reliably but I also cannot find a way to fix it and
> it is quite annoying.

It happens to you in "emacs -Q" as well?

bug#67683: 30.0.50; [PATCH] Fix 'M-.' on Emacs C sources

[Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Manuel Giraud <manuel@ledu-giraud.fr>
>> Cc: 67683@debbugs.gnu.org
>> Date: Thu, 18 Jan 2024 17:19:33 +0100
>> 
>> I'm reopening it because I'm currently experiencing it.  I'm still not
>> able to reproduce it reliably but I also cannot find a way to fix it and
>> it is quite annoying.
>
> It happens to you in "emacs -Q" as well?

No it still doesn't but I don't have anything fancy that I think could
mess with xref.  And it happen to me twice recently.  Now, I don't even
know what to do to fix my current state: an explicit 'visit-tags-table'
could not fix this.
-- 
Manuel Giraud

bug#67683: 30.0.50; [PATCH] Fix 'M-.' on Emacs C sources

[Eli Zaretskii]

> From: Manuel Giraud <manuel@ledu-giraud.fr>
> Cc: 67683@debbugs.gnu.org
> Date: Thu, 18 Jan 2024 19:32:49 +0100
> 
> Now, I don't even know what to do to fix my current state: an
> explicit 'visit-tags-table' could not fix this.

I'd suggest to step through the code in Edebug.

bug#67683: 30.0.50; [PATCH] Fix 'M-.' on Emacs C sources

[Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Manuel Giraud <manuel@ledu-giraud.fr>
>> Cc: 67683@debbugs.gnu.org
>> Date: Thu, 18 Jan 2024 19:32:49 +0100
>> 
>> Now, I don't even know what to do to fix my current state: an
>> explicit 'visit-tags-table' could not fix this.
>
> I'd suggest to step through the code in Edebug.

I'm not using Edebug but since I currently get "(void-function nil)"
error I did a 'toggle-debug-on-error' and this error triggers when
calling 'tags-included-tables' from 'tags-table-extend-computed-list'

What is really weird is that if I set myself into the TAGS buffer and
evaluate (tags-included-tables), it works and returns a list of
filenames.
-- 
Manuel Giraud

bug#67683: 30.0.50; [PATCH] Fix 'M-.' on Emacs C sources

[Eli Zaretskii]

> From: Manuel Giraud <manuel@ledu-giraud.fr>
> Cc: 67683@debbugs.gnu.org
> Date: Thu, 18 Jan 2024 20:10:41 +0100
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> >> From: Manuel Giraud <manuel@ledu-giraud.fr>
> >> Cc: 67683@debbugs.gnu.org
> >> Date: Thu, 18 Jan 2024 19:32:49 +0100
> >> 
> >> Now, I don't even know what to do to fix my current state: an
> >> explicit 'visit-tags-table' could not fix this.
> >
> > I'd suggest to step through the code in Edebug.
> 
> I'm not using Edebug but since I currently get "(void-function nil)"
> error I did a 'toggle-debug-on-error' and this error triggers when
> calling 'tags-included-tables' from 'tags-table-extend-computed-list'
> 
> What is really weird is that if I set myself into the TAGS buffer and
> evaluate (tags-included-tables), it works and returns a list of
> filenames.

And if you type "C-u M-." in the TAGS buffer, then you can type a
symbol, and Xref shows its definition allright?  IOW, does M-. work
from the TAGS buffer?

bug#67683: 30.0.50; [PATCH] Fix 'M-.' on Emacs C sources

[Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Eli Zaretskii <eliz@gnu.org> writes:

[...]

>> I'm not using Edebug but since I currently get "(void-function nil)"
>> error I did a 'toggle-debug-on-error' and this error triggers when
>> calling 'tags-included-tables' from 'tags-table-extend-computed-list'
>> 
>> What is really weird is that if I set myself into the TAGS buffer and
>> evaluate (tags-included-tables), it works and returns a list of
>> filenames.
>
> And if you type "C-u M-." in the TAGS buffer, then you can type a
> symbol, and Xref shows its definition allright?  IOW, does M-. work
> from the TAGS buffer?

No "C-u M-." does not work from the TAGS buffer with the same error.
-- 
Manuel Giraud

bug#67683: 30.0.50; [PATCH] Fix 'M-.' on Emacs C sources

[Eli Zaretskii]

> From: Manuel Giraud <manuel@ledu-giraud.fr>
> Cc: 67683@debbugs.gnu.org
> Date: Thu, 18 Jan 2024 22:10:48 +0100
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> [...]
> 
> >> I'm not using Edebug but since I currently get "(void-function nil)"
> >> error I did a 'toggle-debug-on-error' and this error triggers when
> >> calling 'tags-included-tables' from 'tags-table-extend-computed-list'
> >> 
> >> What is really weird is that if I set myself into the TAGS buffer and
> >> evaluate (tags-included-tables), it works and returns a list of
> >> filenames.
> >
> > And if you type "C-u M-." in the TAGS buffer, then you can type a
> > symbol, and Xref shows its definition allright?  IOW, does M-. work
> > from the TAGS buffer?
> 
> No "C-u M-." does not work from the TAGS buffer with the same error.

So then the conclusion is that something in the way
tags-included-tables is invoked from tags-table-extend-computed-list
(or its callers in the M-. scenario) breaks tags-included-tables, even
though invoking tags-included-tables directly works as intended,
right?  If so, I suggest to look up the call-stack chain and try to
find what is it that breaks tags-included-tables.

bug#67683: 30.0.50; [PATCH] Fix 'M-.' on Emacs C sources

[Manuel Giraud via Bug reports for GNU Emacs, the Swiss army knife of text editors]

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Manuel Giraud <manuel@ledu-giraud.fr>
>> Cc: 67683@debbugs.gnu.org
>> Date: Thu, 18 Jan 2024 22:10:48 +0100
>> 
>> Eli Zaretskii <eliz@gnu.org> writes:
>> 
>> [...]
>> 
>> >> I'm not using Edebug but since I currently get "(void-function nil)"
>> >> error I did a 'toggle-debug-on-error' and this error triggers when
>> >> calling 'tags-included-tables' from 'tags-table-extend-computed-list'
>> >> 
>> >> What is really weird is that if I set myself into the TAGS buffer and
>> >> evaluate (tags-included-tables), it works and returns a list of
>> >> filenames.
>> >
>> > And if you type "C-u M-." in the TAGS buffer, then you can type a
>> > symbol, and Xref shows its definition allright?  IOW, does M-. work
>> > from the TAGS buffer?
>> 
>> No "C-u M-." does not work from the TAGS buffer with the same error.
>
> So then the conclusion is that something in the way
> tags-included-tables is invoked from tags-table-extend-computed-list
> (or its callers in the M-. scenario) breaks tags-included-tables, even
> though invoking tags-included-tables directly works as intended,
> right?  If so, I suggest to look up the call-stack chain and try to
> find what is it that breaks tags-included-tables.

Thanks.  I have found the problem even though I don't what causes it.
It came from the "lisp/TAGS" buffer: in this one, evaluating
(tags-included-tables) returns an error.  I just had to close this
buffer and now xref is working as expected.

But I really don't know what caused this buffer to be broken in this
regard.  Anyway thanks (again) for your kind help.
-- 
Manuel Giraud

bug#67683: 30.0.50; [PATCH] Fix 'M-.' on Emacs C sources

[Eli Zaretskii]

> From: Manuel Giraud <manuel@ledu-giraud.fr>
> Cc: 67683@debbugs.gnu.org
> Date: Fri, 19 Jan 2024 10:18:04 +0100
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> >> From: Manuel Giraud <manuel@ledu-giraud.fr>
> >> Cc: 67683@debbugs.gnu.org
> >> Date: Thu, 18 Jan 2024 22:10:48 +0100
> >> 
> >> Eli Zaretskii <eliz@gnu.org> writes:
> >> 
> >> [...]
> >> 
> >> >> I'm not using Edebug but since I currently get "(void-function nil)"
> >> >> error I did a 'toggle-debug-on-error' and this error triggers when
> >> >> calling 'tags-included-tables' from 'tags-table-extend-computed-list'
> >> >> 
> >> >> What is really weird is that if I set myself into the TAGS buffer and
> >> >> evaluate (tags-included-tables), it works and returns a list of
> >> >> filenames.
> >> >
> >> > And if you type "C-u M-." in the TAGS buffer, then you can type a
> >> > symbol, and Xref shows its definition allright?  IOW, does M-. work
> >> > from the TAGS buffer?
> >> 
> >> No "C-u M-." does not work from the TAGS buffer with the same error.
> >
> > So then the conclusion is that something in the way
> > tags-included-tables is invoked from tags-table-extend-computed-list
> > (or its callers in the M-. scenario) breaks tags-included-tables, even
> > though invoking tags-included-tables directly works as intended,
> > right?  If so, I suggest to look up the call-stack chain and try to
> > find what is it that breaks tags-included-tables.
> 
> Thanks.  I have found the problem even though I don't what causes it.
> It came from the "lisp/TAGS" buffer: in this one, evaluating
> (tags-included-tables) returns an error.

Maybe that's a bug that we should fix.  Can you try figuring out why
the function fails in that buffer?