From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "J.P." Newsgroups: gmane.emacs.bugs Subject: bug#62474: 29.0.60; wrong-type-argument from pcomplete-opt Date: Thu, 18 Jan 2024 15:18:42 -0800 Message-ID: <87edee1b8t.fsf@neverwas.me> References: <87v8int08v.fsf@neverwas.me> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19043"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) To: 62474-done@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jan 19 00:20:41 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rQbgf-0004nn-54 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 19 Jan 2024 00:20:41 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rQbg4-0003aA-HV; Thu, 18 Jan 2024 18:20:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rQbg1-0003ZL-E0 for bug-gnu-emacs@gnu.org; Thu, 18 Jan 2024 18:20:01 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rQbg1-000730-5h for bug-gnu-emacs@gnu.org; Thu, 18 Jan 2024 18:20:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rQbg2-0006bn-Iu for bug-gnu-emacs@gnu.org; Thu, 18 Jan 2024 18:20:02 -0500 Resent-From: "J.P." Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Thu, 18 Jan 2024 23:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 62474 X-GNU-PR-Package: emacs Mail-Followup-To: 62474@debbugs.gnu.org, jp@neverwas.me, jp@neverwas.me Original-Received: via spool by 62474-done@debbugs.gnu.org id=D62474.170561994325316 (code D ref 62474); Thu, 18 Jan 2024 23:20:02 +0000 Original-Received: (at 62474-done) by debbugs.gnu.org; 18 Jan 2024 23:19:03 +0000 Original-Received: from localhost ([127.0.0.1]:56951 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rQbf5-0006aF-6Q for submit@debbugs.gnu.org; Thu, 18 Jan 2024 18:19:03 -0500 Original-Received: from mail-108-mta43.mxroute.com ([136.175.108.43]:43237) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rQbf2-0006Zp-QA for 62474-done@debbugs.gnu.org; Thu, 18 Jan 2024 18:19:01 -0500 Original-Received: from filter006.mxroute.com ([136.175.111.2] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta43.mxroute.com (ZoneMTA) with ESMTPSA id 18d1edecfff0003727.001 for <62474-done@debbugs.gnu.org> (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384); Thu, 18 Jan 2024 23:18:55 +0000 X-Zone-Loop: 827a676ec597c33fb799e771dc466008dac7f2a0e00b X-Originating-IP: [136.175.111.2] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=neverwas.me ; s=x; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To: Subject:To:From:Sender:Reply-To:Cc:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=OSRCqPvrCgbbFAi4im2MbvaE0pMavIm8xYzeRtFfz2w=; b=Hy/9VPWJ6LdraQ1WqGSE3ZheyV gvduZtwN+CiENagCIM8OglhGZRSQhqVI/iRqYAtV0HsuKp0u5vHdyxUMp2ha8fYMXoqEINCp5ejPk L6tnCHBDQBJ/OEmxVVe/psBIiFfooLXjKzEivM0/xWsx0I8GoSicTtA5EyLXLYHwZ/xxqb6q8g8Oo MF/d+NWR/79vQaz1wadd5R68hUfzhtX8lAxpISLt4oHViU10g/Tir1RsrjX0gXrCfzjXFx+9OsA65 1xmynz5pBsYyzVNq2XGzJrz40NeACaaQGeJCGFY8fw92MYsUF92UheRgMjspd83as9n3nbbVHPySV CM5aYAEA==; In-Reply-To: <87v8int08v.fsf@neverwas.me> (J. P.'s message of "Sun, 26 Mar 2023 19:08:00 -0700") X-Authenticated-Id: masked@neverwas.me X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:278458 Archived-At: "J.P." writes: > Hi, this may be related to (or a duplicate of): > > https://debbugs.gnu.org/cgi/bugreport.cgi?bug=59750 > > I first encountered it in ERC, but it appears to happen from any > pcomplete/foo function that calls `pcomplete-opt' with a string of > length two or more. AFAICT, this doesn't occur in Emacs 28. > > Example from emacs -Q: > > 1. M-x eshell > 2. type "gzip -" and hit TAB > 3. type "h" -> wrong-type-argument // "h" gets inserted anyway > 4. type TAB -> wrong-type-argument This appears to have been fixed by 239db5d5162f6f9a4a6735e176c8d306f18e50e7 Author: Jim Porter AuthorDate: Tue Sep 5 18:27:21 2023 -0700 Commit: Jim Porter CommitDate: Tue Oct 10 13:00:38 2023 -0700 Follows: emacs-29.1 (168549) Revert commits dafa6d6badd6 and 72c45fa9109a These were there to work around deficiencies in how Eshell produces completions for 'pcomplete-argument' (Eshell passed various non-string objects to Pcomplete, which broke things). Now, Eshell always returns a stringified form of the argument, with the original value stored via the text property 'pcomplete-arg-value'. * lisp/pcomplete.el (pcomplete-arg): Revert changes back to a simpler form. 1 file changed, 7 insertions(+), 29 deletions(-) lisp/pcomplete.el | 36 +++++++----------------------------- Closing.