From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jonas Bernoulli via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#69259: 30.0.50; (get-pos-property 9483 'cursor-intangible) gives args-out-of-range error in folded magit buffer Date: Thu, 22 Feb 2024 16:17:06 +0100 Message-ID: <87edd4plzh.fsf@bernoul.li> References: <87msrxo4ji.fsf@strawberrytea.xyz> <861q98r64n.fsf@gnu.org> <871q97b09m.fsf@strawberrytea.xyz> <86zfvum21y.fsf@gnu.org> <87y1bdmlwa.fsf@strawberrytea.xyz> Reply-To: Jonas Bernoulli Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35062"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , 69259@debbugs.gnu.org To: StrawberryTea , Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Feb 22 16:17:53 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rdApc-0008sK-38 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 22 Feb 2024 16:17:52 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rdApR-0007I0-TK; Thu, 22 Feb 2024 10:17:42 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rdApP-0007Ho-4w for bug-gnu-emacs@gnu.org; Thu, 22 Feb 2024 10:17:39 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rdApO-0006Iw-TR for bug-gnu-emacs@gnu.org; Thu, 22 Feb 2024 10:17:38 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rdApl-0000Xh-R2 for bug-gnu-emacs@gnu.org; Thu, 22 Feb 2024 10:18:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Jonas Bernoulli Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 22 Feb 2024 15:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69259 X-GNU-PR-Package: emacs Original-Received: via spool by 69259-submit@debbugs.gnu.org id=B69259.17086150642031 (code B ref 69259); Thu, 22 Feb 2024 15:18:01 +0000 Original-Received: (at 69259) by debbugs.gnu.org; 22 Feb 2024 15:17:44 +0000 Original-Received: from localhost ([127.0.0.1]:34797 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rdApT-0000Wg-PA for submit@debbugs.gnu.org; Thu, 22 Feb 2024 10:17:44 -0500 Original-Received: from mail.hostpark.net ([212.243.197.30]:45632) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rdApR-0000WC-90 for 69259@debbugs.gnu.org; Thu, 22 Feb 2024 10:17:42 -0500 Original-Received: from localhost (localhost [127.0.0.1]) by mail.hostpark.net (Postfix) with ESMTP id 1AD1316762; Thu, 22 Feb 2024 16:17:12 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=bernoul.li; h= content-transfer-encoding:content-type:content-type:mime-version :message-id:date:date:references:in-reply-to:subject:subject :from:from; s=sel2011a; t=1708615031; bh=jdzTnb8MiuJYLFXpGFcgBsF nSEW5FcW5OgZ2cuqli+8=; b=bF4uaNgG6rSM7L+2hO9zeFuIVH3D3T50OPIvZJc yhslx5U48+JNhYWY5EWjqJt9J/bi3SiKiEEn3VN77+4AtiFkEman+YFUj2PYP1X1 QUFz5d2X76clUUuds2BsChat1nnjVIMnX3SdJLAsmZteeL3oaBnAcGnLWSPOg2kr O2ow= X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net Original-Received: from mail.hostpark.net ([127.0.0.1]) by localhost (mail0.hostpark.net [127.0.0.1]) (amavisd-new, port 10224) with ESMTP id ERPF_qsTM2mC; Thu, 22 Feb 2024 16:17:11 +0100 (CET) Original-Received: from customer (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.hostpark.net (Postfix) with ESMTPSA id 1B7CD1652E; Thu, 22 Feb 2024 16:17:09 +0100 (CET) In-Reply-To: <87y1bdmlwa.fsf@strawberrytea.xyz> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:280455 Archived-At: StrawberryTea writes: > Thanks for the explanation Stefan and Eli. I ended up making a PR to magi= t. And > I think Tarsius is going to merge it. He just asked me to test it after h= e made > a small change. It would have helped me if you had mentioned this discussion there. I only became aware of this because Eli cced me. It is useful for me because it confirms some speculation of mine. When I merged the Magit pull-request I mentioned that I am doing so as a quick fix for the issue, but that I intend to look at it again at a later time. >>> I think cursor-sensor is written under the assumption that the >>> selected window=E2=80=99s buffer is also the current buffer, and if so, >>> magit-post-command-hook should abide by that protocol. Stefan, am I >>> right? >> >> Not `cursor-sensor.el` in its entirety, but >> `cursor-sensor-move-to-tangible` presumes that it is called with the >> current-buffer already set to (window-buffer window). That was my guess. The merged commit just forgoes calling that function if things aren't as expected. My plan was (and obviously still is) to look into instead ensuring that the expected buffer is current, making it current if necessary. Jonas