From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#70139: 29.3.50; key-translate does not support all keyboard-translate usages Date: Tue, 02 Apr 2024 17:41:47 +0200 Message-ID: <87edbnu5z8.fsf@gmail.com> References: <87v850t7nz.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5904"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 70139@debbugs.gnu.org To: Charalampos Mitrodimas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Apr 02 17:43:20 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rrgIC-0001Lw-Ik for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 02 Apr 2024 17:43:20 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rrgHs-0004k8-2q; Tue, 02 Apr 2024 11:43:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rrgHq-0004k0-P1 for bug-gnu-emacs@gnu.org; Tue, 02 Apr 2024 11:42:58 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rrgHq-0000yt-6q for bug-gnu-emacs@gnu.org; Tue, 02 Apr 2024 11:42:58 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rrgHt-0001Mc-Uv for bug-gnu-emacs@gnu.org; Tue, 02 Apr 2024 11:43:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 02 Apr 2024 15:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70139 X-GNU-PR-Package: emacs Original-Received: via spool by 70139-submit@debbugs.gnu.org id=B70139.17120725234938 (code B ref 70139); Tue, 02 Apr 2024 15:43:01 +0000 Original-Received: (at 70139) by debbugs.gnu.org; 2 Apr 2024 15:42:03 +0000 Original-Received: from localhost ([127.0.0.1]:55031 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rrgGw-0001Ha-V6 for submit@debbugs.gnu.org; Tue, 02 Apr 2024 11:42:03 -0400 Original-Received: from mail-wr1-x42c.google.com ([2a00:1450:4864:20::42c]:57434) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rrgGv-0001Gc-37 for 70139@debbugs.gnu.org; Tue, 02 Apr 2024 11:42:02 -0400 Original-Received: by mail-wr1-x42c.google.com with SMTP id ffacd0b85a97d-3436fec6a70so467860f8f.2 for <70139@debbugs.gnu.org>; Tue, 02 Apr 2024 08:41:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712072510; x=1712677310; darn=debbugs.gnu.org; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=WEGDIbfc0NGmUkqseTVsV4W2oGcmskVQR3eAFJ29otA=; b=RQhweflJmou+lRqdDXq9EqUoT9GBk1E8Qg5YPSZLken4ByrWOwS/cmxqDsclrAQ7HS SjL8KgvlYnwGJ0+zb+Y7fr/eJcjue6h2Ndp4V8uXGyJSIPme7nLGTnIcjjW9pcQw0AjC tzlHN3A+VrZNs9P0UdUumR2z+OdJJlmDSodaUbAFxENP8FmVZPcI5Xe12saiaF2riC0Z lH2dhuIH2vsPEcSUWNHCdcuP01X2MnLW6E/kgl6waVmiKvzcST8lJf8/0iCxQpG1kWqQ GyWAjJZtEnrw+LqFlRIuyg7UnAZChE4QQMXUH8ZAlS/05CT5QZWN+5TD/IoiX3JjVvFE OtpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712072510; x=1712677310; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=WEGDIbfc0NGmUkqseTVsV4W2oGcmskVQR3eAFJ29otA=; b=njW4g/wh+9b7G4ZFkBytNOwwdez2TIH7ciLZ/YEAExLGwpwlRpC+KRvfwCaWy12qtp yUWGe1eAYlAJYPQnie9bELdHFYMHjr3DRv4XO78ks5hv9iO2KuzM3lH/EXz369Y3zm8A ksOj6KqkH4qp2OWW0b9XmHVFxcjBBTtb8uHIMTxBxM8e1k96VfbMnv5glmmehfKJK4BX IqYFWf4RkNfJutxQmkgfN8eroN+Wf/YQwLrCzQN+M4vKLwMRCa1YwbyC5PdpTm3eGNnB NCgyTtYZnirlmL2guNOzbCEVidvK5lO9tan/UsPhWQrhL/E4Q4canunQq0R33XcUGjbl HvbA== X-Gm-Message-State: AOJu0YypTibs11kYJQKn2jP/B0QuQR18SHowi+1/YsYxOKFpNAwi8MWB VEUp8+WFc20Q7pj9X/0iFM4I1V54mqFSUpbNVHFtMk0LVSSellOw/vj3xCfL X-Google-Smtp-Source: AGHT+IEBprn55ijq63otuzNo1LyD8mUvsjMvHHVKmwUwTt7KFoTWZw5JeFXEHWtSmONG2UR4aiPAzA== X-Received: by 2002:adf:e246:0:b0:343:84ca:ef27 with SMTP id bl6-20020adfe246000000b0034384caef27mr78084wrb.41.1712072510099; Tue, 02 Apr 2024 08:41:50 -0700 (PDT) Original-Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id dq6-20020a0560000cc600b00341c3071c93sm14524573wrb.73.2024.04.02.08.41.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Apr 2024 08:41:49 -0700 (PDT) In-Reply-To: (Charalampos Mitrodimas's message of "Tue, 2 Apr 2024 14:28:47 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:282520 Archived-At: >>>>> On Tue, 2 Apr 2024 14:28:47 +0000, Charalampos Mitrodimas said: The patch looks ok, it needs a ChangeLog entry style commit message though (see the "** Commit messages" and "** Generating ChangeLog entries" sections of CONTRIBUTE). For extra credit, update the emacs lisp manual entry for `key-translate' :-) Charalampos> From 4c35e45c128d8ad0c93ac787fe51eecbcd570286 Mon Sep 17 00:00:00 2001 Charalampos> From: Charalampos Mitrodimas Charalampos> Date: Tue, 2 Apr 2024 17:20:44 +0300 Charalampos> Subject: [PATCH] Improve key-translate to support removing translations Charalampos> This patch enhances the key-translate function to allow removing Charalampos> keyboard translations by passing nil as the second argument (TO). Charalampos> If TO is nil, any existing translation for the FROM key will be removed. Charalampos> The compiler macro is updated to only check TO when it is non-nil. Charalampos> This change makes key-translate more consistent with the behavior of Charalampos> keyboard-translate, providing a way to remove translations without Charalampos> having to specify the same key for both FROM and TO. Charalampos> The documentation string is updated to reflect the new behavior. Robert --