From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Felician Nemeth Newsgroups: gmane.emacs.bugs Subject: bug#70958: 30.0.50; eglot-managed-mode hooks not called on shutdown Date: Mon, 27 May 2024 18:21:47 +0200 Message-ID: <87ed9np6n8.fsf@betli.tmit.bme.hu> References: <86y17yz5sr.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26263"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) Cc: 70958@debbugs.gnu.org, Eli Zaretskii , Troy Brown , Stefan Monnier To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon May 27 18:24:18 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sBd8y-0006ef-B8 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 27 May 2024 18:24:16 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sBd8e-0004Jj-E5; Mon, 27 May 2024 12:23:56 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sBd8c-0004JI-HB for bug-gnu-emacs@gnu.org; Mon, 27 May 2024 12:23:54 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sBd8c-0004Hn-8u for bug-gnu-emacs@gnu.org; Mon, 27 May 2024 12:23:54 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sBd8k-0006B2-GT for bug-gnu-emacs@gnu.org; Mon, 27 May 2024 12:24:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Felician Nemeth Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 27 May 2024 16:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70958 X-GNU-PR-Package: emacs Original-Received: via spool by 70958-submit@debbugs.gnu.org id=B70958.171682698623655 (code B ref 70958); Mon, 27 May 2024 16:24:02 +0000 Original-Received: (at 70958) by debbugs.gnu.org; 27 May 2024 16:23:06 +0000 Original-Received: from localhost ([127.0.0.1]:45107 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sBd7q-00069S-7R for submit@debbugs.gnu.org; Mon, 27 May 2024 12:23:06 -0400 Original-Received: from mail-ed1-f49.google.com ([209.85.208.49]:55596) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sBd7n-00068z-WA for 70958@debbugs.gnu.org; Mon, 27 May 2024 12:23:04 -0400 Original-Received: by mail-ed1-f49.google.com with SMTP id 4fb4d7f45d1cf-578626375ffso3204303a12.3 for <70958@debbugs.gnu.org>; Mon, 27 May 2024 09:22:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1716826909; x=1717431709; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:face:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=Y9xnZyWv1C+txiiNo4cTr5YKL/v0pcFSz050qvQNh78=; b=NO6440D3GMWE+DcRxnHCL/G3k2wdaRWS5BqYLFR+hddpf8BmZl9ZOTjb3H6ZnK1ss5 znUALjiJzD8fLEfk9Eq0c6vc+CO3F8Qv4P11pV3Vt9GiCsxhKPDhrErWnSuHQL4bzfx/ 7bINsIuRg8xKKmoIRawxgdfIDAKiHcHigkogOZtDerT+iwF7lAyFrweto9hCiNBl6kXg ymHUCYh66F8BgvLVtHcL1cEO8dXc/nSk3ETtOEnbM49aAf947Ojx4yfwR63sAmV4NWd2 WuGICX1sbPSEKAMKxg+UnPVaiCD2rIPeCiA+WNcrx2OoarB0V9IAPouEDxSQgQirou3M N+JQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716826909; x=1717431709; h=content-transfer-encoding:mime-version:face:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=Y9xnZyWv1C+txiiNo4cTr5YKL/v0pcFSz050qvQNh78=; b=iglzmkbzu7CwAcV6vntXbUPDyaQqc0RoyBBqD6dfRCK6cn5M539gZ3pyfa5cFQXSVZ q49HPTU3+PSeay1Z7kR5R3bQ6dGjheexIsYT/iknSyEow0KWN+EMkov5Eex8+Qyvh/ZM fTMMI0R0ggehAN8KWt8fNGnqVr7RPHBZpvItgGh1bYnATkGpM73+KHoNo93PS7lADZ+W ZABIHwhxzGbRUEON+tEByZ4HjIBfEKknozkr5hrcCBHC4yj7M1q96ZR7HwHSk/fV9C+f 0P92VI8mWA20ZVNFpuzo9i7A3b4pmHkYHlMc9M051uM62QROqQse+zkPM3ACbNuVdszE b0oQ== X-Forwarded-Encrypted: i=1; AJvYcCVhoNn0SxdsPithN63tDX3Z0ssx/JcudnSB8KoA5Z/+7lYwUyO3bteBSYilt62BaHXVRIN2W3vj6qURXQpl2GdmHClhtV4= X-Gm-Message-State: AOJu0YwK7FTbhdyb6rwBfxhTmQhYPAtNBms5GTPOe1mGJMQYbIurt2MG 8uLrwkWXhJuftJoiEuaxsRxmhFwr4njknmpSD+yKwo88bSL0DLII4lipCg== X-Google-Smtp-Source: AGHT+IFcxwvg4syYR+3ZkaMkPvZHitRI/yeW10rbxVi5dg9B2pJe6/oM30T2ZJqD4iRAz9J6JkpXew== X-Received: by 2002:a50:d7c8:0:b0:578:504f:fc5b with SMTP id 4fb4d7f45d1cf-5785194f2d3mr6026966a12.11.1716826908951; Mon, 27 May 2024 09:21:48 -0700 (PDT) Original-Received: from betli.gmail.com (catv-213-222-160-137.catv.fixed.vodafone.hu. [213.222.160.137]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-578649b3001sm4205267a12.77.2024.05.27.09.21.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 May 2024 09:21:48 -0700 (PDT) In-Reply-To: ("=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?="'s message of "Sun, 26 May 2024 23:46:38 +0100") Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAElBMVEWOdXElERN7LDLZs6/l 0dDQq6TepMcqAAACW0lEQVQ4jWWSzY7bMAyEaSm6mypylxjkroTRvUW8d9lavf+r7NDOZotWQHzg lyGHP0Sn5ed9qKrLWWIWos9/QJWIeCSywPNTd/AE0LtwFj7A+3WT5PwfeBrQKcsBnkfwVcNySWQr 3i34XN6gRNgis/v4uwSKHCD9lPitB0Aq9BHfHX4cgsI7cJJfLdZg/4bbCzoRmkD9MsagQSBDedZi CgNxkVSJmSOStTBUBKkywEnEoZzbwWj+ACiVJkF6pOpak2PMCqkMYDpaw+gatLR8atMOrB3JGzmm 3rSQo+tkxU+UAbhQSgtslULhsXKk6+IyQ1QTzeQB0MzjlpkCEUCeUdviWrwBcxVqpZjP+v0MYPA0 aq2rvIEZe4GRM0v+9QIB03rsABVSk5y+Mz3LSzExtJLlCCO6dV1uzDQFTBad+gO0TqqL9XE8x4ek +orvYiMJgzC8e+r6TqaPaK6QyqVNvoHtsRrooQ6tTi4vgaSkd8wIikodB3B0iIk58avsDdYNajpS bSKJ+mQnipGszB6zW4lGgsOkKHE2RWVcBpwhaIv3BYIAu3WsnC7YYKLRchp6w8fRGZIWiZuFsVai 7gbcUcJEhiDZ3K1+uzZvBlfaEO8oH4MLu6/hrKVM7QpQcIXJFuC1XjfbfKRxNslk94l9cYcEihV2 HWyNDQAXaLsvnrSyp7HaQhrAn13V6/XW11nh0XINBOEAV+tHK4EvAGNGvEwc0eZw8Vyr56imYEsV sOW9jxm/yb9AH1ufqGMviIK7A0Tc/723oM3tJ4HTOu9gDr3ftbdkxfdjsUv5AqWKwyfCYo5WAAAA AElFTkSuQmCC X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:286053 Archived-At: Jo=C3=A3o T=C3=A1vora writes: > So when e-m-m-hook was added it was made to run only on "turn on" If I remember correctly, the original intention was to use the hook when Eglot "turns off" as well. Since e-m-m-hook is not a normal hook, it is not straightforward to determine in which case the hook is called, so the docstring helps: "Use `eglot-managed-p' to determine if current buffer is managed."