From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Felician Nemeth Newsgroups: gmane.emacs.bugs Subject: bug#71353: [PATCH] eglot--format-markup doesn't support MarkedString code-blocks Date: Tue, 04 Jun 2024 07:41:57 +0200 Message-ID: <87ed9dl0wq.fsf@betli.tmit.bme.hu> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29986"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) Cc: 71353@debbugs.gnu.org To: Troy Brown Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jun 04 07:44:08 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sEMxr-0007Yq-Mo for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 04 Jun 2024 07:44:07 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sEMxd-0005MP-VP; Tue, 04 Jun 2024 01:43:54 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sEMxZ-0005M8-9u for bug-gnu-emacs@gnu.org; Tue, 04 Jun 2024 01:43:49 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sEMxZ-0008LI-12 for bug-gnu-emacs@gnu.org; Tue, 04 Jun 2024 01:43:49 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sEMxl-0003n7-QI for bug-gnu-emacs@gnu.org; Tue, 04 Jun 2024 01:44:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Felician Nemeth Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 04 Jun 2024 05:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71353 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 71353-submit@debbugs.gnu.org id=B71353.171747980414513 (code B ref 71353); Tue, 04 Jun 2024 05:44:01 +0000 Original-Received: (at 71353) by debbugs.gnu.org; 4 Jun 2024 05:43:24 +0000 Original-Received: from localhost ([127.0.0.1]:56163 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sEMx9-0003m0-PT for submit@debbugs.gnu.org; Tue, 04 Jun 2024 01:43:24 -0400 Original-Received: from mail-ej1-f46.google.com ([209.85.218.46]:49448) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sEMx4-0003lk-6V for 71353@debbugs.gnu.org; Tue, 04 Jun 2024 01:43:21 -0400 Original-Received: by mail-ej1-f46.google.com with SMTP id a640c23a62f3a-a62ef52e837so62815266b.3 for <71353@debbugs.gnu.org>; Mon, 03 Jun 2024 22:43:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717479719; x=1718084519; darn=debbugs.gnu.org; h=mime-version:face:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=aVNaWjMPsAFyPZ3ibNLxP/bKB344JqzkYE6KiTuzwRI=; b=EoIbKohW/hqH55DE7GsKtmLH4We6QSXOF2/td0S5GUqyUzNuJi7eyBq7p72ScbIFhY jxzClVtrSCxpkN0VYyuomjfLvTDakyaPm9NHiNc6S0QufKEMnMtOmiS4+ZFLzQkSm1rb eE3FDzv7t+L8MpuYU1ado8/XcDqIXjOoV95AJwAW0p5nRZMeT/N1QxDf9IX/7bPkxoPe dqOi31SWffOUPYlitzAmE1jZs4iZqIcZhYpGVLsFIQpG2mWwPnP1Of/mut8fUZHm3hyo 7g52FPr8bYcn4fDbswsVE1yxJ8pBdAEkpNvAiB2hOKuvc8xb70lk+JvF3+NB/QWgG0YA OJMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717479719; x=1718084519; h=mime-version:face:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=aVNaWjMPsAFyPZ3ibNLxP/bKB344JqzkYE6KiTuzwRI=; b=pHvfhBR/DotTIPDcOC05pS8zkmfCdYeFzT88HpXQnPqAJP/U37OgauAFu0a3yjJmBv 64eKx1BiC4XU0nI3gA5kbRbWS/iid4qAfCX6QVyjvBxre7cjOl14Fd2dMdDGj8OqBBSt oIG7LYMohRKFZfNPYr9uw3VE/a03C/lhB6umXj0BjLBN5qar+iUQ7BpN9lmuVnaTyQn7 7TH/bSKZgeeAGRepmeMVqfH9nYhEx+ifhmgFyta70rSYQuAjOE3TQIcAuOKg4w5UY5jS TFibfOVypnSYfIeAAUTDS2qlG6ZbyhwWxq3XB844z9Uwa0qjhZLRf+xn/adYc42zP1Pf wanw== X-Gm-Message-State: AOJu0YxELNCK2/WYP/cfgQqOn0WL0c8LK9jYORqBvQJSkcc0itkmMYeG uwuvwZ7wOBqawNcF9s0sXfzvKIK4SDBRZp18/o4HiLRBUsE+wVNH+uR6rQ== X-Google-Smtp-Source: AGHT+IFp1io8DfDfK8zxng3bCpkGL0z70d/TgBPBd0KUOIG4I5yC6Ks66DTYWHatgXnA0BsgQ8vVrA== X-Received: by 2002:a17:906:e091:b0:a5a:81b1:6cab with SMTP id a640c23a62f3a-a6821f4dfa3mr625383366b.51.1717479718614; Mon, 03 Jun 2024 22:41:58 -0700 (PDT) Original-Received: from betli.gmail.com (catv-213-222-160-137.catv.fixed.vodafone.hu. [213.222.160.137]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a683209927csm551326566b.23.2024.06.03.22.41.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 03 Jun 2024 22:41:58 -0700 (PDT) In-Reply-To: (Troy Brown's message of "Mon, 3 Jun 2024 22:51:07 -0400") Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwAgMAAAAqbBEUAAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAADFBMVEX5+fmhoaEwMDD/ ///TMNVWAAAAAWJLR0QDEQxM8gAAAAlwSFlzAAAPEgAADxIBIZvyMwAAAAd0SU1FB+AICBUfHgLs gGoAAAGXSURBVCjPRdK/b5tAFAfw753gBEwM2ApMbuVIqf+Ko0qiyhOu4sj2xJBYMn/FUdX7UUUZ OjHgyvf+yj6IcW6Bjx53934ADEvs8bmEr8UVoTYTOyJO9KoYsVofN8kILdbeJ8Li6YpZWop4xOK0 VdfIoXmkHn5/5D7/Ts/8THacSqnkKTcMTxgUkVzFnEIRTKwwYYSCvzfg16f0i8YApW/XG/Pm8R49 dXjxKmRnxv3OwooQWcv4RUYem1fsNe/WU63uk7AmYxk78y32/ee2tZB4fO+WcZ7lnIGEolXW1EGw LfkSuQ0XTgRefgNlfNwRNV6QhBxJ8JNxTMUPyBqTd0bjaAP5G7NJRU39z80hLOZTjqB7K3tEEFSj aEsuQew6qBxxyhHjVUR7H7NpC9iHJZGLMCEuweqAqE1BHbfK2oRIz9EHYA/+wiFWru9smeVfuWNZ 2+NFtX80UA1TvJNdytM4DwO4kY7bJz8Qcd0G0ceslZGkkeoBsjUHwF1+jjM3XHaXEZ7mGLfwPFO+ RV9QLY2iEdmDo78D/gNPaXVYqd+pyQAAACV0RVh0ZGF0ZTpjcmVhdGUAMjAxNi0wOC0wOFQyMzoz MDoyOCswMjowMGy/yHYAAAAldEVYdGRhdGU6bW9kaWZ5ADIwMTYtMDgtMDhUMjM6MzA6MjgrMDI6 MDAd4nDKAAAAAElFTkSuQmCC X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:286513 Archived-At: Troy Brown writes: > The following patch will format MarkedString code-blocks for markdown > and plaintext while using the major mode to format any other language. According to the LSP specification, if MarkedString is "{ language: string; value: string }", then it should be interpreted as this markdown formatted string: ```${language} ${value} ``` The patch does not implement this behavior. And as a sidenote, MarkedString is deprecated. https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#textDocument_hover