From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#73046: 29.4; Emacs 100% CPU usage for several seconds when opening dired buffer over TRAMP Date: Sun, 08 Sep 2024 17:19:59 +0200 Message-ID: <87ed5ugokg.fsf@gmx.de> References: <87o75241qh.fsf@gmail.com> <86plpi2ixa.fsf@gnu.org> <87seudke20.fsf@gmail.com> <8634md2vc2.fsf@gnu.org> <87h6asrk42.fsf@gmx.de> <86a5gk28ht.fsf@gnu.org> <87le0450x8.fsf@gmx.de> <865xr8228d.fsf@gnu.org> <87jzfofzcl.fsf@gmail.com> <8634mc1ty0.fsf@gnu.org> <87h6asl3hl.fsf@gmail.com> <87frqbk0fx.fsf@gmx.de> <87plpf2vnx.fsf@gmail.com> <87wmjmidyt.fsf@gmx.de> <87mskii3m5.fsf@gmail.com> Reply-To: Michael Albinus Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25003"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , 73046@debbugs.gnu.org To: Suhail Singh Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Sep 08 17:21:19 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1snJj5-0006Ks-Hj for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 08 Sep 2024 17:21:19 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1snJio-0001rN-Oh; Sun, 08 Sep 2024 11:21:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1snJim-0001rC-4U for bug-gnu-emacs@gnu.org; Sun, 08 Sep 2024 11:21:00 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1snJil-0003Px-RZ for bug-gnu-emacs@gnu.org; Sun, 08 Sep 2024 11:20:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=bNLGlkLCNlcro06zFb9uOWhk9gb3HVAxcSdXudtXGoc=; b=oDPpix45DRCjExkdTKJaJcQwEgFULlVrT7KMqBArwu6edK31REjp2jxUCBIalfVmC/qrSzgRSnoNMlAd9V3K0JEt7P/arisuQq8UDu0yV3lmc9PUpQQAUWql9dbm0nc4hFhJYOTQ0YCrNnI3j36+zRGUyPFHUxmPXiV/nV5y39HcCWbACGjNVPfuM1HGsFAjoEOJ3zkjq7HtvLxh04gGYnOJcr5j0rxRMGcxi1+Zp/0Gch/bOUIO6BQ0RQdD0uYpk98J3kgBM0IZCSvIW5B7Pc7PIvx0Ew4D3LCskz3JVb+eu48nWNxIq57kH4dKj0VsEd20xtVa7ML1blVokDFvHA==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1snJio-0002Zz-3c for bug-gnu-emacs@gnu.org; Sun, 08 Sep 2024 11:21:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 08 Sep 2024 15:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 73046 X-GNU-PR-Package: emacs Original-Received: via spool by 73046-submit@debbugs.gnu.org id=B73046.17258088159849 (code B ref 73046); Sun, 08 Sep 2024 15:21:02 +0000 Original-Received: (at 73046) by debbugs.gnu.org; 8 Sep 2024 15:20:15 +0000 Original-Received: from localhost ([127.0.0.1]:59891 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1snJi2-0002Yn-Jg for submit@debbugs.gnu.org; Sun, 08 Sep 2024 11:20:14 -0400 Original-Received: from mout.gmx.net ([212.227.15.19]:41019) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1snJi0-0002Si-FG for 73046@debbugs.gnu.org; Sun, 08 Sep 2024 11:20:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.de; s=s31663417; t=1725808803; x=1726413603; i=michael.albinus@gmx.de; bh=bNLGlkLCNlcro06zFb9uOWhk9gb3HVAxcSdXudtXGoc=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date: Message-ID:MIME-Version:Content-Type:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=VPr9/2EArSBfTdRI1RfHVTghVlBQj0/k2V5yIlaG/2/3QkdBsUtkhK9sy+rlmAkk ZI75bFu7jWAddnhUznXd/sJLEYY97IYlGjmgTNn7Z6dzLwBzkiPN1T5z3e40kKS+0 RuyJjjOc4EDAU+XKzG/7XB/cLCpGbyQFNr66lhSCPHmSMG9kfvvPbshagQ2a6wbE8 PyiX6hZz4suWy9xszMS9HrXUfuJ5KCVFNt7RITwrYKgSkL/Ys+QRaR7pOUVgvynv+ Tii3ohx5QCK8/lSQWcm+itPYa2bJF1/V10ANXCy1NZFpbZ2+wYuRLtIz0EmRVWkV8 5J5EZcU6vlW6304Ybw== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Original-Received: from gandalf.gmx.de ([185.89.38.155]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MN5eR-1sUHQ60yYP-00ThII; Sun, 08 Sep 2024 17:20:03 +0200 In-Reply-To: <87mskii3m5.fsf@gmail.com> (Suhail Singh's message of "Sun, 08 Sep 2024 11:09:38 -0400") X-Provags-ID: V03:K1:TvtlFa1X5+hRd3ImQSD1KTw2pqBaXiXLZ5jgm5zq7fb549Sf1uz y1be/M/eK5susUkiRZ4TbgBroJH1wYJMJlbbwN/uQXK30gQxil1PdurUc3haN+Z09qPVh9s Xcj9LReRMyP825UF1IZK/THy4Y4NKHpHAyAQ6ZFT0XVh8zyEjoAFiswQ6Z6iJzG+LtpF01R 6xSIwH2gUPoSS3XTLOVYg== UI-OutboundReport: notjunk:1;M01:P0:kyg0Wtt3k1A=;UTS3ByDo3GJlFoiQk8CQH0f/11S gWGiOrpr4I43iCyiZSB0t9x63qgF5C7QeyGvQwnOBpV6DYa3AXrUYtM8+Xu2hWjhM8gTfc4v0 PRXnApflILpUXDxYXzs7O3qkWGKiYfq8LOI+2BsOR1PSybbJ3ILO19wE/AdzIfCVNKRzGzWLP xSnE1C3iRbXdK34ny3XW55Wn+4OUYmdCYD1C4IEXw27uBv6fdjb5qq6W4YB3GdgkIHC9by5u9 CvLkEw3puN4v4gr/vxOm38+chBzea51PFMVmSwHgfWoi1nXoO2ONNxlsg9yK3QSbSaGTg4YI1 eHrHoIh9uYZ0lxFKKLpAf0fqv8FRRPUQih3upS/JbzolIQ2Wfljymah4gL25a2r0biSKesdB0 6lscUd1Pc7UUiVbM23R3cHK4JRcvdbSbmzYOoNRgESAx795Q+Ec6fiUOLCYNWVr7ssJEn2N9Q gJhg7NNtnkdwgwBPkfkA6zormOzF+cQdGWN1LFCAB+nbgXtIGPCLNJKfEBMqZXkQeGyZbhBN6 OYfz1gWMg0OUay+8jhnqBWd4Qf1HC6QQKJzB7sbibT6/zxleixVmMqv371LBxTHsoqmE/TO2H A2W6oIcdApOAgWJ0v2WGeZX8NN3ajh2PM0v8LCcmBb2W6tMab2OKKCg9yzTpgKHEe4YhSKcaq sAbs+X9GkdnuN6QVHFKIozWQ+/A5WSW3K2uaqVHL5J4WCiH2hR/+50ux+6SxTY9Cs5qVYNm8W tn8JaPJ83e4AWwyutE36sqddrAkjDGPzAsZXQx6HWroJ/VeyaW3HywzTTiMQtNMgCqtUFZe1 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:291459 Archived-At: Suhail Singh writes: Hi Suhail, >> ;; Symbolic link to a non-directory. >> (list dired-re-sym >> (list (lambda (end) >> - (when-let ((file (dired-file-name-at-point))) >> - (let ((truename (ignore-errors (file-truename file)))) >> - (and (or (not truename) >> - (not (file-directory-p truename))) >> - (search-forward-regexp "\\(.+-> ?\\)\\(.+\\)" >> - end t))))) >> + (if (not (connection-local-value dired-check-symlinks)) >> + (search-forward-regexp >> + "\\(.+-> ?\\)\\(.+\\)" end t) >> + (when-let ((file (dired-file-name-at-point))) >> + (let ((truename (ignore-errors (file-truename file)))) >> + (and (or (not truename) >> + (not (file-directory-p truename))) >> + (search-forward-regexp >> + "\\(.+-> ?\\)\\(.+\\)" end t)))))) > > Minor nitpick: given the comment for this section (which seems to > suggest this only applies to symlinks to non-directories), wouldn't it > be "better" to simply have something like below instead for the if-then > case? I.e., a separate entry in dired-font-lock-keywords for the > failsafe. > > #+begin_src emacs-lisp > ;; Generic face for symbolic links > (list dired-re-sym > (when (not (connection-local-value dired-check-symlinks)) > '(".+" (dired-move-to-filename) nil (0 dired-symlink-face)))) > #+end_src > > This is essentially what I have in my config today, and seems to behave > as expected. Possible, but I don't see that one version is "better" or "worse" than the other. So I don't see a need to change it. Best regards, Michael.