From: Dmitry Gutov <dmitry@gutov.dev>
To: Eli Zaretskii <eliz@gnu.org>,
Daniel Mendler <mail@daniel-mendler.de>,
Daniel Colascione <dancol@dancol.org>
Cc: 74615@debbugs.gnu.org, monnier@iro.umontreal.ca
Subject: bug#74615: 30.0.92; js-find-symbol automatically activates ido-mode
Date: Sat, 30 Nov 2024 19:05:41 +0200 [thread overview]
Message-ID: <87dfab4e-d2cf-4e58-8c56-c3a7770e42cc@gutov.dev> (raw)
In-Reply-To: <86y1119mj4.fsf@gnu.org>
On 30/11/2024 10:02, Eli Zaretskii wrote:
>> js-find-symbol/js--read-symbol reads a symbol via ido-completing-read
>> and automatically activates ido-mode. For users of other completion
>> systems (default completion, Icomplete/Fido, Vertico, Helm, ...) this is
>> not desired. Icomplete/Fido/Vertico/etc. replace Ido and provide similar
>> behavior for general completing-read.
> This code is there since the day js.el was added, so I don't think
> removing the activation of ido-mode is something we can do
FWIW we've removed this command from the default js-mode bindings last
year (9cbf0bb3ee88) and haven't heard any complaints, so it might not
have too many users these days. Cleaning it up sounds reasonable.
next prev parent reply other threads:[~2024-11-30 17:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-30 6:37 bug#74615: 30.0.92; js-find-symbol automatically activates ido-mode Daniel Mendler via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-11-30 8:02 ` Eli Zaretskii
2024-11-30 16:18 ` Daniel Colascione
2024-11-30 17:05 ` Dmitry Gutov [this message]
2024-11-30 19:05 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87dfab4e-d2cf-4e58-8c56-c3a7770e42cc@gutov.dev \
--to=dmitry@gutov.dev \
--cc=74615@debbugs.gnu.org \
--cc=dancol@dancol.org \
--cc=eliz@gnu.org \
--cc=mail@daniel-mendler.de \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).