From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.bugs Subject: bug#553: 23.0.60; Unknown button type `quail-keyboard-layout-button' Date: Thu, 21 Aug 2008 19:41:58 -0400 Message-ID: <87d4k27x6h.fsf@cyd.mit.edu> Reply-To: Chong Yidong , 553@emacsbugs.donarmstrong.com NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1219363672 31461 80.91.229.12 (22 Aug 2008 00:07:52 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 22 Aug 2008 00:07:52 +0000 (UTC) Cc: 553@emacsbugs.donarmstrong.com To: Kenichi Handa Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Aug 22 02:08:44 2008 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KWKCn-0003tv-MG for geb-bug-gnu-emacs@m.gmane.org; Fri, 22 Aug 2008 02:08:42 +0200 Original-Received: from localhost ([127.0.0.1]:32830 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KWKBp-0001uD-46 for geb-bug-gnu-emacs@m.gmane.org; Thu, 21 Aug 2008 20:07:41 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KWKBl-0001rn-Je for bug-gnu-emacs@gnu.org; Thu, 21 Aug 2008 20:07:37 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KWKBk-0001pc-1v for bug-gnu-emacs@gnu.org; Thu, 21 Aug 2008 20:07:37 -0400 Original-Received: from [199.232.76.173] (port=37135 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KWKBj-0001pV-VV for bug-gnu-emacs@gnu.org; Thu, 21 Aug 2008 20:07:35 -0400 Original-Received: from rzlab.ucr.edu ([138.23.92.77]:42574) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KWKBj-0000Mv-3f for bug-gnu-emacs@gnu.org; Thu, 21 Aug 2008 20:07:35 -0400 Original-Received: from rzlab.ucr.edu (rzlab.ucr.edu [127.0.0.1]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m7M07Ruv011551; Thu, 21 Aug 2008 17:07:27 -0700 Original-Received: (from debbugs@localhost) by rzlab.ucr.edu (8.13.8/8.13.8/Submit) id m7LNo3vW004858; Thu, 21 Aug 2008 16:50:03 -0700 X-Loop: don@donarmstrong.com Resent-From: Chong Yidong Resent-To: bug-submit-list@donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Thu, 21 Aug 2008 23:50:02 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 553 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Original-Received: via spool by 553-submit@emacsbugs.donarmstrong.com id=B553.12193620422916 (code B ref 553); Thu, 21 Aug 2008 23:50:02 +0000 Original-Received: (at 553) by emacsbugs.donarmstrong.com; 21 Aug 2008 23:40:42 +0000 Original-Received: from cyd.mit.edu (CYD.MIT.EDU [18.115.2.24]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m7LNedit002910 for <553@emacsbugs.donarmstrong.com>; Thu, 21 Aug 2008 16:40:40 -0700 Original-Received: by cyd.mit.edu (Postfix, from userid 1000) id B391257E33F; Thu, 21 Aug 2008 19:41:58 -0400 (EDT) X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) Resent-Date: Thu, 21 Aug 2008 20:07:37 -0400 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:19622 Archived-At: Hi Handa-san, > 1. `emacs -Q' > 2. `M-: (require 'help-mode) RET' > or run any Help command that loads this mode > 3. Activate an input method by C-\ > 4. Click `mouse-3' on the input method's indicator > on the mode-line > > It fills the *Help* buffer with the text only until > it tries to create a button, and fails with the error > "make-text-button: Unknown button type `quail-keyboard-layout-button'". > > This is because `quail-help-init' fails to define new button types. > It currently has the form: > > (defun quail-help-init () > (unless (featurep 'help-mode) > (require 'help-mode) > (define-button-type 'quail-keyboard-layout-button > :supertype 'help-xref > 'help-function '(lambda (layout) > (help-setup-xref `(quail-keyboard-layout-button ,layout) > nil) > (quail-show-keyboard-layout layout)) > 'help-echo (purecopy "mouse-2, RET: show keyboard layout")) > > (define-button-type 'quail-keyboard-customize-button > :supertype 'help-customize-variable > 'help-echo (purecopy "mouse-2, RET: customize keyboard layout")))) > > So it doesn't define two button types if `help-mode' is already loaded. > > I guess it was done to define them only once, and not redefine on next > invocations. Do you remember why you wrote quail-help-init this way? It seems unnecessary; why not define the button types directly at the top level of quail.el?