From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.bugs Subject: bug#6762: 23.2; Eshell bug in detecting read-only file (patch included) Date: Fri, 30 Jul 2010 19:25:44 -0400 Message-ID: <87d3u4eemf.fsf@stupidchicken.com> References: <9725718A-C8F6-4D99-8B60-507A82AC0FE9@gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: dough.gmane.org 1280533088 30718 80.91.229.12 (30 Jul 2010 23:38:08 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 30 Jul 2010 23:38:08 +0000 (UTC) Cc: Leo , 6762-done@debbugs.gnu.org To: John Wiegley Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jul 31 01:38:05 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Oez9P-0008Ls-Lj for geb-bug-gnu-emacs@m.gmane.org; Sat, 31 Jul 2010 01:38:04 +0200 Original-Received: from localhost ([127.0.0.1]:56803 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Oez9O-00069h-P8 for geb-bug-gnu-emacs@m.gmane.org; Fri, 30 Jul 2010 19:38:02 -0400 Original-Received: from [140.186.70.92] (port=46057 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Oez9F-000693-Pl for bug-gnu-emacs@gnu.org; Fri, 30 Jul 2010 19:37:55 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Oez9D-0006xB-LT for bug-gnu-emacs@gnu.org; Fri, 30 Jul 2010 19:37:53 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:34962) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Oez9D-0006x5-JB for bug-gnu-emacs@gnu.org; Fri, 30 Jul 2010 19:37:51 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1Oeyxl-0002BY-Qy for bug-gnu-emacs@gnu.org; Fri, 30 Jul 2010 19:26:01 -0400 Resent-From: Chong Yidong Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Fri, 30 Jul 2010 23:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 6762 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Mail-Followup-To: 6762@debbugs.gnu.org, cyd@stupidchicken.com Original-Received: via spool by 6762-done@debbugs.gnu.org id=D6762.12805323298392 (code D ref 6762); Fri, 30 Jul 2010 23:26:01 +0000 Original-Received: (at 6762-done) by debbugs.gnu.org; 30 Jul 2010 23:25:29 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OeyxE-0002BJ-9J for submit@debbugs.gnu.org; Fri, 30 Jul 2010 19:25:28 -0400 Original-Received: from pantheon-po44.its.yale.edu ([130.132.50.78]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OeyxD-0002BC-4x for 6762-done@debbugs.gnu.org; Fri, 30 Jul 2010 19:25:27 -0400 Original-Received: from furry (dhcp128036014221.central.yale.edu [128.36.14.221]) (authenticated bits=0) by pantheon-po44.its.yale.edu (8.12.11.20060308/8.12.11) with ESMTP id o6UNPhpW015141 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Fri, 30 Jul 2010 19:25:43 -0400 Original-Received: by furry (Postfix, from userid 1000) id 15E5EC013; Fri, 30 Jul 2010 19:25:44 -0400 (EDT) In-Reply-To: <9725718A-C8F6-4D99-8B60-507A82AC0FE9@gmail.com> (John Wiegley's message of "Fri, 30 Jul 2010 06:15:52 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-YaleITSMailFilter: Version 1.2c (attachment(s) not renamed) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Fri, 30 Jul 2010 19:26:01 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:39087 Archived-At: John Wiegley writes: > Looks like a great patch to me. Checked in. Thanks. > On Jul 30, 2010, at 6:13 AM, Leo wrote: > >> I have diff-default-read-only set to t and this prevents eshell from >> writing to diff files i.e. >> >> ESHELL$ git diff x..y > file.diff >> >> fails due to its use of buffer-read-only, which doesn't necessary >> reflects the read-only state of a file. >> >> The following patch tries to fix this.