unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Chong Yidong <cyd@gnu.org>
To: Donald Ephraim Curtis <dcurtis@milkbox.net>
Cc: 10970@debbugs.gnu.org
Subject: bug#10970: 24.0.93; package.el doesn't load autoloads before compiling
Date: Sun, 11 Mar 2012 17:26:29 +0800	[thread overview]
Message-ID: <87d38jv67u.fsf@gnu.org> (raw)
In-Reply-To: <D27257A9-0314-4CEE-AD15-A8C50B4358A6@milkbox.net> (Donald Ephraim Curtis's message of "Thu, 8 Mar 2012 09:08:36 -0600")

Donald Ephraim Curtis <dcurtis@milkbox.net> writes:

> However, before compiling, the autoloads file (pkg-autoloads.el) is not
> loaded, so anything that updates the load-path is also not sourced.
>
> It may be best that packages simply put all their lisp files in the main
> package directory, but it also may be worthwhile to simply add,
>
> (load (expand-file-name (concat (symbol-name name) "-autoloads") pkg-dir) nil t)
>
> in the `package-unpack' function after the autoloads are generated.

I see the problem.  OTOH I don't see any actual bug that would arise
from loading the autoloads file before byte compilation.  But on the
other hand, it's kind of conceptually nice that the autoloads file is
only loaded when the package is activated, as a separate step from
unpacking.

Maybe it's better for the affected files to use `eval-when-compile' if
they need to alter the load path.

Anyone have another opinion?





  reply	other threads:[~2012-03-11  9:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-08 15:08 bug#10970: 24.0.93; package.el doesn't load autoloads before compiling Donald Ephraim Curtis
2012-03-11  9:26 ` Chong Yidong [this message]
2012-03-11 14:41   ` Stefan Monnier
2012-03-12  3:03     ` Chong Yidong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d38jv67u.fsf@gnu.org \
    --to=cyd@gnu.org \
    --cc=10970@debbugs.gnu.org \
    --cc=dcurtis@milkbox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).