unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Chong Yidong <cyd@gnu.org>
To: Florian Ebeling <florian.ebeling@gmail.com>
Cc: 11541@debbugs.gnu.org
Subject: bug#11541: 24.0.97; Crash when visiting file on OS X 10.7.3
Date: Thu, 31 May 2012 14:52:12 +0800	[thread overview]
Message-ID: <87d35kj10j.fsf@gnu.org> (raw)
In-Reply-To: <CAGOk8R8Ov_1TG3DMR8qGkpGB_qwU+9DYV3BXPYJCRewdGJ+Hrg@mail.gmail.com> (Florian Ebeling's message of "Wed, 30 May 2012 16:39:21 +0200")

Florian Ebeling <florian.ebeling@gmail.com> writes:

> It still stops at the same location, which is 531 after the patch.
>
> 524	    if (!FONT_SPEC_P (font_spec))
> 525	      abort ();
> 526	
> 527 fkeys = [NSMutableSet setWithArray: [[fdesc fontAttributes]
> allKeys]];
> 528	    if (isMatch)
> 529		[fkeys removeObject: NSFontFamilyAttribute];
> 530	
> 531 matchingDescs = [fdesc matchingFontDescriptorsWithMandatoryKeys:
> fkeys];
> (gdb) p font_spec
> $1 = 140734799760960
> (gdb) xtype
> Lisp_Int0

Does the following patch fix the crash?

=== modified file 'src/nsfont.m'
*** src/nsfont.m	2012-02-10 18:58:48 +0000
--- src/nsfont.m	2012-05-31 06:51:00 +0000
***************
*** 157,164 ****
  	fdesc = [fdesc fontDescriptorWithFamily: family];
        }
  
-     [fdAttrs release];
-     [tdict release];
      return fdesc;
  }
  
--- 157,162 ----






  reply	other threads:[~2012-05-31  6:52 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-22 10:29 bug#11541: 24.0.97; Crash when visiting file on OS X 10.7.3 Florian Ebeling
2012-05-24 22:08 ` bug#11541: Florian Ebeling
2012-05-26  8:33 ` bug#11541: 24.0.97; Crash when visiting file on OS X 10.7.3 Jan Djärv
2012-05-26 20:12   ` Florian Ebeling
2012-05-29 14:06 ` Chong Yidong
2012-05-29 19:48   ` Florian Ebeling
2012-05-30  3:22     ` Chong Yidong
2012-05-30  7:55       ` Florian Ebeling
2012-05-30 10:31         ` Chong Yidong
2012-05-30 10:53           ` C. Florian Ebeling
2012-05-30 13:36             ` Chong Yidong
2012-05-30 14:39               ` Florian Ebeling
2012-05-31  6:52                 ` Chong Yidong [this message]
2012-05-31  7:12                   ` Florian Ebeling
2012-05-31  9:31                     ` Chong Yidong
2012-05-31 10:19                       ` Florian Ebeling
2012-05-31 15:48                       ` Eli Zaretskii
2012-05-31 17:27                         ` C. Florian Ebeling
2012-05-31 17:54                           ` Eli Zaretskii
2012-05-31 19:15                             ` Alp Aker
2012-05-31 19:48                               ` Eli Zaretskii
2012-05-31 19:50                             ` C. Florian Ebeling
2012-05-31 20:11                               ` Eli Zaretskii
2012-05-31 21:55                                 ` Florian Ebeling
2012-06-01  3:50                                   ` YAMAMOTO Mitsuharu
2012-06-01  5:43                                     ` Florian Ebeling
2012-06-01  6:14                                       ` Eli Zaretskii
2012-06-01  6:36                                         ` Florian Ebeling
2012-06-01  6:41                                           ` Chong Yidong
2012-06-01  6:44                                             ` Florian Ebeling
2012-06-01  8:53                                               ` Eli Zaretskii
2012-06-01 11:57                                               ` Jan D.
2012-06-01 13:42                                                 ` Chong Yidong
2012-06-01  6:17                                       ` Eli Zaretskii
2012-06-01  6:46                                         ` Florian Ebeling
2012-06-01  8:47                                           ` Eli Zaretskii
2012-06-01  8:55                                             ` Florian Ebeling
2012-06-01  9:21                                               ` Eli Zaretskii
2012-06-01 14:51                                                 ` Florian Ebeling
2012-06-01 16:12                                                   ` Jan Djärv
     [not found]                                                 ` <mailman.2085.1338562350.855.bug-gnu-emacs@gnu.org>
2012-06-18 23:06                                                   ` jamezilla
2012-06-20 19:56                                                     ` Florian Ebeling
     [not found]                                                     ` <mailman.3138.1340222261.855.bug-gnu-emacs@gnu.org>
2012-06-22  5:29                                                       ` jamezilla
2012-06-01  8:52                                           ` Florian Ebeling
2012-06-01  8:56                                             ` Eli Zaretskii
2012-09-26 20:30 ` bug#11541: - Another reproduction - Emacs 24.2; Null pointer on OSX with cocoa UI mrevilgnome
2012-09-26 20:41   ` mrevilgnome
2012-10-14 18:58 ` bug#11541: 24.0.97; Crash when visiting file on OS X 10.7.3 Jan Djärv
2012-10-15 21:15   ` C. Florian Ebeling
2012-10-16  5:05     ` Jan Djärv
2012-11-01  9:49 ` Thomas Kappler
2012-11-06 11:01 ` bug#11541: Possible fix Thomas Kappler
2012-11-08 19:53   ` Jan Djärv
2012-11-09 10:27 ` bug#11541: THanks! Thomas Kappler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d35kj10j.fsf@gnu.org \
    --to=cyd@gnu.org \
    --cc=11541@debbugs.gnu.org \
    --cc=florian.ebeling@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).