From: Kenichi Handa <handa@gnu.org>
To: martin rudalics <rudalics@gmx.at>
Cc: kzhr@d1.dion.ne.jp, 12679@debbugs.gnu.org
Subject: bug#12679: 24.2.50; Can't font-at for the beginning of a string
Date: Tue, 30 Oct 2012 20:45:55 +0900 [thread overview]
Message-ID: <87d300uqrw.fsf@gnu.org> (raw)
In-Reply-To: <508296EA.60000@gmx.at> (message from martin rudalics on Sat, 20 Oct 2012 14:19:54 +0200)
In article <508296EA.60000@gmx.at>, martin rudalics <rudalics@gmx.at> writes:
> Could you please also (1) add a description of the STRING argument in
> the doc-string of `font-at',
I added this statement to the docstring.
Optional third arg STRING, if non-nil, is a string containing the target
character at index specified by POSITION.
> and (2) explain what happens when the
> selected window or the window passed as argument do not show the current
> buffer.
> IIUC face_at_buffer_position expects the window passed to it to
> show the current buffer but this might not be true when `font-at' calls
> it. There's also this comment in face_at_buffer_position:
> /* W must display the current buffer. We could write this function
> to use the frame and buffer of W, but right now it doesn't. */
> /* eassert (XBUFFER (w->buffer) == current_buffer); */
> Later in the code of face_at_buffer_position I see that w->buffer is
> sometimes used explicitly but get the impression that most other parts
> of the code use the current buffer instead.
I think your worrying is right. So, I changed font-at to
signal an error when the specified window is not displaying
the current buffer.
---
Kenichi Handa
handa@gnu.org
next prev parent reply other threads:[~2012-10-30 11:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-19 9:52 bug#12679: 24.2.50; Can't font-at for the beginning of a string Kazuhiro Ito
2012-10-19 13:11 ` Kenichi Handa
2012-10-20 12:19 ` martin rudalics
2012-10-30 11:45 ` Kenichi Handa [this message]
2012-10-30 18:49 ` martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d300uqrw.fsf@gnu.org \
--to=handa@gnu.org \
--cc=12679@debbugs.gnu.org \
--cc=kzhr@d1.dion.ne.jp \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).