From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Mark Lillibridge Newsgroups: gmane.emacs.bugs Subject: bug#13305: 24.2; describe-function gives incorrect function location information (for functions changed in a hook?) Date: Tue, 01 Jan 2013 11:34:22 -0800 Message-ID: <87d2xovgsh.fsf@foil.strangled.net> References: <87ehi8ty0m.fsf@foil.strangled.net> Reply-To: mdl@alum.mit.edu NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1357068899 11281 80.91.229.3 (1 Jan 2013 19:34:59 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 1 Jan 2013 19:34:59 +0000 (UTC) Cc: 13305@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jan 01 20:35:15 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Tq7cG-0006Nv-A0 for geb-bug-gnu-emacs@m.gmane.org; Tue, 01 Jan 2013 20:35:12 +0100 Original-Received: from localhost ([::1]:60372 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tq7c1-00037Q-7B for geb-bug-gnu-emacs@m.gmane.org; Tue, 01 Jan 2013 14:34:57 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:47863) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tq7by-00037I-1i for bug-gnu-emacs@gnu.org; Tue, 01 Jan 2013 14:34:56 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tq7br-0005ff-MA for bug-gnu-emacs@gnu.org; Tue, 01 Jan 2013 14:34:53 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:57284) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tq7br-0005fA-IR for bug-gnu-emacs@gnu.org; Tue, 01 Jan 2013 14:34:47 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1Tq7d5-0007S1-9l for bug-gnu-emacs@gnu.org; Tue, 01 Jan 2013 14:36:04 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Mark Lillibridge Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 01 Jan 2013 19:36:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13305 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: wontfix Original-Received: via spool by 13305-submit@debbugs.gnu.org id=B13305.135706895128617 (code B ref 13305); Tue, 01 Jan 2013 19:36:03 +0000 Original-Received: (at 13305) by debbugs.gnu.org; 1 Jan 2013 19:35:51 +0000 Original-Received: from localhost ([127.0.0.1]:39302 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tq7cs-0007RW-An for submit@debbugs.gnu.org; Tue, 01 Jan 2013 14:35:50 -0500 Original-Received: from alum-mailsec-scanner-1.mit.edu ([18.7.68.12]:51435) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Tq7cl-0007RJ-HC for 13305@debbugs.gnu.org; Tue, 01 Jan 2013 14:35:45 -0500 X-AuditID: 1207440c-b7f196d0000008bc-e8-50e33a4245c4 Original-Received: from outgoing-alum.mit.edu (OUTGOING-ALUM.MIT.EDU [18.7.68.33]) by alum-mailsec-scanner-1.mit.edu (Symantec Messaging Gateway) with SMTP id F5.60.02236.24A33E05; Tue, 1 Jan 2013 14:34:26 -0500 (EST) Original-Received: from foil.strangled.net (c-67-188-235-212.hsd1.ca.comcast.net [67.188.235.212]) (authenticated bits=0) (User authenticated as mdl@ALUM.MIT.EDU) by outgoing-alum.mit.edu (8.13.8/8.12.4) with ESMTP id r01JYNuE031817 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Tue, 1 Jan 2013 14:34:25 -0500 In-Reply-To: (message from Stefan Monnier on Sun, 30 Dec 2012 21:57:42 -0500) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpileLIzCtJLcpLzFFi42IRYndR1HWyehxgsOSLiMXOa1MYLaZ+PMNm 8e3XVmYHZo+/7z8weVyctI/ZY/2bvUwBzFHcNkmJJWXBmel5+nYJ3Bn7fv1hL+jjrLjzeQpb A+N89i5GTg4JAROJr+snsEHYYhIX7q0Hsrk4hAQuM0p83vSdBcK5wiTxuuczM0gVm4CmxPRn 38G6RQR0JU58O8sKYjMLSEq8fP+NCaRBWKCBUWLa0g4WkASnQKnE69bNYCuEBKQkli46AdbM IqAq8XXFIbAaXgF9iZOXVrFD2IISJ2c+YYEYKiFx8MUL5gmMfLOQpGYhSS1gZFrFKJeYU5qr m5uYmVOcmqxbnJyYl5dapGuol5tZopeaUrqJERJ6PDsYv62TOcQowMGoxMN7U/9xgBBrYllx Ze4hRkkOJiVR3m8WQCG+pPyUyozE4oz4otKc1OJDjBIczEoivMVfHgUI8aYkVlalFuXDpKQ5 WJTEeVWXqPsJCaQnlqRmp6YWpBbBZGU4OJQkeOssgYYKFqWmp1akZeaUIKSZODhBhnNJiRSn 5qWkFiWWlmTEg6IsvhgYZyApHqC98SDtvMUFiblAUYjWU4zGHD/+3HjKyPFr5c2njEIsefl5 qVLivGEgpQIgpRmleXCLYEnnFaM40N/CvC0gVTzAhAU37xXQKiagVVoMD0BWlSQipKQaGB3/ dL94ku2v4c3MeS45Pfn3jqPB7twyTEX6Mkb/rlucCVA18JjVyD/1lr7yPvEUX3bu3A+laydo m9ktq1zMmiYkk+b7guOdyWSuh3NurojZbu7T9YH1KtOT77xHJ5y+GtNRcXHxhwoD X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:69271 Archived-At: Stefan Monnier writes: > > Basically, this replaces the built-in version of > > rmail-summary-output with a patched version; the patching is done only > > Don't do that. Use defadvice or advice-add instead. For some reason I was thinking that changes to interactive didn't work properly with advice. Just using defun can be more convenient than advice, however, when you are in a hurry for a temporary patch. It's too bad there isn't a macro for replace-defun that acts syntactically identical to defun except that it uses advice to patch lazily the built-in (e.g., part of Emacs distribution) function. This would be a lot easier for users to understand and use. For that matter, what would be really useful is a small (10-20 page?) guide to patching Emacs with this sort of useful information. Yes, I know there is a 800+ page elisp manual that contains a lot of this information somewhere (maybe?) But the reality is that the average person trying to patch Emacs doesn't have time to read the manual and limits themselves to Google searches. You don't discover advice that way. - Mark