From: Thierry Volpiatto <thierry.volpiatto@gmail.com>
To: 13321@debbugs.gnu.org
Subject: bug#13321: 24.3.0.50; Gmail error when replying from Gnus to github
Date: Sat, 23 Feb 2013 11:06:19 +0100 [thread overview]
Message-ID: <87d2vr5opw.fsf@gmail.com> (raw)
In-Reply-To: <87a9surugk.fsf@gmail.com>
Thierry Volpiatto <thierry.volpiatto@gmail.com> writes:
> Katsumi Yamaoka <yamaoka@jpl.org> writes:
>
>> thierry.volpiatto@gmail.com wrote:
>>> Katsumi Yamaoka <yamaoka@jpl.org> writes:
>>>> Please let me say that a wide reply doesn't contain the author
>>>> of an original mail in the recipient list is a bug. To exclude
>>>> an invalid address from a wide reply is not a feature;
>>
>>> It is not excluded in the patch, it is added to "cc" only if "wide" is
>>> specified.
>> [...]
>>> Please have a look at the mail examples I sent in other posts.
>>
>> Hm, I haven't gotten it yet. Could you try replying to a mail
>> attached in this message as well (copy it to a mail group and do
>> F)?
>>
>> [...]
>>> The point is that with the patch I sent + the headers of the rejected
>>> mail and the original mail where I reply to, you will be able to
>>> understand what happen and fix it.
>>
>> Ok, I'll surely try it.
>
> And you can probaly get rid of this while loop too by removing
> duplicates in first place:
>
> - (message-tokenize-header recipients)))
> - ;; Remove all duplicates.
> - (let ((s recipients))
> - (while s
> - (let ((address (car (pop s))))
> - (while (assoc address s)
> - (setq recipients (delq (assoc address s) recipients)
> - s (delq (assoc address s) s))))))
> + ;; Remove all duplicates.
> + (loop with recip for mess in (message-tokenize-header recipients)
> + unless (member mess recip) collect mess into recip
> + finally return recip)))
>
> NOTE: `remove-duplicates' can't be used because you require cl at compile
> time only.
And while we are at it this one also can be simpler:
- (let ((plain-addrs (mapcar 'car recipients))
- subaddrs recip)
- (while plain-addrs
- (setq subaddrs (assoc (car plain-addrs)
- message-hierarchical-addresses)
- plain-addrs (cdr plain-addrs))
- (when subaddrs
- (setq subaddrs (cdr subaddrs))
- (while subaddrs
- (setq recip (assoc (car subaddrs) recipients)
- subaddrs (cdr subaddrs))
- (if recip
- (setq recipients (delq recip recipients))))))))
+ (setq recipients
+ (loop for (r . a) in recipients
+ for assoc = (cdr (assoc r message-hierarchical-addresses))
+ when assoc append assoc into recip
+ unless (member r recip) collect (cons r a) into results
+ finally return (cdr results))))
--
Thierry
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997
next prev parent reply other threads:[~2013-02-23 10:06 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-31 17:40 bug#13321: 24.3.0.50; Gmail error when replying from Gnus to github Thierry Volpiatto
2012-12-31 20:26 ` Andreas Schwab
2013-01-02 20:13 ` Lars Magne Ingebrigtsen
2013-01-02 21:14 ` Thierry Volpiatto
2013-01-02 22:50 ` Lars Magne Ingebrigtsen
2013-01-03 5:34 ` Thierry Volpiatto
2013-01-03 6:10 ` Lars Magne Ingebrigtsen
2013-01-03 6:41 ` Thierry Volpiatto
2013-01-08 6:35 ` Thierry Volpiatto
2013-02-14 6:35 ` Thierry Volpiatto
2013-02-21 16:22 ` Thierry Volpiatto
2013-02-21 16:53 ` Thierry Volpiatto
2013-02-21 19:40 ` Thierry Volpiatto
2013-02-22 7:15 ` Katsumi Yamaoka
2013-02-22 7:33 ` Thierry Volpiatto
2013-02-22 9:34 ` Katsumi Yamaoka
2013-02-22 10:06 ` Thierry Volpiatto
2013-02-22 11:17 ` Katsumi Yamaoka
2013-02-22 14:09 ` Thierry Volpiatto
2013-02-23 6:56 ` Thierry Volpiatto
2013-02-23 8:18 ` Thierry Volpiatto
2013-02-23 10:06 ` Thierry Volpiatto [this message]
2013-02-23 10:34 ` Thierry Volpiatto
2013-02-24 6:49 ` Thierry Volpiatto
2013-02-25 6:59 ` Katsumi Yamaoka
2013-02-25 7:08 ` Katsumi Yamaoka
2013-02-25 7:15 ` Thierry Volpiatto
2013-02-25 7:33 ` Katsumi Yamaoka
2013-02-25 9:17 ` Thierry Volpiatto
2013-02-25 11:29 ` Katsumi Yamaoka
2013-02-22 7:43 ` Thierry Volpiatto
2013-02-22 7:51 ` Thierry Volpiatto
2013-02-22 7:53 ` Thierry Volpiatto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d2vr5opw.fsf@gmail.com \
--to=thierry.volpiatto@gmail.com \
--cc=13321@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).