unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Stephen Berman <stephen.berman@gmx.net>
To: Glenn Morris <rgm@gnu.org>
Cc: 14806@debbugs.gnu.org
Subject: bug#14806: 24.3.50; Enabling read-file-name-completion-ignore-case breaks url-handler-mode
Date: Thu, 11 Jul 2013 00:20:56 +0200	[thread overview]
Message-ID: <87d2qqjbuf.fsf@gmx.net> (raw)
In-Reply-To: <eutxk2qha4.fsf@fencepost.gnu.org> (Glenn Morris's message of "Wed, 10 Jul 2013 16:41:39 -0400")

On Wed, 10 Jul 2013 16:41:39 -0400 Glenn Morris <rgm@gnu.org> wrote:

> Stephen Berman wrote:
>
>> 0. emacs -Q
>> 1. M-: (setq read-file-name-completion-ignore-case t)  (or customize it,
>>    or use set-variable)
>> 2. M-x url-handler-mode
>> 3. C-x C-f http://www.gnu.org RET
>> => error "Unimplemented"
>
> RET actually runs minibuffer-complete-and-exit, when
> completion-ignore-case is non-nil it tries to complete the input,
> completion is (obviously) not implemented for URLs.
> Dunno what to do about that.

To prevent the problem I reported, we could either change

(defun url-file-name-completion (url directory &optional predicate)
  (error "Unimplemented"))

to

(defun url-file-name-completion (url directory &optional predicate)
  (ignore))

or replace

(put 'file-name-completion 'url-file-handlers 'url-file-name-completion)

by

(put 'file-name-completion 'url-file-handlers 'ignore)

url-handlers.el already does the latter for "operations that we do not
support yet (DAV!!!)".  If the user tries to complete with TAB,
url-file-name-all-completions errors with "Unimplemented".  If we use
'ignore here too, then trying to complete gives "[No match]".  But as
long as the URL is valid and real, the page gets downloaded, so this
certainly seems better than the current state.  Is there some other
reason not to do this?

Steve Berman





  reply	other threads:[~2013-07-10 22:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-06 19:57 bug#14806: 24.3.50; Enabling read-file-name-completion-ignore-case breaks url-handler-mode Stephen Berman
2013-07-10 20:41 ` Glenn Morris
2013-07-10 22:20   ` Stephen Berman [this message]
2013-07-31  4:19     ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d2qqjbuf.fsf@gmx.net \
    --to=stephen.berman@gmx.net \
    --cc=14806@debbugs.gnu.org \
    --cc=rgm@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).