unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@jurta.org>
To: Stefan Monnier <monnier@IRO.UMontreal.CA>
Cc: 16035@debbugs.gnu.org, Anders Lindgren <andlind@gmail.com>
Subject: bug#16035: 24.3.50; Custom isearch broken on trunk (e.g. change-log-mode)
Date: Thu, 19 Dec 2013 22:39:12 +0200	[thread overview]
Message-ID: <87d2ksfx5i.fsf@mail.jurta.org> (raw)
In-Reply-To: <jwv8uvhj759.fsf-monnier+emacsbugs@gnu.org> (Stefan Monnier's message of "Thu, 19 Dec 2013 08:35:56 -0500")

>> Meanwhile, I found another problem: typing <backspace>
>> in Isearch while in the Gnus Summary buffer exits Isearch
>> and runs `gnus-summary-prev-page' because <backspace>
>> is bound explicitly in Gnus.
>
> Looks like a bug in Gnus, since DEL is not bound.  I.e. Gnus's binding
> should be to DEL and not to `backspace'.

Then I'll install this patch.  It was necessary also to remove
[backspace] from `gnus-suppress-keymap' because without the last hunk
typing `backspace' in an Article buffer called `gnus-summary-prev-page',
but not `gnus-article-goto-prev-page' as it should.

=== modified file 'lisp/gnus/gnus-art.el'
--- lisp/gnus/gnus-art.el	2013-12-14 21:43:01 +0000
+++ lisp/gnus/gnus-art.el	2013-12-19 20:33:12 +0000
@@ -4396,7 +4396,6 @@ (gnus-define-keys gnus-article-mode-map
   [?\S-\ ] gnus-article-goto-prev-page
   "\177" gnus-article-goto-prev-page
   [delete] gnus-article-goto-prev-page
-  [backspace] gnus-article-goto-prev-page
   "\C-c^" gnus-article-refer-article
   "h" gnus-article-show-summary
   "s" gnus-article-show-summary

=== modified file 'lisp/gnus/gnus-group.el'
--- lisp/gnus/gnus-group.el	2013-12-14 21:43:01 +0000
+++ lisp/gnus/gnus-group.el	2013-12-19 20:33:12 +0000
@@ -571,7 +571,6 @@ (gnus-define-keys gnus-group-mode-map
   "p" gnus-group-prev-unread-group
   "\177" gnus-group-prev-unread-group
   [delete] gnus-group-prev-unread-group
-  [backspace] gnus-group-prev-unread-group
   "N" gnus-group-next-group
   "P" gnus-group-prev-group
   "\M-n" gnus-group-next-unread-group-same-level

=== modified file 'lisp/gnus/gnus-sum.el'
--- lisp/gnus/gnus-sum.el	2013-09-17 17:22:32 +0000
+++ lisp/gnus/gnus-sum.el	2013-12-19 20:33:12 +0000
@@ -1850,7 +1850,6 @@ (gnus-define-keys gnus-summary-mode-map
   [?\S-\ ] gnus-summary-prev-page
   "\177" gnus-summary-prev-page
   [delete] gnus-summary-prev-page
-  [backspace] gnus-summary-prev-page
   "\r" gnus-summary-scroll-up
   "\M-\r" gnus-summary-scroll-down
   "n" gnus-summary-next-unread-article
@@ -2222,7 +2221,6 @@ (gnus-define-keys (gnus-summary-backend-
   "\M-\C-e" gnus-summary-expire-articles-now
   "\177" gnus-summary-delete-article
   [delete] gnus-summary-delete-article
-  [backspace] gnus-summary-delete-article
   "m" gnus-summary-move-article
   "r" gnus-summary-respool-article
   "w" gnus-summary-edit-article

=== modified file 'lisp/gnus/gnus.el'
--- lisp/gnus/gnus.el	2013-08-13 07:18:50 +0000
+++ lisp/gnus/gnus.el	2013-12-19 20:33:52 +0000
@@ -3035,7 +3035,7 @@ (defcustom gnus-summary-line-format "%U%
 
 (defun gnus-suppress-keymap (keymap)
   (suppress-keymap keymap)
-  (let ((keys `([backspace] [delete] "\177" "\M-u"))) ;gnus-mouse-2
+  (let ((keys `([delete] "\177" "\M-u"))) ;gnus-mouse-2
     (while keys
       (define-key keymap (pop keys) 'undefined))))
 





  reply	other threads:[~2013-12-19 20:39 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-03  9:38 bug#16035: 24.3.50; Custom isearch broken on trunk (e.g. change-log-mode) Anders Lindgren
2013-12-04  0:14 ` Juri Linkov
2013-12-04  0:18 ` Juri Linkov
2013-12-04  0:37   ` Juri Linkov
2013-12-04  4:31   ` Stefan Monnier
2013-12-04 11:48     ` Anders Lindgren
2013-12-04 17:57       ` Stefan Monnier
2013-12-04 21:49         ` Anders Lindgren
2013-12-05  1:20         ` Juri Linkov
2013-12-05  2:45           ` Stefan Monnier
2013-12-06  0:57             ` Juri Linkov
2013-12-11  0:12               ` Juri Linkov
2013-12-16  8:13                 ` Anders Lindgren
2013-12-16 20:32                   ` Juri Linkov
2013-12-17  6:17                     ` Anders Lindgren
2013-12-17 19:38                       ` Juri Linkov
2013-12-18  8:02                         ` Anders Lindgren
2013-12-18 23:22                           ` Juri Linkov
2013-12-19 13:35                             ` Stefan Monnier
2013-12-19 20:39                               ` Juri Linkov [this message]
2013-12-05 15:33           ` Anders Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87d2ksfx5i.fsf@mail.jurta.org \
    --to=juri@jurta.org \
    --cc=16035@debbugs.gnu.org \
    --cc=andlind@gmail.com \
    --cc=monnier@IRO.UMontreal.CA \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).