From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Tassilo Horn Newsgroups: gmane.emacs.bugs Subject: bug#17985: 24.3.92; doc-view-open-text raises wrong-type-argument error Date: Mon, 28 Jul 2014 11:10:06 +0200 Message-ID: <87d2cpg87l.fsf@gnu.org> References: <87r41twgb9.fsf@rosalinde.fritz.box> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1406538808 24636 80.91.229.3 (28 Jul 2014 09:13:28 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 28 Jul 2014 09:13:28 +0000 (UTC) Cc: 17985-close@debbugs.gnu.org To: Stephen Berman Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jul 28 11:13:21 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XBgzf-00008Q-Pc for geb-bug-gnu-emacs@m.gmane.org; Mon, 28 Jul 2014 11:13:19 +0200 Original-Received: from localhost ([::1]:38420 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XBgzf-0003bL-Bx for geb-bug-gnu-emacs@m.gmane.org; Mon, 28 Jul 2014 05:13:19 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38003) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XBgzW-0003Wj-16 for bug-gnu-emacs@gnu.org; Mon, 28 Jul 2014 05:13:16 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XBgzO-0003ut-Q6 for bug-gnu-emacs@gnu.org; Mon, 28 Jul 2014 05:13:09 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:44888) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XBgzO-0003up-Me for bug-gnu-emacs@gnu.org; Mon, 28 Jul 2014 05:13:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XBgzO-0003mq-AU for bug-gnu-emacs@gnu.org; Mon, 28 Jul 2014 05:13:02 -0400 Resent-From: Tassilo Horn Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Mon, 28 Jul 2014 09:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 17985 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Mail-Followup-To: 17985@debbugs.gnu.org, tsdh@gnu.org, stephen.berman@gmx.net Original-Received: via spool by 17985-done@debbugs.gnu.org id=D17985.140653873114483 (code D ref 17985); Mon, 28 Jul 2014 09:13:01 +0000 Original-Received: (at 17985-close) by debbugs.gnu.org; 28 Jul 2014 09:12:11 +0000 Original-Received: from localhost ([127.0.0.1]:40153 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XBgyZ-0003lX-4W for submit@debbugs.gnu.org; Mon, 28 Jul 2014 05:12:11 -0400 Original-Received: from deliver.uni-koblenz.de ([141.26.64.15]:51577) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XBgyW-0003lM-H2 for 17985-close@debbugs.gnu.org; Mon, 28 Jul 2014 05:12:09 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by deliver.uni-koblenz.de (Postfix) with ESMTP id 14A0D1A8499; Mon, 28 Jul 2014 11:12:07 +0200 (CEST) X-Virus-Scanned: amavisd-new at uni-koblenz.de Original-Received: from deliver.uni-koblenz.de ([127.0.0.1]) by localhost (deliver.uni-koblenz.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id iJCoiBri3D27; Mon, 28 Jul 2014 11:12:06 +0200 (CEST) X-CHKRCPT: Envelopesender noch tsdh@gnu.org Original-Received: from thinkpad-t440p (dhcp201.uni-koblenz.de [141.26.71.201]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by deliver.uni-koblenz.de (Postfix) with ESMTPSA id AF2501A8493; Mon, 28 Jul 2014 11:12:06 +0200 (CEST) In-Reply-To: <87r41twgb9.fsf@rosalinde.fritz.box> (Stephen Berman's message of "Thu, 10 Jul 2014 14:26:18 +0200") User-Agent: Gnus/5.130012 (Ma Gnus v0.12) Emacs/24.4.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:91873 Archived-At: Stephen Berman writes: > If I'm using Gnus to read mail with an attachment, I can type `c' on > the attachment to view it in another buffer, and if the attachment is > something that Doc View can handle, I can type `C-c C-c' in the buffer > to view the rendered image of the attachment. But if I then type `C-c > C-t' (doc-view-open-text) to view the ascii text of the attachment, I > get this error: > > Debugger entered--Lisp error: (wrong-type-argument stringp nil) > file-name-nondirectory(nil) > doc-view-open-text() > call-interactively(doc-view-open-text nil nil) > command-execute(doc-view-open-text) > > The reason is that Doc View expects the buffer to be visiting a file. > But with an mail attachment, that does not have to be the case (when I > type `C-c C-c', Doc View says: "The buffer has been modified. Save the > changes? (y or n)", but if I answer "n", it still renders the image). > The following patch lets me view the ascii text whether or not the > buffer containing the document is visiting a file. (The patch is > against emacs-24; the error also happens in trunk.) Thanks, I've committed it on the trunk. (As it's not a regression, I don't think it should go in emacs-24.) ,---- | revno: 117599 | author: Stephen Berman | committer: Tassilo Horn | branch nick: trunk | timestamp: Mon 2014-07-28 11:07:56 +0200 | message: | Open doc text also if it's not saved to a file. | | * doc-view.el (doc-view-open-text): Don't require that the | document is saved in a file (e.g., email attachment). `---- Bye, Tassilo