From: Ivan Shmakov <ivan@siamics.net>
To: 19903@debbugs.gnu.org
Subject: bug#19903: 24.4; wrong-type-argument symbolp "bold" during enriched-encode
Date: Fri, 20 Feb 2015 21:09:35 +0000 [thread overview]
Message-ID: <87d25447e8.fsf@violet.siamics.net> (raw)
In-Reply-To: <jwv61awl5q0.fsf-monnier+emacsbugs@gnu.org> (Stefan Monnier's message of "Fri, 20 Feb 2015 14:55:35 -0500")
>>>>> Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> + (warn "Face %S is a string; interning" face)
>> + (message "Face %S is a string; interning" face)
> Why `warn' in one and `message' in the other?
By the time we hit this in ‘face-attribute’, the point at which
the sub-setandard string-named face was introduced is presumably
long gone, so there’s no good reason to use ‘warn’.
On the contrary, ‘facemenu-add-face’ is likely to be invoked
either directly by the user, or as part of some other
interactive command. Should the call result in a warning,
the user would probably be able to gather enough context from
his or her actions immediately preceding the warning.
> These could end up spewing a lot of warnings at times, so it's a bit
> risky, but if such uses are sufficiently rare it might be OK.
At least so I hope.
--
FSF associate member #7257 http://boycottsystemd.org/ … 3013 B6A0 230E 334A
next prev parent reply other threads:[~2015-02-20 21:09 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-19 17:15 bug#19903: 24.4; Emacs fails to save enriched buffer with error message `wrong-type-argument symbolp "bold"' Jorge
2015-02-19 18:48 ` bug#19903: 24.4; wrong-type-argument symbolp "bold" during enriched-encode Ivan Shmakov
2015-02-20 8:27 ` bug#19903: 24.4; Emacs fails to save enriched buffer with error message `wrong-type-argument symbolp "bold"' Eli Zaretskii
2015-02-20 8:51 ` Jorge
2015-02-20 9:12 ` bug#19903: 24.4; wrong-type-argument symbolp "bold" during enriched-encode Ivan Shmakov
2015-02-20 10:07 ` Eli Zaretskii
2015-02-20 17:18 ` Stefan Monnier
2015-02-20 18:56 ` Ivan Shmakov
2015-02-20 19:55 ` Stefan Monnier
2015-02-20 21:09 ` Ivan Shmakov [this message]
2015-02-21 11:12 ` Ivan Shmakov
2015-02-21 11:42 ` Eli Zaretskii
2015-02-25 6:20 ` Ivan Shmakov
2015-02-25 16:06 ` Eli Zaretskii
2015-02-25 17:10 ` Ivan Shmakov
2015-02-25 17:43 ` Eli Zaretskii
2015-02-25 17:55 ` Ivan Shmakov
2015-02-21 12:12 ` bug#19912: facemenu-add-face: does not handle 'face being set to a property list Ivan Shmakov
2015-02-25 7:05 ` Ivan Shmakov
2015-02-25 17:24 ` Ivan Shmakov
2015-02-26 18:12 ` Ivan Shmakov
2015-02-20 10:03 ` bug#19903: 24.4; Emacs fails to save enriched buffer with error message `wrong-type-argument symbolp "bold"' Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87d25447e8.fsf@violet.siamics.net \
--to=ivan@siamics.net \
--cc=19903@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).