From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Krzysztof Jurewicz Newsgroups: gmane.emacs.bugs Subject: bug#20541: ERC password fetching using Secret Service API is broken Date: Sun, 10 May 2015 16:13:56 +0200 Message-ID: <87d228lduj.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: ger.gmane.org 1431267323 25137 80.91.229.3 (10 May 2015 14:15:23 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 10 May 2015 14:15:23 +0000 (UTC) To: 20541@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun May 10 16:15:12 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YrS0d-00030w-An for geb-bug-gnu-emacs@m.gmane.org; Sun, 10 May 2015 16:15:11 +0200 Original-Received: from localhost ([::1]:33683 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YrS0c-0004oc-ND for geb-bug-gnu-emacs@m.gmane.org; Sun, 10 May 2015 10:15:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59171) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YrS0Z-0004mQ-Fk for bug-gnu-emacs@gnu.org; Sun, 10 May 2015 10:15:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YrS0W-0002Dx-9s for bug-gnu-emacs@gnu.org; Sun, 10 May 2015 10:15:07 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:58391) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YrS0W-0002Dg-6J for bug-gnu-emacs@gnu.org; Sun, 10 May 2015 10:15:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YrS0V-0001Zs-Oz for bug-gnu-emacs@gnu.org; Sun, 10 May 2015 10:15:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Krzysztof Jurewicz Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 10 May 2015 14:15:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 20541 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.14312672545983 (code B ref -1); Sun, 10 May 2015 14:15:03 +0000 Original-Received: (at submit) by debbugs.gnu.org; 10 May 2015 14:14:14 +0000 Original-Received: from localhost ([127.0.0.1]:40133 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YrRzh-0001YQ-HU for submit@debbugs.gnu.org; Sun, 10 May 2015 10:14:14 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:45545) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YrRzf-0001YD-E8 for submit@debbugs.gnu.org; Sun, 10 May 2015 10:14:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YrRzZ-0001wG-5V for submit@debbugs.gnu.org; Sun, 10 May 2015 10:14:06 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:52493) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YrRzZ-0001wC-38 for submit@debbugs.gnu.org; Sun, 10 May 2015 10:14:05 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59046) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YrRzY-0004i4-4N for bug-gnu-emacs@gnu.org; Sun, 10 May 2015 10:14:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YrRzU-0001vs-UZ for bug-gnu-emacs@gnu.org; Sun, 10 May 2015 10:14:04 -0400 Original-Received: from mail-lb0-x232.google.com ([2a00:1450:4010:c04::232]:32933) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YrRzU-0001vo-MN for bug-gnu-emacs@gnu.org; Sun, 10 May 2015 10:14:00 -0400 Original-Received: by lbbzk7 with SMTP id zk7so79007004lbb.0 for ; Sun, 10 May 2015 07:13:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:mime-version:content-type :content-transfer-encoding; bh=9ZO6duy7EIXxzTslsFlBQ11WQ/ljn3FJf12fTGl317U=; b=NLVv0oNZqzyQXshEXxw48mMukSV7upqoUslZJwNKSq+wb2G8AL+Ts2atqiMPhIwaWe uxvLiQ0Eue7NPigf4SATb0vG6YM3Z5RKgogn2nNH1X3AeTHbSLixqikzAQZdR7Ddasas vCs3flHuvooUuaOHXIpVqYP6Py8mxj+coLQSliFqJe5M3WFLEEY7XzxXaESeOk2+3j83 bWQMPGgwWpyF+NQEVJUFfZNzqnVYW7qyvO26JqONnhDXQX67z2P/+3yELMnpOj2gyljC 6atgdUNOgq4zVdtAo47wq1iz1pInfpnqSYWox/g0iFhquxXqlb5brZy3DUgmmNPy138Q LiUg== X-Received: by 10.112.138.195 with SMTP id qs3mr4716686lbb.47.1431267239726; Sun, 10 May 2015 07:13:59 -0700 (PDT) Original-Received: from knp ([5.174.143.129]) by mx.google.com with ESMTPSA id lu12sm2407722lac.49.2015.05.10.07.13.57 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 10 May 2015 07:13:58 -0700 (PDT) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:102632 Archived-At: When trying to store ERC passwords using Secret Service API (i.e. when using GNOME Keyring), ERC breaks when trying to join a channel. Steps to reproduce: ⒈ Run emacs -Q. ⒉ Eval (require 'auth-source). ⒊ Eval (setq auth-sources '("secrets:FOO")), where FOO is an existing keyring name. ⒋ Open ERC. ⒌ Try to connect to Freenode using the default settings. What happens: The following error is displayed: auth-source-secrets-listify-pattern: Wrong type argument: sequencep, 6667 What should happen: I should connect to Freenode. One possible patch is attached below. This is the simplest solution; I have not thought much about whether it may be more desirable to convert numbers to strings inside the secrets.el package. >From 25f798b3b86a34bd6b262c59c3733d72eec50c13 Mon Sep 17 00:00:00 2001 From: Krzysztof Jurewicz Date: Thu, 7 May 2015 13:01:24 +0200 Subject: [PATCH] * lisp/erc/erc.el (erc-open): Fix password fetching ERC used to pass the port number as a number, however when using Secret Service API, only strings can be used. Copyright-paperwork-exempt: yes --- lisp/erc/erc.el | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lisp/erc/erc.el b/lisp/erc/erc.el index cf422f1..a8f1478 100644 --- a/lisp/erc/erc.el +++ b/lisp/erc/erc.el @@ -2010,7 +2010,8 @@ Returns the buffer for the given server or channel." (auth-source-search :host server :max 1 :user nick - :port port + ;; secrets.el wouldn’t accept a number + :port (if (numberp port) (number-to-string port) port) :require '(:secret))) :secret))) (if (functionp secret) -- 2.4.0