From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#17453: Isearch doesn't work properly with Follow Mode. Date: Tue, 03 Nov 2015 01:45:54 +0200 Organization: LINKOV.NET Message-ID: <87d1vs3qxd.fsf@mail.linkov.net> References: <20151029232302.GB3812@acm.fritz.box> <87h9l6627a.fsf@mail.linkov.net> <20151031235651.GE1853@acm.fritz.box> <87bnbddzpk.fsf@mail.linkov.net> <20151102092853.GA11804@acm.fritz.box> <20151102123512.GB11804@acm.fritz.box> <20151102154445.GD11804@acm.fritz.box> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1446508103 3911 80.91.229.3 (2 Nov 2015 23:48:23 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 2 Nov 2015 23:48:23 +0000 (UTC) Cc: Alan Mackenzie , 17453@debbugs.gnu.org, bruce.connor.am@gmail.com To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Nov 03 00:48:12 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZtOpf-0007To-Dk for geb-bug-gnu-emacs@m.gmane.org; Tue, 03 Nov 2015 00:48:11 +0100 Original-Received: from localhost ([::1]:44818 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZtOpe-0004NN-M9 for geb-bug-gnu-emacs@m.gmane.org; Mon, 02 Nov 2015 18:48:10 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:32817) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZtOpb-0004NH-AX for bug-gnu-emacs@gnu.org; Mon, 02 Nov 2015 18:48:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZtOpW-000121-7F for bug-gnu-emacs@gnu.org; Mon, 02 Nov 2015 18:48:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:59448) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZtOpW-00011v-36 for bug-gnu-emacs@gnu.org; Mon, 02 Nov 2015 18:48:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1ZtOpV-0000Ol-N3 for bug-gnu-emacs@gnu.org; Mon, 02 Nov 2015 18:48:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 02 Nov 2015 23:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17453 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 17453-submit@debbugs.gnu.org id=B17453.14465080601497 (code B ref 17453); Mon, 02 Nov 2015 23:48:01 +0000 Original-Received: (at 17453) by debbugs.gnu.org; 2 Nov 2015 23:47:40 +0000 Original-Received: from localhost ([127.0.0.1]:50155 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZtOp9-0000O3-Qq for submit@debbugs.gnu.org; Mon, 02 Nov 2015 18:47:40 -0500 Original-Received: from sub3.mail.dreamhost.com ([69.163.253.7]:58853 helo=homiemail-a101.g.dreamhost.com) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZtOp8-0000Nw-5e for 17453@debbugs.gnu.org; Mon, 02 Nov 2015 18:47:38 -0500 Original-Received: from homiemail-a101.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a101.g.dreamhost.com (Postfix) with ESMTP id 4E14A117E078; Mon, 2 Nov 2015 15:47:37 -0800 (PST) Original-Received: from localhost.linkov.net (62.65.227.66.cable.starman.ee [62.65.227.66]) (Authenticated sender: jurta@jurta.org) by homiemail-a101.g.dreamhost.com (Postfix) with ESMTPA id 1C27D117E06A; Mon, 2 Nov 2015 15:47:35 -0800 (PST) In-Reply-To: (Drew Adams's message of "Mon, 2 Nov 2015 11:28:18 -0800 (PST)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (x86_64-pc-linux-gnu) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:108332 Archived-At: >> > I believe this was already taken care of by work that Juri did recently. >> > I don't have time to look this up now, but see recent bug reports. >> >> I ran a git log on isearch.el and I think you're referring to this change: >> >> 10ec0468dfbc0815a772cc46a031aca298af0985 Lazy-highlight the whole >> string at point (debbugs:19353) >> >> If so, that's just about extending the bound a little bit to ensure it >> holds a whole symbol. follow-mode actually needs to extend the bound a >> lot more (up 'till the `window-end' of the last window in the group). > > Please check with Juri. I'm pretty sure the discussion included > the possibility of having lazy highlighting throughout a buffer. Yes, what I meant is: diff --git a/lisp/follow.el b/lisp/follow.el index 938c59e..fc970bb 100644 --- a/lisp/follow.el +++ b/lisp/follow.el @@ -419,6 +419,7 @@ (define-minor-mode follow-mode :keymap follow-mode-map (if follow-mode (progn + (setq-local lazy-highlight-buffer t) (add-hook 'compilation-filter-hook 'follow-align-compilation-windows t t) (add-hook 'post-command-hook 'follow-post-command-hook t) (add-hook 'window-size-change-functions 'follow-window-size-change t))