From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Benjamin Riefenstahl Newsgroups: gmane.emacs.bugs Subject: bug#22257: 25.0.50; bidi-paragraph-direction is sticky in eww (patch) Date: Mon, 28 Dec 2015 17:38:58 +0100 Message-ID: <87d1tq1qal.fsf@justinian.i-did-not-set--mail-host-address--so-tickle-me> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: ger.gmane.org 1451320825 14321 80.91.229.3 (28 Dec 2015 16:40:25 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 28 Dec 2015 16:40:25 +0000 (UTC) To: 22257@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Dec 28 17:40:12 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aDaqB-0005mC-DK for geb-bug-gnu-emacs@m.gmane.org; Mon, 28 Dec 2015 17:40:11 +0100 Original-Received: from localhost ([::1]:45070 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aDaqA-0007yW-Hp for geb-bug-gnu-emacs@m.gmane.org; Mon, 28 Dec 2015 11:40:10 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55676) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aDaq6-0007wu-Bh for bug-gnu-emacs@gnu.org; Mon, 28 Dec 2015 11:40:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aDaq2-0002jj-FX for bug-gnu-emacs@gnu.org; Mon, 28 Dec 2015 11:40:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:38992) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aDaq2-0002jf-CF for bug-gnu-emacs@gnu.org; Mon, 28 Dec 2015 11:40:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84) (envelope-from ) id 1aDaq2-0002p8-5i for bug-gnu-emacs@gnu.org; Mon, 28 Dec 2015 11:40:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Benjamin Riefenstahl Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 28 Dec 2015 16:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 22257 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.145132075210790 (code B ref -1); Mon, 28 Dec 2015 16:40:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 28 Dec 2015 16:39:12 +0000 Original-Received: from localhost ([127.0.0.1]:46594 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aDapD-0002ny-Ob for submit@debbugs.gnu.org; Mon, 28 Dec 2015 11:39:11 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:36015) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aDapC-0002nm-MN for submit@debbugs.gnu.org; Mon, 28 Dec 2015 11:39:10 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aDap6-0002EZ-Ep for submit@debbugs.gnu.org; Mon, 28 Dec 2015 11:39:05 -0500 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:58551) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aDap6-0002EV-B1 for submit@debbugs.gnu.org; Mon, 28 Dec 2015 11:39:04 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:55197) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aDap5-0007ZA-7t for bug-gnu-emacs@gnu.org; Mon, 28 Dec 2015 11:39:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aDap2-0002D6-0L for bug-gnu-emacs@gnu.org; Mon, 28 Dec 2015 11:39:03 -0500 Original-Received: from odoacer.turtle-trading.net ([217.91.34.180]:55541) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aDap1-0002D0-OR for bug-gnu-emacs@gnu.org; Mon, 28 Dec 2015 11:38:59 -0500 Original-Received: from justinian.turtle-trading.net ([192.168.2.118]) by odoacer.turtle-trading.net with esmtp (Exim 4.80) (envelope-from ) id 1aDap0-0001df-KL; Mon, 28 Dec 2015 17:38:58 +0100 Original-Received: from benny by justinian.turtle-trading.net with local (Exim 4.84) (envelope-from ) id 1aDap0-0001EP-Gz; Mon, 28 Dec 2015 17:38:58 +0100 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:110894 Archived-At: --=-=-= Content-Type: text/plain When I have visited a page in eww that contains Hebrew text and than switch to a non-Hebrew page, bidi-paragraph-direction is still set RTL. A simple fix is attached. The bug will still happen if the LTR page does not have an element at all, but we may not care. --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=bidi-sticky.patch diff --git a/lisp/net/shr.el b/lisp/net/shr.el index c28e0b8..47f7f9c 100644 --- a/lisp/net/shr.el +++ b/lisp/net/shr.el @@ -1103,12 +1103,9 @@ shr-previous-newline-padding-width ;;; Tag-specific rendering rules. (defun shr-tag-html (dom) - (let ((dir (dom-attr dom 'dir))) - (cond - ((equal dir "ltr") - (setq bidi-paragraph-direction 'left-to-right)) - ((equal dir "rtl") - (setq bidi-paragraph-direction 'right-to-left)))) + (if (equal dir(dom-attr dom 'dir) "rtl") + (setq bidi-paragraph-direction 'right-to-left) + (setq bidi-paragraph-direction 'left-to-right)) (shr-generic dom)) (defun shr-tag-body (dom) --=-=-= Content-Type: text/plain In GNU Emacs 25.0.50.8 (i686-pc-linux-gnu, GTK+ Version 2.24.25) of 2015-12-28 built on justinian Repository revision: f9d87dd8791d4e77929f21e4f73d92ef966722cc Windowing system distributor 'The X.Org Foundation', version 11.0.11604000 System Description: Debian GNU/Linux 8.2 (jessie) Configured features: XPM JPEG TIFF GIF PNG RSVG SOUND GPM DBUS GCONF GSETTINGS NOTIFY LIBSELINUX GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS GTK2 X11 Important settings: value of $LANG: en_US.UTF-8 value of $XMODIFIERS: @im=ibus locale-coding-system: utf-8-unix --=-=-=--