From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: =?UTF-8?Q?=C3=93scar?= Fuentes Newsgroups: gmane.emacs.bugs Subject: bug#22438: 24.5; Orphaned tooltip kills daemon (Lucid) Date: Sat, 23 Jan 2016 00:56:03 +0100 Message-ID: <87d1stkw30.fsf@wanadoo.es> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1453507042 17110 80.91.229.3 (22 Jan 2016 23:57:22 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 22 Jan 2016 23:57:22 +0000 (UTC) Cc: 22438@debbugs.gnu.org To: Nicole Edwards Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jan 23 00:57:11 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aMlZm-0008Dx-Dx for geb-bug-gnu-emacs@m.gmane.org; Sat, 23 Jan 2016 00:57:10 +0100 Original-Received: from localhost ([::1]:55955 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aMlZl-0004sE-K5 for geb-bug-gnu-emacs@m.gmane.org; Fri, 22 Jan 2016 18:57:09 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42835) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aMlZi-0004s6-Hr for bug-gnu-emacs@gnu.org; Fri, 22 Jan 2016 18:57:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aMlZe-00074o-CC for bug-gnu-emacs@gnu.org; Fri, 22 Jan 2016 18:57:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:41726) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aMlZe-00074k-8r for bug-gnu-emacs@gnu.org; Fri, 22 Jan 2016 18:57:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84) (envelope-from ) id 1aMlZe-0005be-0x for bug-gnu-emacs@gnu.org; Fri, 22 Jan 2016 18:57:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?=C3=93scar?= Fuentes Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 22 Jan 2016 23:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22438 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 22438-submit@debbugs.gnu.org id=B22438.145350698121497 (code B ref 22438); Fri, 22 Jan 2016 23:57:01 +0000 Original-Received: (at 22438) by debbugs.gnu.org; 22 Jan 2016 23:56:21 +0000 Original-Received: from localhost ([127.0.0.1]:58179 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aMlYz-0005af-Jy for submit@debbugs.gnu.org; Fri, 22 Jan 2016 18:56:21 -0500 Original-Received: from smtp10.acens.net ([86.109.99.134]:34459 helo=smtp.movistar.es) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aMlYw-0005aO-RB for 22438@debbugs.gnu.org; Fri, 22 Jan 2016 18:56:20 -0500 X-CTCH-RefID: str=0001.0A0B0204.56A2C195.0035, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown Original-Received: from qcore (83.38.42.1) by smtp.movistar.es (8.6.122.03) (authenticated as 981711563$telefonica.net) id 56623BC803E2F768; Fri, 22 Jan 2016 23:56:05 +0000 In-Reply-To: (Nicole Edwards's message of "Fri, 22 Jan 2016 17:04:36 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:111867 Archived-At: Nicole Edwards writes: > If I call up (or dismiss all but) one frame, ask it to display > a tooltip, then destroy it while the tooltip is open, the tooltip > remains open, and unless I create a new frame within a few seconds, > Emacs dies. (Mercifully, so does the tooltip.) [snip] The problem is in src/xfns.c:6087. Emacs explicitly redisplays the current frame's menu bar without testing that it is alive. The patch below solves the problem. Eli, ok to commit? diff --git a/src/xfns.c b/src/xfns.c index aad9680..9624ac5 100644 --- a/src/xfns.c +++ b/src/xfns.c @@ -6084,16 +6084,19 @@ Value is t if tooltip was open, nil otherwise. */) items is unmapped. Redisplay the menu manually... */ { Widget w; - struct frame *f = SELECTED_FRAME (); - w = f->output_data.x->menubar_widget; + struct frame *f = SELECTED_FRAME (); + if (FRAME_X_P (f) && FRAME_LIVE_P (f)) + { + w = f->output_data.x->menubar_widget; - if (!DoesSaveUnders (FRAME_DISPLAY_INFO (f)->screen) - && w != NULL) - { - block_input (); - xlwmenu_redisplay (w); - unblock_input (); - } + if (!DoesSaveUnders (FRAME_DISPLAY_INFO (f)->screen) + && w != NULL) + { + block_input (); + xlwmenu_redisplay (w); + unblock_input (); + } + } } #endif /* USE_LUCID */ }